Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: id76147eb:Fastmail
Message-ID: <d7efebcc-5b5b-185e-bec8-b6b9d5d27d93@undef.tools>
Date:   Tue, 4 Apr 2023 18:13:20 +1000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] arm64: dts: rockchip: Change serial baud rate for
 Pinephone Pro to 1.5 MB
To:     =?UTF-8?Q?Heiko_St=c3=bcbner?= <heiko@sntech.de>,
        linux-kernel@vger.kernel.org,
        Javier Martinez Canillas <javierm@redhat.com>
Cc:     Peter Robinson <pbrobinson@gmail.com>,
        Caleb Connolly <kc@postmarketos.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Martijn Braam <martijn@brixit.nl>, Ondrej Jirman <megi@xff.cz>,
        Rob Herring <robh+dt@kernel.org>,
        Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
References: <20230403175937.2842085-1-javierm@redhat.com>
 <3738011.44csPzL39Z@diego>
Content-Language: en-US
From:   Jarrah <kernel@undef.tools>
In-Reply-To: <3738011.44csPzL39Z@diego>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 4/4/23 17:51, Heiko Stübner wrote:
> The interesting question is always if this will break someone else's setup.
> I've never really understood the strange setting of 1.5MBps, but on the
> other hand it _is_ a reality on most boards.
>
> Personally I don't care that much either way, but would like a comment
> from the other people working on that device - if possible.


I don't have a strong opinion either way, but I would note that 
Tow-Boot[0] which later models of this device ship with uses 115200, 
meaning that this would put the device out of sync with the default 
u-boot implementation from the factory.

At least for me it's been convenient to have both the PP and PPP use the 
same settings while debugging.


Thanks,

Jarrah.


[0] https://tow-boot.org/