Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757070AbXIXHY2 (ORCPT ); Mon, 24 Sep 2007 03:24:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750890AbXIXHYV (ORCPT ); Mon, 24 Sep 2007 03:24:21 -0400 Received: from turing-police.cc.vt.edu ([128.173.14.107]:45814 "EHLO turing-police.cc.vt.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbXIXHYU (ORCPT ); Mon, 24 Sep 2007 03:24:20 -0400 X-Mailer: exmh version 2.7.2 01/07/2005 with nmh-1.2 To: Jan Engelhardt Cc: Alexey Dobriyan , akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Uninline kcalloc() In-Reply-To: Your message of "Mon, 24 Sep 2007 08:22:31 +0200." From: Valdis.Kletnieks@vt.edu References: <20070922200349.GA2119@martell.zuzino.mipt.ru> <25045.1190612108@turing-police.cc.vt.edu> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1190618652_3132P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Mon, 24 Sep 2007 03:24:12 -0400 Message-ID: <3721.1190618652@turing-police.cc.vt.edu> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1954 Lines: 52 --==_Exmh_1190618652_3132P Content-Type: text/plain; charset=us-ascii On Mon, 24 Sep 2007 08:22:31 +0200, Jan Engelhardt said: > > On Sep 24 2007 01:35, Valdis.Kletnieks@vt.edu wrote: > >On Sun, 23 Sep 2007 00:03:49 +0400, Alexey Dobriyan said: > > > >> -static inline void *kcalloc(size_t n, size_t size, gfp_t flags) > >> -{ > >> - if (n != 0 && size > ULONG_MAX / n) > >> - return NULL; > >> - return __kmalloc(n * size, flags | __GFP_ZERO); > >> -} > >> +void *kcalloc(size_t n, size_t size, gfp_t flags); > > > >NAK. > > > >This busticates some pretty subtle code in mm/slab.c that uses > >uses __builtin_return_address() for debugging - if you do this, then > >the "calling function" gets listed as "kcalloc()" rather than the much more > >useful "function that called kcalloc()" (which is what you care about). > > > >(I remember going around and around multiple times getting those stupid > >inlines set up right, so that feature actually did something useful, otherwise > >kcalloc and kzalloc didn't report where they were called from). > > Since 'inline' is only a hint , should not it be __always_inline, > so that __builtin_return_address() always works? At the time I was trying to fix that, saying "inline" actually forced it to be so. Probably need to go re-check that, since there's been about forty-leven different "tweak the semantics of inline" since then.... --==_Exmh_1190618652_3132P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Exmh version 2.5 07/13/2001 iD8DBQFG92YccC3lWbTT17ARAhHyAJ0bUKdrFU9L+TMXDpSHwx2UiBS4/wCdHv2F OwedN+mpvKrcNTSvcCmEZAA= =P5C0 -----END PGP SIGNATURE----- --==_Exmh_1190618652_3132P-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/