Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230403175937.2842085-1-javierm@redhat.com> <3738011.44csPzL39Z@diego>
 <d7efebcc-5b5b-185e-bec8-b6b9d5d27d93@undef.tools> <87h6twdpi7.fsf@minerva.mail-host-address-is-not-set>
In-Reply-To: <87h6twdpi7.fsf@minerva.mail-host-address-is-not-set>
From:   Peter Robinson <pbrobinson@gmail.com>
Date:   Tue, 4 Apr 2023 09:38:44 +0100
Message-ID: <CALeDE9M4eNq1sfQ-UcNZr8naYThmLFxDpt=zj8WkCSzHPUY8ug@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Change serial baud rate for
 Pinephone Pro to 1.5 MB
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     Jarrah <kernel@undef.tools>,
        =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        linux-kernel@vger.kernel.org, Caleb Connolly <kc@postmarketos.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Martijn Braam <martijn@brixit.nl>, Ondrej Jirman <megi@xff.cz>,
        Rob Herring <robh+dt@kernel.org>,
        Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 4, 2023 at 9:24=E2=80=AFAM Javier Martinez Canillas
<javierm@redhat.com> wrote:
>
> Jarrah <kernel@undef.tools> writes:
>
> > Hi,
> >
> > On 4/4/23 17:51, Heiko St=C3=BCbner wrote:
> >> The interesting question is always if this will break someone else's s=
etup.
> >> I've never really understood the strange setting of 1.5MBps, but on th=
e
> >> other hand it _is_ a reality on most boards.
> >>
> >> Personally I don't care that much either way, but would like a comment
> >> from the other people working on that device - if possible.
> >
> >
> > I don't have a strong opinion either way, but I would note that
> > Tow-Boot[0] which later models of this device ship with uses 115200,
> > meaning that this would put the device out of sync with the default
> > u-boot implementation from the factory.
> >
>
> Probably we can't change then because it would break the setup of people
> using Tow-Boot as a bootloader.
>
> > At least for me it's been convenient to have both the PP and PPP use th=
e
> > same settings while debugging.
> >
>
> Agreed, all my other boards use 115200 as well, the only exceptions are
> the Rockpro64 and PinePhone Pro for me.

All Rockchips devices use 1.5m except a chromebook and the Puma, and
this device.