Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4235f3f7-bae5-1f5e-582e-077bc5d03306@gmail.com>
Date:   Tue, 4 Apr 2023 16:40:01 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: [PATCH REBASED] KVM: x86: SVM: Fix one redefine issue about
 VMCB_AVIC_APIC_BAR_MASK
Content-Language: en-US
To:     "Paolo Bonzini - Distinguished Engineer (kernel-recipes.org) (KVM HoF)" 
        <pbonzini@redhat.com>, Xinghui Li <korantli@tencent.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org,
        korantwork@gmail.com, seanjc@google.com, tglx@linutronix.de,
        mingo@redhat.com, mlevitsk@redhat.com
References: <20230403095200.1391782-1-korantwork@gmail.com>
From:   Like Xu <like.xu.linux@gmail.com>
In-Reply-To: <20230403095200.1391782-1-korantwork@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/4/2023 5:52 pm, korantwork@gmail.com wrote:
> From: Xinghui Li <korantli@tencent.com>
> 
> VMCB_AVIC_APIC_BAR_MASK is defined twice with the same value in svm.h,
> which is meaningless. Delete the duplicate one.
> 
> Fixes: 391503528257 ("KVM: x86: SVM: move avic definitions from AMD's spec to svm.h")
> Signed-off-by: Xinghui Li <korantli@tencent.com>

Reviewed-by: Like Xu <likexu@tencent.com>

Do we have any tool to find out more similar issues across numerous subsystems ?

> ---
>   arch/x86/include/asm/svm.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
> index 770dcf75eaa9..e236b896f8b4 100644
> --- a/arch/x86/include/asm/svm.h
> +++ b/arch/x86/include/asm/svm.h
> @@ -278,7 +278,6 @@ static_assert((AVIC_MAX_PHYSICAL_ID & AVIC_PHYSICAL_MAX_INDEX_MASK) == AVIC_MAX_
>   static_assert((X2AVIC_MAX_PHYSICAL_ID & AVIC_PHYSICAL_MAX_INDEX_MASK) == X2AVIC_MAX_PHYSICAL_ID);
>   
>   #define AVIC_HPA_MASK	~((0xFFFULL << 52) | 0xFFF)
> -#define VMCB_AVIC_APIC_BAR_MASK		0xFFFFFFFFFF000ULL
>   
>   
>   struct vmcb_seg {