Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5674061rwl; Tue, 4 Apr 2023 01:47:53 -0700 (PDT) X-Google-Smtp-Source: AKy350ZLqpE4by8rMHuqEnLuzf6YGsZxWNXNuF8F7oh6ZyOxFnLokTwekWxiZIAacWPbmDUInDR9 X-Received: by 2002:a05:6402:194:b0:4ad:1e35:771f with SMTP id r20-20020a056402019400b004ad1e35771fmr2168506edv.35.1680598073002; Tue, 04 Apr 2023 01:47:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680598072; cv=none; d=google.com; s=arc-20160816; b=r3gGes47kghHNPrkw9JVvly3Ljzgu17uSUlxkS0rRhYVpgN9FTSlYgj5UYmzOwb40n XvfZW0w0BwREVMMGPUDv1zwm8nxTseAlb6ozvWtQZuAACwIGKJHhVyz77TAanf8gByZH m9FMCsrGXJcXjVdk4SnmVAZcEYWSKE7/+g9qJx12wPP5W/rG9IqQoOxLeqS27tppqnsO dABD0zD0dNxARdgQtUKs+2laaBq+Nnv2f/QANZZBFrB2MvIVa2Uj0E0ZYoGjfGJ2820e eGCi3xN3xH4Ade1r5k6026eUvL/i3h/P8gXtZzJ8ZqAVih0mlo6/jF1QLdfonmDXISIP Btzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=qFniWraH9Zx9AU/nIcDS2ZhpqD+XkT7RdXcaMNk7s1Q=; b=Iy2YivDW/weah7fpS1pwvsb2eUD+Kwe8PPlarISju5T0K7iGasLviUExeCidQVGpqz kumktu+96SYhzC/hjJpimANlTokRePON0xnQBADcTFoNg4DTetwvQmVkN4LUJuBSydKh Kh1D0gYtq08/eY7uKWCNKA8stB96WlmLI/xGibx91XmK/uf+LvCff7Tidr3rKIJLnXVB TjoM4K9eaEdn8lEK/M2Gd8aEPXK+KNxrdAIqxsv8ufcQXJnvbTxZY63CCQSvREFao4Jh kz4/aqw1Hs3ofjJZvpMtqQ6VWSiU+yerjPOBnbkmM4Y4DpN99+yGjjarKgXuC5iL1idv 1rdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NDZD77ER; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g18-20020a056402181200b00501c32ce664si321129edy.325.2023.04.04.01.47.28; Tue, 04 Apr 2023 01:47:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NDZD77ER; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234009AbjDDIpS (ORCPT + 99 others); Tue, 4 Apr 2023 04:45:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233886AbjDDIpR (ORCPT ); Tue, 4 Apr 2023 04:45:17 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAEA01BF for ; Tue, 4 Apr 2023 01:45:15 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id ew6so127392398edb.7 for ; Tue, 04 Apr 2023 01:45:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680597914; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qFniWraH9Zx9AU/nIcDS2ZhpqD+XkT7RdXcaMNk7s1Q=; b=NDZD77ERGU54AP9UX0o03dGSoBhWlpLKC1F1q4/spgOo6ufcp1HxDNMlcs9ACQsg5g if12rdV9irOBZhnU32KKzvVzlnakoLV2M8HJFMZHycBL2tyxRRJglIdqhzJi0BeKuBr7 3o5j7aFQsVplZuwdxXisbDR4gD8sGyzUJfXM1xJV0bqsYok3UsukvOyR6pS9U0VG2alJ +k7+G5jtRkwQL2dWwZ8ukA/TvGors5PwA8qn0S5gLvnl0yNHMz2HzvH8l84W+ZF0t2Id 1PjxnFzuMk48SnEshbFf5lEHfBUCmrcXWupGnPVpbAT25YbnSx1jCkcArKyqhZn12kj1 zsig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680597914; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qFniWraH9Zx9AU/nIcDS2ZhpqD+XkT7RdXcaMNk7s1Q=; b=eLsyhUjAdcnsZgIezbwgC1WpFAqw27xVMuLcs3Hr1SYGVbjCVvcSlF80MX3kbMUsjq zwg+uR5aIvZqoE3MaThphBrGgpQXzxdgIDT0I2RH+WMg73H/ZBDXmKLFZtIytZCD87eS vvydGTGZZmKLOy4C+Cqhm7DA21cQg2NogTCMSzXlezW67xYbVnmFXb7XF9P+ge1dBVcY vIw3/naeh+/Abj2if9VzZWFceUTa2c+KUZHtNDpYfz1f4GtWqt3giE5QUugKBZ++15sz 71u/DYuJnw7R8HBVakdBHlJeeTkTx1FAFLi4IO8rO3uZjW6nyiWrn9BBKkbeSr8aE00m atlQ== X-Gm-Message-State: AAQBX9c7iIYM9462BiULJLtSqicF1E0yhPy/w1nUrNiOkDM70qeH1yai Dd+aZVlyWD9uSaXKrvfqiKujOQ== X-Received: by 2002:aa7:d618:0:b0:4af:6c5e:225c with SMTP id c24-20020aa7d618000000b004af6c5e225cmr1829126edr.33.1680597914216; Tue, 04 Apr 2023 01:45:14 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:233a:5c18:b527:381e? ([2a02:810d:15c0:828:233a:5c18:b527:381e]) by smtp.gmail.com with ESMTPSA id r19-20020a50c013000000b004fd29e87535sm5561237edb.14.2023.04.04.01.45.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 01:45:13 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 10:45:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 06/11] dt-bindings: PCI: Update the RK3399 example to a valid one Content-Language: en-US To: Rick Wertenbroek , alberto.dassatti@heig-vd.ch Cc: damien.lemoal@opensource.wdc.com, xxm@rock-chips.com, Shawn Lin , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Heiko Stuebner , Johan Jonker , Brian Norris , Caleb Connolly , Corentin Labbe , Judy Hsiao , Lin Huang , Arnaud Ferraris , Hugh Cole-Baker , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230404082426.3880812-1-rick.wertenbroek@gmail.com> <20230404082426.3880812-7-rick.wertenbroek@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20230404082426.3880812-7-rick.wertenbroek@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2023 10:24, Rick Wertenbroek wrote: > Update the example in the documentation a valid example. > The default max-outbound-regions is 32 but the example showed 16. This is not reason to be invalid. It is perfectly fine to change default values to desired ones. What is not actually obvious is to change some value to a default one, instead of removing it... > Address for mem-base was invalid. Added pinctrl. > > Signed-off-by: Rick Wertenbroek > --- > .../devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml > index 88386a6d7011..0c67e96096eb 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip,rk3399-pcie-ep.yaml > @@ -47,14 +47,15 @@ examples: > > pcie-ep@f8000000 { > compatible = "rockchip,rk3399-pcie-ep"; > - reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0x80000000 0x0 0x20000>; > - reg-names = "apb-base", "mem-base"; Reg (and reg-names) is usually second property, why moving it? What is incorrect in the placement? > + rockchip,max-outbound-regions = <32>; > clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>, > <&cru PCLK_PCIE>, <&cru SCLK_PCIE_PM>; > clock-names = "aclk", "aclk-perf", > "hclk", "pm"; > max-functions = /bits/ 8 <8>; > num-lanes = <4>; > + reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0xfa000000 0x0 0x2000000>; > + reg-names = "apb-base", "mem-base"; > resets = <&cru SRST_PCIE_CORE>, <&cru SRST_PCIE_MGMT>, > <&cru SRST_PCIE_MGMT_STICKY>, <&cru SRST_PCIE_PIPE> , > <&cru SRST_PCIE_PM>, <&cru SRST_P_PCIE>, <&cru SRST_A_PCIE>; > @@ -62,7 +63,8 @@ examples: > "pm", "pclk", "aclk"; > phys = <&pcie_phy 0>, <&pcie_phy 1>, <&pcie_phy 2>, <&pcie_phy 3>; > phy-names = "pcie-phy-0", "pcie-phy-1", "pcie-phy-2", "pcie-phy-3"; > - rockchip,max-outbound-regions = <16>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pcie_clkreqnb_cpm>; > }; > }; > ... Best regards, Krzysztof