Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b1eb8356-4519-4c95-b3ee-afc142b8d17f@suse.com>
Date:   Tue, 4 Apr 2023 10:53:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH v7 3/6] Documentation: Add ABI doc for attributes of LJCA
 device
To:     Ye Xiang <xiang.ye@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Matthias Kaehlcke <mka@chromium.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@kernel.org>,
        Tyrone Ting <kfting@nuvoton.com>,
        Mark Brown <broonie@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>, linux-usb@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org
Cc:     srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
        andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
        zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com
References: <20230325154711.2419569-1-xiang.ye@intel.com>
 <20230325154711.2419569-4-xiang.ye@intel.com>
Content-Language: en-US
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20230325154711.2419569-4-xiang.ye@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ni9UenNNNWR5QUhIdGxjMnpERTYwbEROdldYdnoraStvc0toZnJGRzRPdWVN?=
 =?utf-8?B?WkNzUDBNOWxVUXYwR3VjTjI5QTZoelhJc1hPb2RUazl2QmF0MWNnRTZxL0I3?=
 =?utf-8?B?Rm8yQXVrL2NJQ3NBZ3VBRWtaKyttT1JUTkY0d3Q4ampCWFJDNS9lYXFVSkpo?=
 =?utf-8?B?VU1IVU9VWWl1WjNnc2pmUnBMWnh3L0lsdU9RSzdvU2NkNWszdXNrUzZzbmJi?=
 =?utf-8?B?MlhmNHQyZUUreTJuUlJXSlp1L3ZEcTFtSktjWDh4Y0xDb1NJbzFuZUFzTUN1?=
 =?utf-8?B?ditLMEM5dTlPZ2FuYzhUN2VNc0ladmxtcExSTjlSK1YwRSsybkZIUGJOa0Iv?=
 =?utf-8?B?VWpZNG9wR2RTSUNTWTY5cDlSVlZ6TnpycS9lY3k5a0pWMi91MTRZMjZEODNW?=
 =?utf-8?B?QkVwc203aTAwOHhORENpM1diU0wyQThOTWZmYUpVdjNUWDRiN3RnSmRKeEwy?=
 =?utf-8?B?aTgvQWQ0T0JwZzhZWkZNNk5zbjFNbXpiVHI1ODd6Mk1VdmxOVTRIMitiMHpy?=
 =?utf-8?B?ZTlobkhibmt5TS9ZYlRlbFk4bkVkd3BpdUp6QjVIdXd1K2JmckxZR09GOWpv?=
 =?utf-8?B?WW1KeTl2VU92M3ljL01hSjIyTk9lK1J5N3NYNTI1UFJ6T0w4cHdlWFhvSzUv?=
 =?utf-8?B?QXFvb2JtUmwrblVjSkRCRWNzQmVab3prSTJ0b0ZRUUoyUkdmRldjeTBPWTFJ?=
 =?utf-8?B?TFhIOTFFVmVmdnM3eHhiN0o0QWFIZ2RZbEtZTnVuQXNKUkhIcUZmdmExZkxH?=
 =?utf-8?B?eUk0WDZyam04eEpzbVFCTDNQVWZqeDJrRzhvMmNBY1paZVgvSHdKeFhWdGgv?=
 =?utf-8?B?Y1NCVzFic1FTRTdneUdONDlwOEtpa1NOK2tjSTJ2MjhrdkhSNVdEOXd6WFJJ?=
 =?utf-8?B?TFdFWktHMmptNFhGRDlZMEtaWU1kYThFNFRVSVBJanNWTXdlalgrU09GcUVD?=
 =?utf-8?B?N1B0K2JHNHMwdHZMOGZDVktheGlCK0svQzRTeU9tTWYyekh1VFFVMGREYWFX?=
 =?utf-8?B?VGxmM3doTlRKaW1QTTF5TDB6bWg3L1RYY2N2STltQnVwV2hyNHR5OGxka2F4?=
 =?utf-8?B?UGIxdVFYckNYSDNUM0lWcGJEWENVVUJ1b0NRcnVwbnJYbjBidGdxN3FCaG9x?=
 =?utf-8?B?NnQzV3BjVzM3VlAvUDdhUTEzVXVIa21zTHJ3WlZyaGhWL1B0aUVBRS9kdWhK?=
 =?utf-8?B?aDFXTnBTOWx0L3orUEhPK1plbS9XK01US3ViQ3VHeEhGTDBMalZlOHhYcTZo?=
 =?utf-8?B?RC8rRG9BbVNMTTVGNTJ2U3hGdU1rVTdLOTlSWUlJTmEvYWNOY0Z2TFRkaVhZ?=
 =?utf-8?B?SlNGZFk1dFpnQTJkSHdQZHNVUWV4Um1kajc0c2ZVZUpvVEtzbGxFL05nUjV6?=
 =?utf-8?B?akxlSHcyUVRQZDlpOFNpK0dBbk10ZGJKTTBxeVk1UVFRZHBCY3pMN2ZnTFJp?=
 =?utf-8?B?NlBaZ2ZueWgzbitGSzRPb205MXZ1emFITE1lMjNiN0M3WjNMMUxWczdyd2Ns?=
 =?utf-8?B?WUZJYVJlSWJnYkhMdE5lU2hkZWdXUytaanBCaHRQdUY1UGNjYnVHZldNV250?=
 =?utf-8?B?SEFOemt6UEF4dHRnemRDWk96SjdJWmNGeHBhSzJINWZsaWw4bnludVcvYlp1?=
 =?utf-8?B?Y0ZQamdCbVBCRGtVc3lTbG4zSWVUZWtZTENkdFJhN0JTR1BGdzl0d1h4M0Z2?=
 =?utf-8?B?L2Y2RHpYM2J2akEwOStjUlMvVEhlNFgyV2RqRjE5YWJ4Z09XN0FMSXZIU3Yy?=
 =?utf-8?B?a01RSzA3Z0Z5YklqK2hNeFFJL2tZVmhKUGJBc04wUHRwS2Vja01GdmoxTFFP?=
 =?utf-8?B?S1l2ZVQ2alBFdmRsWEp4TkxlZ1N5d0NRODlrS1BnY0tlbUVEVEhKS3B6MU5U?=
 =?utf-8?B?UUZrOUR5aGt3QVUxZ1RnNER4cFI2QTBBbmQreEM0U2ZuNXZsYTBROWNoVDZS?=
 =?utf-8?B?K1B5RHhzTmU2RlZjdmdrbXNyOGl2bDNVYkxqN01mU25uL3NsbkQ4eDlhTk1l?=
 =?utf-8?B?VllXWGVIYjNDUzFxaHJvUWxNZWoySmZCQUo2TnM5MHgzK29RSDdkTEtKMmRB?=
 =?utf-8?B?a25CYnlKbnBEdFhKZm5tVTdKQTBCSC9VYVdhVVMzMkE5QXpqU3hQVnBZM2ZG?=
 =?utf-8?B?c0Qxakc4SlNQTUVoaGducHRPSTk5dkZ4UXk1VnZGZzl3dUl2Kzd3bGhUK0FM?=
 =?utf-8?Q?u2FbeExOwz32GOd+YmnYxwpoRoyBEvIFhbe7GeuuW6I5?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b339ff23-d36e-41dd-0db1-08db34ea1cec
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 08:53:53.8769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3CyDD2uXpavlekMmYzuHaV1F6PODAEdbKBVIDmn32HwvR4zfJ5iWi+enOuILlYESJ4qOUHW2oFDhxiuM/LhfNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9371
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 25.03.23 16:47, Ye Xiang wrote:
> Add sysfs attributes Documentation entries for LJCA device

Hi,

do we really want each driver to have its own attribute for that?
It seems to me that that should be unified.

	Regards
		Oliver

> +
> +What:		/sys/bus/usb/.../ljca_enable_dfu
> +Date:		July 2023
> +KernelVersion:	6.4
> +Contact:	Ye Xiang<xiang.ye@intel.com>
> +Description:
> +		Writing 1 to this file to force the LJCA device into DFU
> +		mode so the firmware can be updated. After firmware
> +		updating has been done, the device will back to normal
> +		working mode.