Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tilki, Ibrahim" <Ibrahim.Tilki@analog.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     "a.zummo@towertech.it" <a.zummo@towertech.it>,
        "jdelvare@suse.com" <jdelvare@suse.com>,
        "linux@roeck-us.net" <linux@roeck-us.net>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "Arslanbenzer, Zeynep" <Zeynep.Arslanbenzer@analog.com>
Subject: RE: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs
Thread-Topic: [PATCH v5 2/2] dt-bindings: rtc: add max313xx RTCs
Thread-Index: AQHZZkM1/0NcmmhHVE+7c9BLHmZIxK8arcoAgAAOpACAACNY0A==
Date:   Tue, 4 Apr 2023 09:26:42 +0000
Message-ID: <CY4PR03MB2488DFC99C23ADE16FF40E2F96939@CY4PR03MB2488.namprd03.prod.outlook.com>
References: <20230403154342.3108-1-Ibrahim.Tilki@analog.com>
 <20230403154342.3108-3-Ibrahim.Tilki@analog.com>
 <dd6f0842-519f-1bc9-f7f5-459863dc3dcd@linaro.org>
 <202304040710049c9cc01a@mail.local>
In-Reply-To: <202304040710049c9cc01a@mail.local>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Zx/px/7/jXsK1ui8DTLGSmLuvnH9ia2h+YlWOvlJ9Qlp4BG3fMGgGrBVxO15?=
 =?us-ascii?Q?LqKLHT0PeJU7ABqUbN9LeXbTknA10tF4J5DABamWs+ZR47Sbr1rOqBbR2T4K?=
 =?us-ascii?Q?tLL55u91vnP640/UL79ouQ7LRzlrq8HTSvjRD92F+l+NRTG1IhwwvDpHqz2N?=
 =?us-ascii?Q?7BnzEAIDE1n8YqAV78Sjwn2RkQZV+F1un5Cc21Xnkw0zESlBfPLRZDIyF6Pb?=
 =?us-ascii?Q?CMRTryzDq4+ui0AD0bpXoZxiJUzzCkuOPomBii196LN5Rs8CNF7VO6Sj12BF?=
 =?us-ascii?Q?wTdNiCOHgV1cYjqjbCUBMVEtgiNVN3abC0v+uZc8Kt27ily2IBe0zddO6EbG?=
 =?us-ascii?Q?jVYXv6ZLwiajJkoPQQ0lMRmkdjt8IEx2vK+l4R9sT4W2zsoEeD0sXl6z+LBP?=
 =?us-ascii?Q?iIfcHHjHAIWSyxLJ+UkqPpsFGTsQ3HbQCz9Org+B37UBGBjNjXE6CgYW8i4F?=
 =?us-ascii?Q?i591rinzqE1KKXDIaIPTHHjWKOFCNnVhgFNr8GOfTR5UcSyoN+/cDk0HxCXh?=
 =?us-ascii?Q?cHBgt/udOCukpfNYNPRS0N/IkWbuSrsBAlauaUkr4lrjicus+DzXpiOC+equ?=
 =?us-ascii?Q?sXMnvZfYmaAKHa4QF6SiCq5vJ7do/WB3IVo/mRRpwvBS+XsqRVc1D+TYNwYC?=
 =?us-ascii?Q?VqSsY+Jq70agESjD+ZdqzQ4PG6ZIGxuXaH2x1uXZgI4uVMbxYD9RmM1JmnTF?=
 =?us-ascii?Q?IobQJUdHCln7/31wCWDZi1nrpVdAkg4AFOG7RDZClN+MI3EdJ8p7rwyAgUmV?=
 =?us-ascii?Q?wuUI+NrgmMjLvuqBvpYYmrEV9VdK5v0nX3rKHuHC4qaTOzCCkoLRgjICyuhY?=
 =?us-ascii?Q?FYEe6QU3hZ0ZmgGS0nZm092v7WNlTmj5FRU87Ysoikr8jaPHV7AD67gVQ1gC?=
 =?us-ascii?Q?twX/3lXQXGFWeyMYi7FkSVzHYYY3LWMi0/xxIzSZDS04KYwBdPyn4lNJWn/N?=
 =?us-ascii?Q?3zRGl8aVF2D//CnClyLPnug/Ee5VqWmqguVFew8arffBgWwi9CS3wW0+WYDm?=
 =?us-ascii?Q?e8KMPh5WNiSRIoOhAZ6OiuuWsTtbMXDGw50nr82qN2PSvQS3ov5SSeFNQwYo?=
 =?us-ascii?Q?N6Ls9oEjCsek5Ya6a/gC3Y4s4Mc1bojOs3tyPC+EnY/8iXj51RIfJIA9f5pw?=
 =?us-ascii?Q?JNcNvW/ePKvec2Mhh2tb59PmifywypAwZoa5UgFX/8J9OXcFZv8zn3UdWx4U?=
 =?us-ascii?Q?UagZOOErHKQer6pq7UmzXYd70T1Kf+6e/X28HO0MKkDbFX16mEv2b7qQCRAn?=
 =?us-ascii?Q?tSphnXXfZj6kL3j1e8YUPm8rT+dlpA6Md/SlH0CdrCbC56OR2d32iiPZo7Yh?=
 =?us-ascii?Q?J4mjX7yMBflnZ3GS1SVEuXgPrK0EnentDpDOXhk2+Ks2XZVRpmXIUWB2DeWb?=
 =?us-ascii?Q?xDx7ktndeXLq/R8DDFS/7cTn3q32n2y+JfEgU1y1jJ1davjtbUbTMA7wAUqC?=
 =?us-ascii?Q?zTMWBtXCOu93aDvgXpLcmPIcTnX98hNViyQJiws61EcDb+IzVpcQtmcZm4M2?=
 =?us-ascii?Q?4EBunSQsMMpRrQnMN3fhLnvm5y1BE9vvPt9T4Ci0qSDCFufqCdD5NEEAFUxk?=
 =?us-ascii?Q?i0UPNn+gm20KcvGPn9Pbgfbi+nSdCFQiVaJIA9fM?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CY4PR03MB2488.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a4992c05-db9d-4a95-d697-08db34eeb3d5
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2023 09:26:42.6544
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cXOcvD+dVBdiHVD2sBh0o9RSMEPB1y0j4ZL47EFSw8wThfiB/mTygbk00eLeR4ItLMTnq+IpVXcBJ2K5e5W38byS9ftECxK0J6LrhijrUZk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5673
X-Proofpoint-ORIG-GUID: H0i_AjytFGDd1czqE4uf09c1uK-Mc0Lf
X-Proofpoint-GUID: H0i_AjytFGDd1czqE4uf09c1uK-Mc0Lf
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-04_02,2023-04-03_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999
 impostorscore=0 mlxscore=0 malwarescore=0 spamscore=0 phishscore=0
 clxscore=1011 adultscore=0 suspectscore=0 priorityscore=1501
 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2303200000 definitions=main-2304040087
X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On 04/04/2023 08:17:40+0200, Krzysztof Kozlowski wrote:
> > On 03/04/2023 17:43, Ibrahim Tilki wrote:
> > > Devicetree binding documentation for Analog Devices MAX313XX RTCs
> > >=20
> > > Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> > > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> > > ---
> > > .../devicetree/bindings/rtc/adi,max313xx.yaml | 144 +++++++++++++++++=
+
> > > 1 file changed, 144 insertions(+)
> > > create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx=
.yaml
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml =
\
> > > b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml new file mo=
de 100644
> > > index 000000000..0c17a395e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
> > > @@ -0,0 +1,144 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +# Copyright 2022 Analog Devices Inc.
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/rtc/adi,max313xx.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices MAX313XX series I2C RTCs
> > > +
> > > +maintainers:
> > > +  - Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> > > +  - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> > > +
> > > +description: Analog Devices MAX313XX series I2C RTCs.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - adi,max31328
> > > +      - adi,max31329
> > > +      - adi,max31331
> > > +      - adi,max31334
> > > +      - adi,max31341
> > > +      - adi,max31342
> > > +      - adi,max31343
> > > +
> > > +  reg:
> > > +    description: I2C address of the RTC
> > > +    items:
> > > +      - enum: [0x68, 0x69]
> > > +
> > > +  interrupts:
> > > +    description: |
> >=20
> > Do not need '|'.
> >=20
> > > +      Alarm1 interrupt line of the RTC. Some of the RTCs have two in=
terrupt
> > > +      lines and alarm1 interrupt muxing depends on the clockin/clock=
out
> > > +      configuration.
> > > +    maxItems: 1
> > > +
> > > +  "#clock-cells":
> > > +    description: |
> >=20
> > Do not need '|'.
> >=20
> > > +      RTC can be used as a clock source through its clock output pin=
 when
> > > +      supplied.
> > > +    const: 0
> > > +
> > > +  clocks:
> > > +    description: |
> >=20
> > Do not need '|'.
> >=20
> > > +      RTC uses this clock for clock input when supplied. Clock has t=
o provide
> > > +      one of these four frequencies: 1Hz, 50Hz, 60Hz or 32.768kHz.
> > > +    maxItems: 1
> > > +
> > > +  aux-voltage-chargeable:
> > > +    enum: [0, 1, 2]
> > > +    description: |
> > > +      Enables trickle charger.
> > > +      0: Charger is disabled (default)
> > > +      1: Charger is enabled
> > > +      2: Charger is enabled with a diode
> >=20
> > 2 is not an allowed value. I asked to drop this property. It is coming
> > from rtc.yaml. I also do not understand "with a diode". So otherwise it
> > is charging with, I don't know, FET?
>=20
> No, what is not explained here (and maybe not unsterstood by the
> submitter) is that the RTC has an extra diode so, charging will always
> enable a diode, select a resistor and then have or not an extra diode.
> Figure2 of the MAX31329 datasheet is great.
>=20

That is exactly why I had "adi,trickle-diode-enable" property in previous p=
atch.
So if I can't have "adi,trickle-diode-enable" and can't add an additional v=
alue
to "aux-voltage-chargeable", I am not sure how to add support for the extra
diode at this point.

Best regards,
Ibrahim

> >=20
> > > +
> > > +  trickle-resistor-ohms:
> > > +    description: Selected resistor for trickle charger.
> > > +    enum: [3000, 6000, 11000]
> > > +
> > > +required:
> > > +  - compatible
> > > +  - reg
> > > +
> > Best regards,
> > Krzysztof
> >