Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Camelia Alexandra Groza <camelia.groza@nxp.com>
To:     Sean Anderson <sean.anderson@seco.com>,
        Leo Li <leoyang.li@nxp.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
CC:     Scott Wood <oss@buserror.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Roy Pledge <roy.pledge@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        Sean Anderson <sean.anderson@seco.com>
Subject: RE: [PATCH v2 2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock
Thread-Topic: [PATCH v2 2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock
Thread-Index: AQHZY+OE1RJmUmy5N0SD/8fbwuxDUq8a6ZaA
Date:   Tue, 4 Apr 2023 09:36:00 +0000
Message-ID: <VI1PR04MB58070B4CEC732B16F7787F9EF2939@VI1PR04MB5807.eurprd04.prod.outlook.com>
References: <20230331151413.1684105-1-sean.anderson@seco.com>
 <20230331151413.1684105-2-sean.anderson@seco.com>
In-Reply-To: <20230331151413.1684105-2-sean.anderson@seco.com>
Accept-Language: en-GB, ro-RO, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?17p2dJ/RGF7uZb0P9RGFhLo+h1s3/8bvKwvzluH2yFqq1D2yM1BkStHvYynm?=
 =?us-ascii?Q?eyM0JmCSbNrKhzPOVpVJF+PiwLHPMhEHVXOoGNNWIZUZ1QARxFMFFXRd0bfi?=
 =?us-ascii?Q?Nm08AUgIKi7Cp/zV0WLjAybm5G0/riRMiskLvgOzXWt3tCvTdlKezI+Re/Qw?=
 =?us-ascii?Q?UD4XmiXcNmwb5dUyhTWY6xnt7+DT/YLCQJRls55u1eGITV9sJsnSZrOV94sk?=
 =?us-ascii?Q?Ddu15W11YLzWF+x8LlNWX7NpIHX2r+Ban1yklhfsVe6ClhTTwVmQ3td7tD71?=
 =?us-ascii?Q?hX8WL93OM9QQ+vp27rcGxSKhDKgu08pSadg5FTB1275SZ62Xe/91CbmvTgNQ?=
 =?us-ascii?Q?6Vo40ZoHh9pqpQtrfHiM0KH/YUJk7ap/rPphZgRym9RY9Gffs55iRdHZqsBE?=
 =?us-ascii?Q?SJHJrSxvv7ZnWekRqz7UECiB9WoopP/NrWDyuU6voBE0hUZS3d+Ocs9L0CfQ?=
 =?us-ascii?Q?hfjtIfZNW1oH4uWY69jYiV5R3E09LZfVoP7T4ACgNvb8K0NSocaps/rqAg6n?=
 =?us-ascii?Q?WwDyN7pWvdjPFRK0MeSQ1b2baojFjlvizulKJNmz+BKCWdaJorqwOGA2RtCh?=
 =?us-ascii?Q?AWpO+az8WlIn7K/S7cdBgCLyv+0aDcCpwQGWmFi7C7ZV7WKJSa8RjXC2mT3f?=
 =?us-ascii?Q?Yl2VX7hjhaGgU9+mJgrIG49J4sWVzfF714vABzG3pEFQppOZWZWw/nsbuCUN?=
 =?us-ascii?Q?MJhw7yYYj8cWwhuCdzUgSzELU+fNMN+OeG9qZCXvCxydrVHvT84xjuBEU1IH?=
 =?us-ascii?Q?rAT+//HyJt+mChzlv3nHFi+2yeeeZ7Qjx1VB+xEiVUuEUtiaraAKHujn3qgm?=
 =?us-ascii?Q?1+m0SxDW/b5rCh3IZgiUIM/M22GLfaMkIOYTbJYSvu6RvrjS3nMHwdeWDSdL?=
 =?us-ascii?Q?111uEbNLaWaJqDRxIZdhk1OrZRFyHMwycR9O9S+tLH32r846OJ5HpEPeUd6z?=
 =?us-ascii?Q?4xRemXdypi1ioWdG/KwzZzVZY6zFoAfP6KnyMTtLqPzti9xeIYz5tOi8Nbwx?=
 =?us-ascii?Q?EfMKepf6WVZFA1iMXjpu0b359CFG0I0e/JGzEndxzmOfOEmQaKcunlkk/xIN?=
 =?us-ascii?Q?ku7nWS6xT02VggtBeUMrr31I9gXbIWElK9Cmrf+2/1WReCuTf8rhRUsHNjJB?=
 =?us-ascii?Q?skco4ASQys4pJRNG6qFVJb1QrXez2uvjeHHBPiKZo/tIVR3fiWJhMHLeUtnS?=
 =?us-ascii?Q?8LMgOWVgoShBRezbdRg1vRwCw67YxM/Vx1vSWcjV8fyHvH67ONLbOqm2WKYQ?=
 =?us-ascii?Q?8LEXvPIAu6FYqsbfpXhNWCoTsBJxOYL9+2IXozU1TmukPjZAJKwtFIkddKDx?=
 =?us-ascii?Q?sFre7AzwTtJJA4VdzEF/QGwugcS23MfoeG2cZzx2TRqnLpSF6p3+BD7JE7P6?=
 =?us-ascii?Q?nH3NpIH4U5JY0ATUDvPNzdAQ9joPbnhMaQE9NVsPa8Tpk8fl8OtmPnGGOMs2?=
 =?us-ascii?Q?epu5dLFNm2RJKiQzoTrJ0MH9y6FruRlNzdKYRTVsZZi8Uder9YKXlfGxnw3k?=
 =?us-ascii?Q?cL9tcrDpDOESUMGi5l9zeXcV8Ik1yKkdaaiTqr65Qcn+fcXgTqvsw+hjY70f?=
 =?us-ascii?Q?TDNrnAONfKl65CIKr4R0Y2nPv+wBTuUyhILZ4gyK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5807.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7dcbab4e-95cd-4ff3-52ab-08db34f00092
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2023 09:36:00.8990
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZQb0kIazjDo2V4eAyrgkt6Cu4R5CgqphsTCEOmVW0RFqbM42zpRBlW6skRumVSDiIWu6i+PaY5vRJqJcP6CZXg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8932
X-Spam-Status: No, score=1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        RCVD_IN_VALIDITY_RPBL,SPF_HELO_PASS,SPF_PASS autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Sean Anderson <sean.anderson@seco.com>
> Sent: Friday, March 31, 2023 18:14
> To: Leo Li <leoyang.li@nxp.com>; linuxppc-dev@lists.ozlabs.org; linux-arm=
-
> kernel@lists.infradead.org
> Cc: Scott Wood <oss@buserror.net>; Camelia Alexandra Groza
> <camelia.groza@nxp.com>; linux-kernel@vger.kernel.org; Roy Pledge
> <roy.pledge@nxp.com>; David S . Miller <davem@davemloft.net>; Claudiu
> Manoil <claudiu.manoil@nxp.com>; Vladimir Oltean
> <vladimir.oltean@nxp.com>; Sean Anderson <sean.anderson@seco.com>
> Subject: [PATCH v2 2/2] soc: fsl: qbman: Use raw spinlock for cgr_lock
>=20
> cgr_lock may be locked with interrupts already disabled by
> smp_call_function_single. As such, we must use a raw spinlock to avoid
> problems on PREEMPT_RT kernels. Although this bug has existed for a
> while, it was not apparent until commit ef2a8d5478b9 ("net: dpaa: Adjust
> queue depth on rate change") which invokes smp_call_function_single via
> qman_update_cgr_safe every time a link goes up or down.
>=20
> Fixes: c535e923bb97 ("soc/fsl: Introduce DPAA 1.x QMan device driver")
> Reported-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Link: https://lore.kernel.org/all/20230323153935.nofnjucqjqnz34ej@skbuf/
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>

Reviewed-by: Camelia Groza <camelia.groza@nxp.com>