Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5729354rwl; Tue, 4 Apr 2023 02:47:18 -0700 (PDT) X-Google-Smtp-Source: AKy350YllKfP+8dKVDufwW6HIfxnhyeJGDd/411mQd91DiW+a64Uyd0A9weS3x+K1hBCIy3xMAzZ X-Received: by 2002:a05:6402:31e1:b0:4fb:5291:13bb with SMTP id dy1-20020a05640231e100b004fb529113bbmr1822376edb.39.1680601637851; Tue, 04 Apr 2023 02:47:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680601637; cv=none; d=google.com; s=arc-20160816; b=HumywOee+YSvwqaVmH6EtxqBend+5/AERYQCPQJNlxT/caOceeqZKc/LdXbHGj+eoI 9P92QSplODUwGKSwJTvTjvinPxkYY7zRS7H1O72k+qOcfOgJixX1FwRPxMkNS6J/qt0U pIqYfoM9nt8IWq3sJYL/AR4+t9YVvUsJFXk79GsAE4XhElemsd72LBmzUWGSXiaekCCe MsG2FbpCK1qygF7iVyJ1o/b7mkIiEK76WZOe4GTQ+bAO9h1CETMepVpQZIsIzyLBoP59 SYqmaKO8yVGbRo8euEHsYDBUV3fpofULmqoerYEpTv1hJnINYJH+5EDg076U/Z3w7q9X T3SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=21r9BUiD6bnTfWKdCcjkNvI5dZCiJhV9YiPQO/nQrwk=; b=dkd272xowrsvgfLduYQg6bctXg0uAeuhnSSUinbDGWDHbEj89XmZn90dHSxq5tTh6u qA6YYE2bU9WArfj+Ir/6kfluqwLwfabxUgOFUCDhAgShpjetzBed0XVZDN0vIVXLvhGT AXY8gDtOEG6SzMygaiM0lu4zibpbGYqOGGg81HayQeHTsi43HyTwk+BizEb5kkdqaj5q UG3lrTVZL3uaUZ0kKBtXhBHU9/dT2MeSDOt9s2qj8pw/1YNA+3pFMLZ7fbzn5+NqQuxG 3l5eOoPvcmNHK9Zu0l2imu3VWAUB6sq0TqVOrKsDB6emVCVP/PrJ3gpQVv/bDWM/83Go 3QAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d24-20020a1709067f1800b0093348ceb372si6088759ejr.742.2023.04.04.02.46.52; Tue, 04 Apr 2023 02:47:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234129AbjDDJqP (ORCPT + 99 others); Tue, 4 Apr 2023 05:46:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234009AbjDDJqM (ORCPT ); Tue, 4 Apr 2023 05:46:12 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC83E30DC for ; Tue, 4 Apr 2023 02:45:50 -0700 (PDT) Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PrNCk3pgCzKntV; Tue, 4 Apr 2023 17:45:06 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 4 Apr 2023 17:45:41 +0800 From: Peng Zhang To: , , CC: , , ZhangPeng Subject: [PATCH] mm/madvise: Use vma_lookup() instead of find_vma() Date: Tue, 4 Apr 2023 17:45:15 +0800 Message-ID: <20230404094515.1883552-1-zhangpeng362@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ZhangPeng Using vma_lookup() verifies the address is contained in the found vma. This results in easier to read the code. Signed-off-by: ZhangPeng --- mm/madvise.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 340125d08c03..405a2c4a0a18 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -852,21 +852,9 @@ static long madvise_dontneed_free(struct vm_area_struct *vma, *prev = NULL; /* mmap_lock has been dropped, prev is stale */ mmap_read_lock(mm); - vma = find_vma(mm, start); + vma = vma_lookup(mm, start); if (!vma) return -ENOMEM; - if (start < vma->vm_start) { - /* - * This "vma" under revalidation is the one - * with the lowest vma->vm_start where start - * is also < vma->vm_end. If start < - * vma->vm_start it means an hole materialized - * in the user address space within the - * virtual range passed to MADV_DONTNEED - * or MADV_FREE. - */ - return -ENOMEM; - } /* * Potential end adjustment for hugetlb vma is OK as * the check below keeps end within vma. -- 2.25.1