Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5843472rwl; Tue, 4 Apr 2023 04:39:00 -0700 (PDT) X-Google-Smtp-Source: AKy350akTxYTjPSI+jzWBRw4xh3QEbbagNL7EWcVUeFPLJybRbJb5ibC0hrzjs0ZQDFkc76hd53e X-Received: by 2002:a17:906:2414:b0:933:3cc7:4420 with SMTP id z20-20020a170906241400b009333cc74420mr2115825eja.45.1680608340416; Tue, 04 Apr 2023 04:39:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680608340; cv=none; d=google.com; s=arc-20160816; b=nuffN5XuSLgfJfzaOWcWkzz1mkj8eGUWg1Eto11wofCyM531ZR1VaY25BMDACspV6i udpPjaFDZXoAhjzE/AB+y6vZxCXY51qne9KOU8XtuKaPHKrV7pJW9GIcRX4Z5NKOOJP2 66S8QKsqm06VdEEZqag+ihBo5MuWyWOZkSq4dirVHf+eW50wPwpcCGghEYaQIjNP65Vi BEwRY5vKyZxaGQh/kgG5GOxlErYnYn9QBWor+O1CesASL9B+6Q6Ti6j6+fvfFtQxOPV2 Cgw+IA/1T4VFmGs/g+MpmzmVvT8fvkMPdkTOdC1YYUJkSlS9Ve5s8yDeeunYSGCz2OFO ovHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=HeHiVDdz8sBMynCxwE0TFoIUEZz4pyQlBQnXpa7KS6s=; b=AMkKwvg6hdQMswxpBb8va+jRnreiP5Z3bk9QboVfDM8NufkxvWrz2i3NjjWLV0eLnk aBMFwWc1gmz+oIWV/ZcvXhKmr3MMmkmIWsAmIZhClMHxYkho+9+3p1PAMKt2cObRfzNw xE/t7IUVnN09BEiJ7FZPev58grCtWGOkNZJDxjbxTIlrqwcbSWqY0WXHSVeHML4uKUa6 TV5E4pE/FEjqjxltYgakLWnb9HUSFcR94k1pnc5dLohuff68UEfplt+WiHg+1LiBdj2j vs31KrLKO4hi0t6jEUc7guBY5GVmET/+d148Xm9SejVGb+KutWzNU3O/4VGsaMi0Tzkv 0h7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hx21-20020a170906847500b009318617354bsi5899929ejc.648.2023.04.04.04.38.29; Tue, 04 Apr 2023 04:39:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234754AbjDDL2m (ORCPT + 99 others); Tue, 4 Apr 2023 07:28:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58266 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234295AbjDDL2l (ORCPT ); Tue, 4 Apr 2023 07:28:41 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEF1C1FD3 for ; Tue, 4 Apr 2023 04:28:40 -0700 (PDT) Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjepm-00043P-Ln; Tue, 04 Apr 2023 13:28:18 +0200 Received: from pengutronix.de (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 42D791A6300; Tue, 4 Apr 2023 11:28:13 +0000 (UTC) Date: Tue, 4 Apr 2023 13:28:12 +0200 From: Marc Kleine-Budde To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Vincent Mailhol , Rob Herring , Amarula patchwork , michael@amarulasolutions.com, Alexandre Torgue , Krzysztof Kozlowski , Christophe Roullier , "David S. Miller" , Dmitry Torokhov , Eric Dumazet , Jakub Kicinski , Krzysztof Kozlowski , Mark Brown , Maxime Coquelin , Paolo Abeni , Rob Herring , Viresh Kumar , Wolfgang Grandegger , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org Subject: Re: [PATCH v10 0/5] can: bxcan: add support for ST bxCAN controller Message-ID: <20230404-postage-handprint-efdb77646082@pengutronix.de> References: <20230328073328.3949796-1-dario.binacchi@amarulasolutions.com> <20230328084710.jnrwvydewx3atxti@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vrolgxtwhc7crda5" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:b01:1d::7b X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vrolgxtwhc7crda5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 28.03.2023 11:28:59, Dario Binacchi wrote: > > Applied to linux-can-next. >=20 > Just one last question: To test this series, as described in the cover > letter, I could not use the iproute2 package since the microcontroller > is without MMU. I then extended busybox for the ip link command. I > actually also added the rtnl-link-can.c application to the libmnl > library. So now I find myself with two applications that have been > useful to me for this type of use case. >=20 > Did I do useless work because I could use other tools? systemd-networkd also supports CAN configuration, but I this will probably not work on no-MMU systemd, too. Then there is: | https://git.pengutronix.de/cgit/tools/canutils | https://git.pengutronix.de/cgit/tools/libsocketcan that contains canconfig, but it lacks CAN-FD support. > If instead the tools for this use case are missing, what do you think > is better to do? Submit to their respective repos or add this > functionality to another project that I haven't considered ? Yes, go ahead and upstream your changes! Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung N=C3=BCrnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | --vrolgxtwhc7crda5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEDs2BvajyNKlf9TJQvlAcSiqKBOgFAmQsCckACgkQvlAcSiqK BOiwvQf/bknW5120duEvKB4vzq6g1FE4pHri1PUIfK32NY2ZntW/rs/zYYH5KMTC A3DRsT4CsHVSXNDvW7JNgHJIxIZ8kFQGiAIfOv/a7OOYXZocvfBMW9yxgRqDlese N9BqaRggCBDhP829laPpXYntgW6k8lTMpWI7C6ANyis9tbKJ68Ut0d7bZ4eiYGme +R4neMSudT1l+tzSobkBpDrXloivl9uXhme25xmFTtQeokwCaXSZ7CFDpNcTV2zw 3wq4YYs3fnoxUbIauVk4mDGyoJTB0ZzDee5Kp8+ucH1+eukInkeHk37RerOpc4Wv Gl61KK/5ijUZNnIHiOJIS9C8Sv6kSQ== =L7qt -----END PGP SIGNATURE----- --vrolgxtwhc7crda5--