Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5894513rwl; Tue, 4 Apr 2023 05:21:18 -0700 (PDT) X-Google-Smtp-Source: AKy350YYA1Ha7tGP41wAtG3e4H/YMLfVrGDw4Wg7j0kWdth6GGbjtqZTinUEBF31362yrdEDB6Z7 X-Received: by 2002:a17:903:228c:b0:1a2:56f4:d369 with SMTP id b12-20020a170903228c00b001a256f4d369mr3035629plh.19.1680610878700; Tue, 04 Apr 2023 05:21:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680610878; cv=none; d=google.com; s=arc-20160816; b=oKmPL1xZp6TQSZTfqkAhVQWdf12zzDBhxUaB9vxI1wYpGXyFh9Je00NbOj1uFyL9w8 mqLWj4/SPKyjOWOpLylAzjF9zWeAGvFvJc3+B0QyMEK3kuj2CB0vicibKaEDi7kSeIj0 1n80ZKPGPDc/eJlzlAJX6WSfu+q2Fr60r665jrCs/wvXA3TQ2U0qizg0HJ9W5KI7lCRH O7UpnBN6RCugYEwM0Jrg6NexeqwluPquHKErga6IxK6YvGGrC+ZzMM/XTfe6ss3PRD1e pG7hzNWz6g9Tfd2d65z10askDDImT+6tTU87MpOvLRwvLYfXKETSBhCk5+xHy15hsi2x NIWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xcckzg95zpKeurnjtan7E8VP+EYwCJoi2cRFH+SxLY4=; b=0YkqQy4mMY0jSxRifT646HoEDXqbHl/mFg2A4ubGkQTV+zfHilw3zsd8sS+shbBxdE r0tWbouRF7LR5JED2Lp6wJf+jULFbDLHGcD5xv5+YiONXtRk5ueiXrQWDopbnzQO7HwI JJbF72vR+OELt/7QuQbk0mI3b/vzSl+aRG88dubE2CH7jOhnSsZHoMG0ojIu8ZVyWknR wpcTV3d7Bq5ZpaC8DFAoyR60TJrbb03BAXlSyXsk6F0XGprnVOA5u6beGIBRt08H/atg /iAU1PCce4bFHEuj3AGxH0lE/qb9RxQ4err1YQ9J6pb80xL3p3+eoi+NxFYM44IY4k3x xjnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MaAjRRFu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e3-20020a170902744300b0019cb419df45si9899708plt.401.2023.04.04.05.21.06; Tue, 04 Apr 2023 05:21:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=MaAjRRFu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234964AbjDDMT6 (ORCPT + 99 others); Tue, 4 Apr 2023 08:19:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234750AbjDDMTZ (ORCPT ); Tue, 4 Apr 2023 08:19:25 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E1FD3C3E; Tue, 4 Apr 2023 05:14:55 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id eg48so129605038edb.13; Tue, 04 Apr 2023 05:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680610494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xcckzg95zpKeurnjtan7E8VP+EYwCJoi2cRFH+SxLY4=; b=MaAjRRFugUvjadZGGJRXWMxFGP3C+fpBJg9N4EY47OixBVN6M7Ff/CxGNwnhPZSMjg Rmu9tS6icUukt3KVYABNtD6RK58Y5tsb55mTyDDku7bDiccsYlKFIAeDDbqIVJdBUhHD ykqEsCTrmretXQnYjLSuH+fo9x+eSVbvUOkOvpxaHR6FFqA5mO0010AD3ux8OchBB59Z CP7vGg4mWcMjzfUXxh8lqF5cVH+eA2dn72TNMl+roMKrvOUczkRcOoyJIIxqzk6KOp7N 9a4M+DQWdzHiCtovTGKs8BrxzqSA85IY5QOKlS+a40YRr69imrL2KZhLSKnAbfBQbk6l Snpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680610494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xcckzg95zpKeurnjtan7E8VP+EYwCJoi2cRFH+SxLY4=; b=adyJ+/j6GAuycsVjGXx1ZSQU3sGtvN6GWNINjFEDw4TFy61uTmom/uxEeDfPopFQKi JR6XUBw3aB9XuPPuvbD39g9/3Qm3R1fXNlCZyGBoWx3D5wIWg7lwJ2BtakFOS+YXvEmE Cka0RiZwoI/dLAFabHJ+G77UohaivyeDhoI3XtmYRMgiWXP5GHy+7lSq127oszslnxc9 r5CpGc26Lxxp5Td9t6Pu44/go1s5yvu8eRgFQqGQK9mNPvCY7EtnrpbyhR/pgNyoX3bc geqwuEkwqiYotcR1SXPAt2N/eAjbiZgNQT9LPe0SKLVIj/NBaO+1vN+/omSLQXsH/4Ab GFRg== X-Gm-Message-State: AAQBX9dLFcN+PJaTFd41KnSOf9zcimVZF1FD9bgyjH027mnEgVbWzvKc J/N8Y5Z1okzaaav41uzqPCY= X-Received: by 2002:aa7:d598:0:b0:501:cde5:4cc9 with SMTP id r24-20020aa7d598000000b00501cde54cc9mr2212071edq.39.1680610493757; Tue, 04 Apr 2023 05:14:53 -0700 (PDT) Received: from localhost (p200300e41f1c0800f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f1c:800:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id v23-20020a056402175700b004c5d1a15bd5sm5724789edx.69.2023.04.04.05.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 05:14:53 -0700 (PDT) From: Thierry Reding To: Cai Huoqing Cc: Daniel Vetter , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/tegra: sor: Make use of the helper function dev_err_probe() Date: Tue, 4 Apr 2023 14:14:44 +0200 Message-Id: <168061024450.2054665.8080259648129396992.b4-ty@nvidia.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20210917020741.17525-1-caihuoqing@baidu.com> References: <20210917020741.17525-1-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thierry Reding On Fri, 17 Sep 2021 10:07:41 +0800, Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > And using dev_err_probe() can reduce code size, the error value > gets printed. > > > [...] Applied, thanks! [1/1] drm/tegra: sor: Make use of the helper function dev_err_probe() commit: a4c56f2f8ce0e242eb51e5309a743361e2348a64 Best regards, -- Thierry Reding