Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Apr 2023 14:36:39 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Haotien Hsu <haotienh@nvidia.com>
Cc:     Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, JC Kuo <jckuo@nvidia.com>,
        Wayne Chang <waynec@nvidia.com>
Subject: Re: [PATCH v5] usb: xhci: tegra: fix sleep in atomic call
Message-ID: <ZCwZ169Ix7R4aPbx@orome>
References: <20230327095548.1599470-1-haotienh@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="qnhHWXaap8DkTg8Q"
Content-Disposition: inline
In-Reply-To: <20230327095548.1599470-1-haotienh@nvidia.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--qnhHWXaap8DkTg8Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 27, 2023 at 05:55:48PM +0800, Haotien Hsu wrote:
> From: Wayne Chang <waynec@nvidia.com>
>=20
> When we set the dual-role port to Host mode, we observed the following
> splat:
> [  167.057718] BUG: sleeping function called from invalid context at
> include/linux/sched/mm.h:229
> [  167.057872] Workqueue: events tegra_xusb_usb_phy_work
> [  167.057954] Call trace:
> [  167.057962]  dump_backtrace+0x0/0x210
> [  167.057996]  show_stack+0x30/0x50
> [  167.058020]  dump_stack_lvl+0x64/0x84
> [  167.058065]  dump_stack+0x14/0x34
> [  167.058100]  __might_resched+0x144/0x180
> [  167.058140]  __might_sleep+0x64/0xd0
> [  167.058171]  slab_pre_alloc_hook.constprop.0+0xa8/0x110
> [  167.058202]  __kmalloc_track_caller+0x74/0x2b0
> [  167.058233]  kvasprintf+0xa4/0x190
> [  167.058261]  kasprintf+0x58/0x90
> [  167.058285]  tegra_xusb_find_port_node.isra.0+0x58/0xd0
> [  167.058334]  tegra_xusb_find_port+0x38/0xa0
> [  167.058380]  tegra_xusb_padctl_get_usb3_companion+0x38/0xd0
> [  167.058430]  tegra_xhci_id_notify+0x8c/0x1e0
> [  167.058473]  notifier_call_chain+0x88/0x100
> [  167.058506]  atomic_notifier_call_chain+0x44/0x70
> [  167.058537]  tegra_xusb_usb_phy_work+0x60/0xd0
> [  167.058581]  process_one_work+0x1dc/0x4c0
> [  167.058618]  worker_thread+0x54/0x410
> [  167.058650]  kthread+0x188/0x1b0
> [  167.058672]  ret_from_fork+0x10/0x20
>=20
> The function tegra_xusb_padctl_get_usb3_companion eventually calls
> tegra_xusb_find_port and this in turn calls kasprintf which might sleep
> and so cannot be called from an atomic context.
>=20
> Fix this by moving the call to tegra_xusb_padctl_get_usb3_companion to
> the tegra_xhci_id_work function where it is really needed.
>=20
> Fixes: f836e7843036 ("usb: xhci-tegra: Add OTG support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Wayne Chang <waynec@nvidia.com>
> Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> ---
> V4 -> V5: Update commit message and code layout with 100 columns
> V3 -> V4: Remove copyright change from this patch
> V2 -> V3: Add version information
> V1 -> V2: Add "Fixes" and "Cc:" lines and update copyright years
> ---
>  drivers/usb/host/xhci-tegra.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>

--qnhHWXaap8DkTg8Q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQsGdUACgkQ3SOs138+
s6Gu2RAAmzYhi+6Q+40Z2gSV1KR50Yz0lE7E1BcmUNQNLFcDrfZYvKgXErcaBXIb
lLOz4ZmWwVCy5t7CsqVwn8zJ8XZvUXQPjp4+j1iUdJOf4yHAU2ZTaL86bugiBTm1
/T/Ing42b1bjMsGH3ndJHhzHp29zV9BFYKZy/syVikZqwyUlRHv/cn72OZ5jXnPz
3M9RNERfc/Telp0dte3FgZKus/4TxzOx0kkw2IqpePajvf2kWYcUnDul1AIgN60A
5tZbp40usNGqM//xZ/IdAlnMMBwcaZf4UqihqoNOxj8EuC9b/jFwO0f0pUHNy6ST
tI6X2aiSq0OSfLlkim0ChcLY+G0IcHZ0cEbXuVVQHFkub9P7C7IsTp5SPmI1M3ui
5kVMZXlthTvaAP/ccj28euHhPlgE34V3paEv/z5eqLatByTfprVrrFfQ7qe3jSCF
N23ZKSos+kDFVImVZFYzbknyExXQA5Zs87O/cHZNLjLho59X41C9pTLtT2J4enF/
leQu8wPU3UdCDTGwfWQji27to1ya5ZFvL1u3+Ilk8PGQZbkY9dkbjvFn3c2XWpYQ
fR14w1p+ls7+YJEbNcyN+LvjGKWQAZzujhdoHU+VoBIMnQ8iCXWFGm6QdrCiqOab
vwoKdJOMYzlvhOrVsqfYeAw4wjCjoYO8XrbdgHgy95v6kn10rpk=
=sHhN
-----END PGP SIGNATURE-----

--qnhHWXaap8DkTg8Q--