Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753522AbXIXKYq (ORCPT ); Mon, 24 Sep 2007 06:24:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754434AbXIXKY3 (ORCPT ); Mon, 24 Sep 2007 06:24:29 -0400 Received: from viefep18-int.chello.at ([213.46.255.22]:12560 "EHLO viefep18-int.chello.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618AbXIXKY1 (ORCPT ); Mon, 24 Sep 2007 06:24:27 -0400 Date: Mon, 24 Sep 2007 12:24:22 +0200 From: Peter Zijlstra To: Mike Galbraith Cc: Tong Li , Ingo Molnar , dimm , linux-kernel@vger.kernel.org, Srivatsa Vaddagiri Subject: Re: [git] CFS-devel, group scheduler, fixes Message-ID: <20070924122422.75562c41@twins> In-Reply-To: <1190628609.6389.14.camel@Homer.simpson.net> References: <1190144190.5204.24.camel@earth> <20070918201622.GA1632@elte.hu> <1190183324.9737.7.camel@Homer.simpson.net> <1190188261.9185.21.camel@Homer.simpson.net> <1190191368.8687.5.camel@Homer.simpson.net> <1190264114.6411.4.camel@Homer.simpson.net> <1190272507.27867.20.camel@Homer.simpson.net> <20070920075155.GA31641@elte.hu> <1190275870.9232.6.camel@Homer.simpson.net> <1190455308.7404.19.camel@Homer.simpson.net> <1190531662.11524.15.camel@Homer.simpson.net> <1190628609.6389.14.camel@Homer.simpson.net> X-Mailer: Claws Mail 3.0.0 (GTK+ 2.10.11; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 814 Lines: 25 On Mon, 24 Sep 2007 12:10:09 +0200 Mike Galbraith wrote: > @@ -117,7 +117,7 @@ static inline struct task_struct *task_o > static inline u64 > max_vruntime(u64 min_vruntime, u64 vruntime) > { > - if ((vruntime > min_vruntime) || > + if (((s64)vruntime > (s64)min_vruntime) || > (min_vruntime > (1ULL << 61) && vruntime < (1ULL << 50))) > min_vruntime = vruntime; > how about something like: s64 delta = (s64)(vruntime - min_vruntime); if (delta > 0) min_vruntime += delta; That would rid us of most of the funny conditionals there. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/