Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <676dfbfb-f1ee-b02f-0383-9a84a91634af@quicinc.com>
Date:   Tue, 4 Apr 2023 18:21:20 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.8.0
Subject: Re: [PATCH] remoteproc: pru: remove always true check positive
 unsigned value
Content-Language: en-US
To:     Simon Horman <horms@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>
CC:     Dan Carpenter <error27@gmail.com>,
        <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
References: <20230404-pru-always-true-v1-1-b1b55eeff188@kernel.org>
From:   Mukesh Ojha <quic_mojha@quicinc.com>
In-Reply-To: <20230404-pru-always-true-v1-1-b1b55eeff188@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/4/2023 6:14 PM, Simon Horman wrote:
> In both cases they type of da is u32. And PRU_PDRAM_DA is 0.
> So the check da >= PRU_PDRAM_DA is always true and can be removed.
> 
> Flagged by Smatch:
> 
>   drivers/remoteproc/pru_rproc.c:660 pru_d_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'
>   drivers/remoteproc/pru_rproc.c:709 pru_i_da_to_va() warn: always true condition '(da >= 0) => (0-u32max >= 0)'
> 
> No functional changes intended.
> Compile tested only.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://www.spinics.net/lists/kernel/msg4025983.html
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
>   drivers/remoteproc/pru_rproc.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index b76db7fa693d..095f66130f48 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -657,7 +657,7 @@ static void *pru_d_da_to_va(struct pru_rproc *pru, u32 da, size_t len)
>   		swap(dram0, dram1);
>   	shrd_ram = pruss->mem_regions[PRUSS_MEM_SHRD_RAM2];
>   
> -	if (da >= PRU_PDRAM_DA && da + len <= PRU_PDRAM_DA + dram0.size) {
> +	if (da + len <= PRU_PDRAM_DA + dram0.size) {
>   		offset = da - PRU_PDRAM_DA;
>   		va = (__force void *)(dram0.va + offset);
>   	} else if (da >= PRU_SDRAM_DA &&
> @@ -706,8 +706,7 @@ static void *pru_i_da_to_va(struct pru_rproc *pru, u32 da, size_t len)
>   	 */
>   	da &= 0xfffff;
>   
> -	if (da >= PRU_IRAM_DA &&
> -	    da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
> +	if (da + len <= PRU_IRAM_DA + pru->mem_regions[PRU_IOMEM_IRAM].size) {
>   		offset = da - PRU_IRAM_DA;
>   		va = (__force void *)(pru->mem_regions[PRU_IOMEM_IRAM].va +

LGTM.
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>


--Mukesh
>   				      offset);
>