Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Apr 2023 15:30:02 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     Rob Herring <robh@kernel.org>,
        Cristian Marussi <cristian.marussi@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] firmware: Use of_property_present() for testing DT
 property presence
Message-ID: <ZCwmWoZhMOlHnnzf@orome>
References: <20230310144704.1542045-1-robh@kernel.org>
 <20230323120030.7mk62xk7tco32zw2@bogus>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="iUHciihrTalbzd5s"
Content-Disposition: inline
In-Reply-To: <20230323120030.7mk62xk7tco32zw2@bogus>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--iUHciihrTalbzd5s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 23, 2023 at 12:00:30PM +0000, Sudeep Holla wrote:
> On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote:
> > It is preferred to use typed property access functions (i.e.
> > of_property_read_<type> functions) rather than low-level
> > of_get_property/of_find_property functions for reading properties. As
> > part of this, convert of_get_property/of_find_property calls to the
> > recently added of_property_present() helper when we just want to test
> > for presence of a property and nothing more.
> >=20
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  drivers/firmware/arm_scmi/optee.c | 2 +-
>=20
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>(for the SCMI part)
>=20
> I am assuming you will route this as it has other changes as well in the
> patch.

I can also pick this up along with the Tegra changes if Rob doesn't
want to take it. But also feel free to take this through whatever tree
works best, for the Tegra parts:

Acked-by: Thierry Reding <treding@nvidia.com>

--iUHciihrTalbzd5s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQsJlcACgkQ3SOs138+
s6HDEhAAiyZv2IDatqnjFzcpro55n2pEFFzSq+wC+Rmf0uZ2n7/irrlJRwrx0+II
v1b6UP0dd7STZ+6vpKZ44WCXgrv58iushgVhqAD4W/tr8Q0uwUYc4vWzvv5UbN8S
vD2uizF0UuHLbKb9r/SttWElOD9U/iyZrP7IHlngTdznWyb1g5xV9hg0Eu351+qb
7DDNvlErcR3XmYeUcUTCd/SPjjJw2ZWxrJ01StWJand9145/UXyazJxVZ6j+i8I+
OUjx81H8ctLG3TAwfv4zWnR5ZlGndViv/hjVSQasEMe5b84ScQNBnDZB+xmtZAMp
Qn87+8fQcJgTP+UDR/YjjaHRegNGMu9fNqHS14+J2KFvn8nYS0xRPj3aDM8V7CS6
YDflkqK9r2je2dON9/UOKINRgqERHYIY1u9DTlaym97wUtE9a5uOelcsrAR3FScU
SG35J16O95HSXGzoxhwpqbMS0N/Tm5IQruT2ih2D3WNTZQqsjk+7KFSJ8JWabXY1
UYig/IrGLf8dnLoD1KtzxQAwdDslHmvdofvWBY9IBI+GodYQzCZVtyDTKilHi9i3
dW0/eO5knVsW6yWRrgtUEK0X3gIIvSeGr4NF02uuNSmyY94U+Um8e/LXZvc3lckI
+7VHpuvCR7jO4ORq18T2Yoq35yRvqrikIEonW3Oz5NHkAiXo+Iw=
=Qivr
-----END PGP SIGNATURE-----

--iUHciihrTalbzd5s--