Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e2da64d2-2551-07d8-8905-9a374fdb0591@efficios.com>
Date:   Tue, 4 Apr 2023 09:24:54 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [RFC PATCH] sched: Fix performance regression introduced by
 mm_cid
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Aaron Lu <aaron.lu@intel.com>
References: <20230403181342.210896-1-mathieu.desnoyers@efficios.com>
 <20230404090507.GB284733@hirez.programming.kicks-ass.net>
From:   Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
In-Reply-To: <20230404090507.GB284733@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023-04-04 05:05, Peter Zijlstra wrote:
> On Mon, Apr 03, 2023 at 02:13:42PM -0400, Mathieu Desnoyers wrote:
>>   void sched_mm_cid_exit_signals(struct task_struct *t)
>>   {
>>   	struct mm_struct *mm = t->mm;
>> -	unsigned long flags;
>> +	struct rq_flags rf;
>> +	struct rq *rq;
>>   
>>   	if (!mm)
>>   		return;
>> -	local_irq_save(flags);
>> +
>> +	preempt_disable();
>> +	rq = this_rq();
>> +	rq_lock_irqsave(rq, &rf);
>>   	mm_cid_put(mm, t->mm_cid);
>> -	t->mm_cid = -1;
>> +	t->last_mm_cid = t->mm_cid = -1;
>>   	t->mm_cid_active = 0;
>> -	local_irq_restore(flags);
>> +	rq_unlock_irqrestore(rq, &rf);
>> +	preempt_enable();
>>   }
> 
> FWIW a *slightly* cheaper form is:
> 
> 	preempt_disable();
> 	rq = this_rq();
> 	rq_lock_irqsave(rq, &rf);
> 	preempt_enable_noresched(); /* holding spinlock */
> 	...
> 	rq_unlock_irqrestore(rq, &rf);

Good point, updated for next round.

Thanks,

Mathieu


-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com