Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6020324rwl; Tue, 4 Apr 2023 06:55:33 -0700 (PDT) X-Google-Smtp-Source: AKy350Zvz5t1nGooFxCCb+sSaUZRJalH5Ox/IbRFhA4hmYwKstncUdZUTn7qjMwZCOaC8kS1xF5A X-Received: by 2002:a05:6402:151a:b0:4ac:b6b2:1233 with SMTP id f26-20020a056402151a00b004acb6b21233mr2292532edw.30.1680616533706; Tue, 04 Apr 2023 06:55:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680616533; cv=none; d=google.com; s=arc-20160816; b=LGOpJ2uzdc84m5fzHO2n6gTZbEZSDLsdGk9McJSisRHdzttTsj/TIYxtK9xrZAain/ QMnV7dO3HUbV5u926NirAZb9hIylI9yS8Ds+LvZKbwPPY0u99OImkQB0U1gGqj0RqUaj CldSFMZ+XS/IyoN7vzthIRtPVdJ6PGsHaOib1hC3P1/5eIw6yPMBFNNTrX9rS03FTe48 +Bvu+4aLbWIdZeTP1WDK64zvGUT5IaR5Qc1tP6TwBGuGolPT4D8GQksR8PeoPRgJP9/b AkvCEIWlysMKaG2JQ3mqggLk/wOXhXc2dq6a1rekjrEu5L+wRu0RqsNwU/AIOozAjLii SaIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=2t022cV29B7Zbre5ZWJdAks4cSokwANFRg/jjQH6iKk=; b=iRJgrRq5GHdj2uw/D48PW698p+/YkSyOa0ZkvOlxuKH+ApNtSEhkF+d9ukGLLsA4Mq HZt5iAwwUG7Nbz6wSoetVTLxXqc2m3cOurKnPmujq0HgfS4mn8wqDJrb+agCv2YUmHB6 mGBmpY6B0o5M49NoS8hhdVxO62HOSPWW0koxF10PktH6M4AdKXsb8zv1gfhoSS7+4K5a k8hTK+LhYOpF/5ZCu2NCyqh7ukXd0IFBFH3MHhaWA0dRAjAiMC7lJ0GisfCaDoSS9ieS oMwoHWbN+SEpBSASlvLqS+YGbt2eBUJWfBDjVKoMYJZdmOEE71slVmxKiXvExkahiRUK i/lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SDmoxT4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d25-20020aa7c1d9000000b00501d4f9e38esi638100edp.595.2023.04.04.06.55.09; Tue, 04 Apr 2023 06:55:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SDmoxT4S; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235713AbjDDNyL (ORCPT + 99 others); Tue, 4 Apr 2023 09:54:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235747AbjDDNxl (ORCPT ); Tue, 4 Apr 2023 09:53:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12F9249C0 for ; Tue, 4 Apr 2023 06:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680616364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2t022cV29B7Zbre5ZWJdAks4cSokwANFRg/jjQH6iKk=; b=SDmoxT4S4XKH+97lmOoAZ40I5BKpsPNcdfV9O6lJ4pDvg+bt6Z/sclUL7KTCbfYhEXMMvq 4NvgGyBTE5JOT6R7WKurQz4VLwB63mOlDJ3fJkUJN4JwldcSiMffRL8bdA00NKAJJWJbN6 xpOpivupPBcHXRxFXmN6GPyqKQX3Tm8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-12iwtGryPiqol-iNg5cCTw-1; Tue, 04 Apr 2023 09:52:39 -0400 X-MC-Unique: 12iwtGryPiqol-iNg5cCTw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F4463855561; Tue, 4 Apr 2023 13:52:38 +0000 (UTC) Received: from [10.22.32.153] (unknown [10.22.32.153]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3BF82166B26; Tue, 4 Apr 2023 13:52:37 +0000 (UTC) Message-ID: Date: Tue, 4 Apr 2023 09:52:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 1/3] cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly Content-Language: en-US To: =?UTF-8?Q?Michal_Koutn=c3=bd?= Cc: Tejun Heo , Zefan Li , Johannes Weiner , Christian Brauner , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Juri Lelli , Dietmar Eggemann , gscrivan@redhat.com References: <20230331145045.2251683-1-longman@redhat.com> <20230331145045.2251683-2-longman@redhat.com> <20230403165523.aphsec2epqi72k27@blackpad> <20230404091953.tcu3zg7npstk3ztc@blackpad> From: Waiman Long In-Reply-To: <20230404091953.tcu3zg7npstk3ztc@blackpad> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/4/23 05:19, Michal Koutný wrote: > On Mon, Apr 03, 2023 at 01:18:42PM -0400, Waiman Long wrote: >> 1) PF_NO_SETAFFINITY flag - which won't be set in the case of fork() as it >> is for kthread only. >> 2) DL bandwidth - Juri has a cpuset outstanding to modify the way this check >> is being done. I want to wait until it is settled before tackling this, if >> necessary. > BTW what about CLONE_INTO_CGROUP where the target cpuset has empty > effective cpuset? Good point. That will require a can_fork() method then. I will look into that. > >> 3) security_task_setscheduler() - the CLONE_INTO_CGROUP code has already >> checked that, we don't need to duplicate the check. > Not sure what this refers to. It is just checking of the task the has privilege of running into that cgroup. > >> So we don't need a can_fork() check for now. > Anyway, good breakdown. Could you please add it to the commit message > too? Yes, I can put that into the commit log. Cheers, Longman > Regards, > Michal