Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230125-tfp410_i2c-v3-0-a85d5f0f50f1@criticallink.com>
 <20230125-tfp410_i2c-v3-2-a85d5f0f50f1@criticallink.com> <4a22e085-b339-aa43-518e-d528c5f76de4@linaro.org>
In-Reply-To: <4a22e085-b339-aa43-518e-d528c5f76de4@linaro.org>
From:   Jon Cormier <jcormier@criticallink.com>
Date:   Tue, 4 Apr 2023 09:54:43 -0400
Message-ID: <CADL8D3Zhn1iFo0fn-VSw5DTvh3UNmCLAFKviKOOa-+F64tRFTA@mail.gmail.com>
Subject: Re: [PATCH v3 2/3] drm/bridge: tfp410: Fix logic to configured polled HPD
To:     neil.armstrong@linaro.org
Cc:     Andrzej Hajda <andrzej.hajda@intel.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Michael Williamson <michael.williamson@criticallink.com>,
        Bob Duke <bduke@criticallink.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Mar 31, 2023 at 5:00=E2=80=AFAM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> Hi,
>
> On 20/02/2023 23:10, Jonathan Cormier wrote:
> > From: Michael Williamson <michael.williamson@criticallink.com>
> >
> > The logic to configure polling (vs async/irq notification) of hot-plug
> > events was not correct.  If the connected bridge requires polling,
> > then inform the upstream bridge we also require polling.
> >
> > Signed-off-by: Michael Williamson <michael.williamson@criticallink.com>
> > Signed-off-by: Jonathan Cormier <jcormier@criticallink.com>
> > ---
> >   drivers/gpu/drm/bridge/ti-tfp410.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridg=
e/ti-tfp410.c
> > index bb3f8d0ff207..41007d05d584 100644
> > --- a/drivers/gpu/drm/bridge/ti-tfp410.c
> > +++ b/drivers/gpu/drm/bridge/ti-tfp410.c
> > @@ -155,7 +155,7 @@ static int tfp410_attach(struct drm_bridge *bridge,
> >               return -ENODEV;
> >       }
> >
> > -     if (dvi->next_bridge->ops & DRM_BRIDGE_OP_DETECT)
> > +     if (dvi->next_bridge->ops & DRM_BRIDGE_OP_HPD)
> >               dvi->connector.polled =3D DRM_CONNECTOR_POLL_HPD;
> >       else
> >               dvi->connector.polled =3D DRM_CONNECTOR_POLL_CONNECT | DR=
M_CONNECTOR_POLL_DISCONNECT;
> >
>
> A Fixes tag is probably needed here ?
Thanks will do
>
> With that:
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>


--=20
Jonathan Cormier
Software Engineer

Voice:  315.425.4045 x222


http://www.CriticalLink.com
6712 Brooklawn Parkway, Syracuse, NY 13211