Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6057629rwl; Tue, 4 Apr 2023 07:18:56 -0700 (PDT) X-Google-Smtp-Source: AKy350YU4W5JT7jxPzHPS77e/pAAHw9vCMTCCLdcqaB88iwgfnQay/mc2WbYklvDEyRJFX69UnCH X-Received: by 2002:a17:90b:4d84:b0:23f:91e5:103d with SMTP id oj4-20020a17090b4d8400b0023f91e5103dmr3001184pjb.36.1680617936406; Tue, 04 Apr 2023 07:18:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680617936; cv=none; d=google.com; s=arc-20160816; b=1HajGOa3P9tEH89AclTZiykp+LKY/iUWmV3o4HN6dpuUAuqukOkOIhm94hyepsndGQ aY869BZQQ/LI6uAxbYWo4RmygunuVGxwEHTc+3iaUI9i57SX8d78gvDFwyPLB1cuJEsQ lvCL+R1jTTiHZ0yqKB5yyK6F19M5w2jBYFRoxBo3K4GQAn+9FDL950MuoPHBogSgs6hm Bkx41eMRhIQv28PPJUG2qSybWkf7lTaHeRKDnELu5VcwxDhBILE7UNloP/OTkAuE66pT 42O7GEtOAWRRZ/CX9JGkWCY64Oi3Wb+A2NX6ec+PJHxqj2wkWKxl1yCfkTLxE5OA7+mS fOWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=ZnWzTfCBouLvNFIttgdZiBeapl1jQzHQOa2b0uZW+Yw=; b=XtwcpGTgELyf9KSY2r5QTTqncURrWfM12vG8DZG6q4wCdQWijFHLAF/uJg16kXmQBB 7Ysqu7UsP4/u+XiZ8DOJDagCl0/tPqLZ9GF/wiWnbmH6ND39dyCLsv0mQG/UxxYCH1le BZeLVZFXIMp1+5mDdI7jdDpThEsKlBCbnct5wovDxVSMUqSeEhXQR9W6i88SS9/MOaC9 AUxhtFhuLxnOWgmZjV1V/rINarELRlcygEHVnb87Kl9SK1bxDkGB9GaozOWPI21J3kCR rdK7vaErFNXq+c0ZrmWfQ3ua0NQE6Ds2s2FmB4DevezdaiG9quo6N58nqUHiWZK+jyvn 48Ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KMcOqCDL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k6-20020a17090a9d8600b0023f09937e33si10093074pjp.67.2023.04.04.07.18.43; Tue, 04 Apr 2023 07:18:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KMcOqCDL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235597AbjDDOJg (ORCPT + 99 others); Tue, 4 Apr 2023 10:09:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235537AbjDDOJb (ORCPT ); Tue, 4 Apr 2023 10:09:31 -0400 Received: from mail-yw1-x112a.google.com (mail-yw1-x112a.google.com [IPv6:2607:f8b0:4864:20::112a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C66A22720 for ; Tue, 4 Apr 2023 07:09:29 -0700 (PDT) Received: by mail-yw1-x112a.google.com with SMTP id 00721157ae682-545cb3c9898so540414727b3.7 for ; Tue, 04 Apr 2023 07:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680617369; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZnWzTfCBouLvNFIttgdZiBeapl1jQzHQOa2b0uZW+Yw=; b=KMcOqCDLEz4aCPi34/DOPsImPsfw5ZeY0wTsPwjTfIBU/l8v/gfv0G0ZJWuJFgp33K CnCFkpUWUid4/EqWu0KpzJp+ofxgiC3yfhwMGkRWrKSwHMCo8Sht4RuLq2QKsImi27po bmLfnmR3tU2a8TrgFXHh0jEVeqHtp8jzeFZ8KjQJnFuZGaet0e3zNlqXcLLyGlug3HfB 5kXM58LW/rqMa+R3QQrJyvjcdlZe21cOub/Rgop8wFGNfXn5lj83IxKTtH42SwuzKLPk mKljKuqg7i64XLV7v0JJ31P/xzsGAWbjF+KGl3neksq1QdFpll7etMjjVsEXE1Yd44zg gy3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680617369; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZnWzTfCBouLvNFIttgdZiBeapl1jQzHQOa2b0uZW+Yw=; b=anriIrWq9RIZpmyp0s9F422Clgfo6x60mGJ9xsKG3BoC6v/Ki6//QAEFzVBP1eIsdq ogLDf1aC/RQK2qcll3wY5l7zyQaQY9LU5G6cXou0ARVXku/dL/Dr9X4kB3ytIKsxiZO4 H90doLAULT654qWynaXh3qfFrok4UHKwqE3zwBq+kJkpy1PDWsIQaLlQUE2plyXf6aQR 96efvVG6K7bqfltt1j/xrb8nBkBneL/BYxB1AJwizUMijcW7kEP1QWpaIZcV+/nIR6qh xxfSccC9ItM3JJyHRfQq2CP6TSTDDKr3yeTDakTyi1pLejQFkuTYzGDsCYw5blx0Nxwq JKRw== X-Gm-Message-State: AAQBX9fC8VTbTrjZsx9gB/zsKH1NO9nUg3rVnoJrUWRuFaDGykoPkkAM A7Yhfi7EGIrf5h5TNncibA1zGxf8k95O++Pq5LbOtg== X-Received: by 2002:a81:a88a:0:b0:549:17fe:17c5 with SMTP id f132-20020a81a88a000000b0054917fe17c5mr1525744ywh.9.1680617368899; Tue, 04 Apr 2023 07:09:28 -0700 (PDT) MIME-Version: 1.0 References: <20230404004501.1913144-1-trix@redhat.com> In-Reply-To: <20230404004501.1913144-1-trix@redhat.com> From: Linus Walleij Date: Tue, 4 Apr 2023 16:09:17 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: mlxbf3: set varaiable mlxbf3_pmx_funcs storage-class-specifier to static To: Tom Rix Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 4, 2023 at 2:45=E2=80=AFAM Tom Rix wrote: > smatch reports > drivers/pinctrl/pinctrl-mlxbf3.c:162:20: warning: symbol > 'mlxbf3_pmx_funcs' was not declared. Should it be static? > > This variable is only used in one file so it should be static. > > Signed-off-by: Tom Rix Obviously correct so patch applied. Yours, Linus Walleij