Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6099177rwl; Tue, 4 Apr 2023 07:51:57 -0700 (PDT) X-Google-Smtp-Source: AKy350Z/h2CuiPO2iNld2aE03Ikaj6+byOf6LzyP+fDor3hZ+YcwjqWLA9imdX2z9kSVQzD8VJDx X-Received: by 2002:a05:6a20:bca8:b0:da:7036:dfa4 with SMTP id fx40-20020a056a20bca800b000da7036dfa4mr2016431pzb.32.1680619917228; Tue, 04 Apr 2023 07:51:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680619917; cv=none; d=google.com; s=arc-20160816; b=PBgGMFLzf5zVUllcqP3vlJesbFZN8iBQCz/hJ/TBgQUKnGE9LdqZx42/F+l1mAfpWN VgVGhaS//h3aotSP3tEYk9WfYpg11AJaZvYbmDGcqGTzV7LngD4P70ebgfcF41qpyMc7 1OuZy7irbnZpylAIpQoxhackfbNmGTNhm4dEvDaKJiLoEiGGNvB7hs38zuxstbPW1/PX lSSWmAI1UPLyN9B/z5vDwF434haw3udFhecrIFE4sB7V2Q4VUD8zsXepVFVPpti3WObt k2G2ZFiY1px83CZrTDu9j5YHleCnVvlBHg6Ixlc67jO1vm4yGHxZWBuSmVf6z7ojLmA2 J1Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=za5BO/JgKy56P0P/Z8yk+aMunnq2fdjXd9ztVhDZs+E=; b=Z7l6NGT0kfdc1ANA94TfbNCmQSdG0qm8LzCkUy0qBuhdmerSoc79GOrZ7vtg9m+Axw F1AojqGphcnK/zVRZn8CBUZXPu45N1LbQdge9GAhc3v3ex/yc3+0RBqML9PfiK6OCuKN tUyKWBm067p53eMcllzf9LsQnLWV4QFZXCL017myse6WVOUqsLdW5rbmwWEkSeVzVurq Do7zuupJy2TB14MHSegP85eqFgmYqt8Pyw5nGMkbppB7OLPHt2M2odh5gL/guV4CCwwZ cHu7Uf59g6gMl25R3OliLisHMdJXy/wcKxjrSNVlUDf7uhHhTpImpqwtyvbEHWzkg7Ao XbfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="S/XoFNDU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 188-20020a6301c5000000b00514156b3cbfsi1911192pgb.875.2023.04.04.07.51.44; Tue, 04 Apr 2023 07:51:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="S/XoFNDU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230443AbjDDOm4 (ORCPT + 99 others); Tue, 4 Apr 2023 10:42:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjDDOmy (ORCPT ); Tue, 4 Apr 2023 10:42:54 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3142E51; Tue, 4 Apr 2023 07:42:53 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id r14so18689191oiw.12; Tue, 04 Apr 2023 07:42:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680619373; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=za5BO/JgKy56P0P/Z8yk+aMunnq2fdjXd9ztVhDZs+E=; b=S/XoFNDUa4RahS6B4V+VsVOf16zucDqkJ+QMdZlpXWLfiNtquZ4Q7Ow7PAJ6f0xhVC 4gY05G4PwrVh94KhtkQh6wXmUzH7lDGaz2wZeVmQfSAdXhFKk5PRZtJH8a/qDrM0xHiZ RNt7Q6WGzJeTbrh0YgdoKyzylFHC8EoIa4W7ekqvnKPqMV3NL6wHIFsCZWJRclQXE5lk X/ePKsGsZk5gsbsCfzNFyFUc+WGObK+ai4mH33lR0+uovfqnynNeYXr7JlFTU6Ql65X5 FbksPoUTrbUNZI72nKeWMwkSRasU9R96IQ+hYwLh9A/ps96VGsYoafia+BCVeM5qEe/O fdRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680619373; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=za5BO/JgKy56P0P/Z8yk+aMunnq2fdjXd9ztVhDZs+E=; b=ki7yA/P4ZGpvdZEK15Uw3Bsjk3y1LqJXeOR0wEeTsWcSTg+YSoMfFz7VI3sbU/bUOt C+6KUWGqIB/lZcU8gLeSs0dPqL5BZiG7UBMB6cWP+NFOoflhBROkrTZ5soAc94ztV6wg W5U1WXNyPKrZYnQSe75IxIbZFRiQGWKYfvd5X1ywVoAr0ZsiillzLcg668Op9iwtpwEF pa+eUxKj6EQCAc+yYOSWI/0mjvxgGA50neUAppRifpShSaKqvjRrg5rN5+DaHXckTW+c UhWoDpQA4NElg0glIO49eL/cssH8CM+HYIdIkxAOgcArHcAD7Sc1O0VPAYjxGUMTwoaB slbA== X-Gm-Message-State: AAQBX9fcAzRjG5VQk8c/Lte0rxKKg/152rfXVAr4oecow3ioaLpuV0j+ PQlFlmxDW1HZzCzHw2tMgkGpixQYlBOVzkgrm3E= X-Received: by 2002:a05:6808:6294:b0:389:72d5:f15f with SMTP id du20-20020a056808629400b0038972d5f15fmr1093634oib.10.1680619373128; Tue, 04 Apr 2023 07:42:53 -0700 (PDT) MIME-Version: 1.0 References: <20230404082426.3880812-1-rick.wertenbroek@gmail.com> <20230404082426.3880812-7-rick.wertenbroek@gmail.com> <63d456fa-4db5-96fc-107e-060e59754096@linaro.org> In-Reply-To: <63d456fa-4db5-96fc-107e-060e59754096@linaro.org> From: Rick Wertenbroek Date: Tue, 4 Apr 2023 16:42:17 +0200 Message-ID: Subject: Re: [PATCH v3 06/11] dt-bindings: PCI: Update the RK3399 example to a valid one To: Krzysztof Kozlowski Cc: alberto.dassatti@heig-vd.ch, damien.lemoal@opensource.wdc.com, xxm@rock-chips.com, Shawn Lin , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Heiko Stuebner , Johan Jonker , Brian Norris , Caleb Connolly , Corentin Labbe , Judy Hsiao , Lin Huang , Arnaud Ferraris , Hugh Cole-Baker , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 4, 2023 at 3:29=E2=80=AFPM Krzysztof Kozlowski wrote: > > On 04/04/2023 10:58, Rick Wertenbroek wrote: > > On Tue, Apr 4, 2023 at 10:45=E2=80=AFAM Krzysztof Kozlowski > > wrote: > >> > >> On 04/04/2023 10:24, Rick Wertenbroek wrote: > >>> Update the example in the documentation a valid example. > >>> The default max-outbound-regions is 32 but the example showed 16. > >> > >> This is not reason to be invalid. It is perfectly fine to change defau= lt > >> values to desired ones. What is not actually obvious is to change some > >> value to a default one, instead of removing it... > > > > Hello, the example value <0x0 0x80000000 0x0 0x20000>; is plain wrong > > and will crash the kernel. This is a value that point to an address tha= t falls > > in the DDR RAM region but depending on the amount of RAM on the > > board this address may not even exist (e.g., board with 2GB or less). > > We talk about max-outbound-regions. Okay, sorry, I didn't get that, you are right, there is nothing wrong with = 16. I'll remove that change and leave it be. > > > > > Also this address requires pointing to where the PCIe controller has th= e > > windows from AXI Physical space to PCIe space. This address is > > allocated when the SoC address map is created so it can only be that > > one unless rockchip refabs the SoC with another address map. > > > > The example never worked with the values given as reported by e.g., > > https://stackoverflow.com/questions/73586703/device-tree-issues-with-ro= ckpro64-pcie-endpoint > > and here they set it to 0 (base of the DDR, which is a "valid" address > > as to it exists even on boards with less than 2GB) but it is still wron= g > > to do so. > > Again, my comment was under max-outbound-regions, not under some other > pieces. Does this all apply? > > Best regards, > Krzysztof > I'll remove the change to the max-outbound-regions, it is not needed. I'll place the registers as second parameter, both on the dtsi entry and he= re. I'll keep the change to the register value because it is necessary along with the added pinctrl. This will simplify the patch, avoid unnecessary changes, and make things clearer. Sorry for the misunderstanding. Regards, Rick