Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6100036rwl; Tue, 4 Apr 2023 07:52:45 -0700 (PDT) X-Google-Smtp-Source: AKy350ba5Wjpu06owDallb0L6SFIFTj4VBMJ+CcgrCcgT5n/iZ0W2K5sXkY4LeeoZgfSmrG2drC/ X-Received: by 2002:aa7:96c9:0:b0:62d:8376:3712 with SMTP id h9-20020aa796c9000000b0062d83763712mr2564626pfq.28.1680619965207; Tue, 04 Apr 2023 07:52:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680619965; cv=none; d=google.com; s=arc-20160816; b=wKr2rQIBC3Prq8O9qT3aX9Xh0qL3EpFus/lg8lPPaCxmYPArwdzftDl81KvOsf45gl kbuR8pNOktlirk5jHC++qsRGas90Qk5sX4furIcNc3iYapAOM5EsIZCt4lSFZD3HlDLq 2t63d8ZjVouQEnM3xuPWTMLmXK67ECPb58TK1WYowpPje/9EQuPkmUU7nYZZ8YDdfPhU +IRdvXuYp1pABQYYUz2tRAUSHsfm8kcJZJ1Yo0ab0v80Z2PK1eqAT1O3fdjvZviXVJTP sQpMNpKrjzPOcSsxTxqGL0zg4t3jKikmGqIRx5HW6XIgm4DIaB+Lj4ropjXWaE8kWivL qA6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=2FSMiC/0F7X1eEICMSaVFBL3LFFGu6U5wR9zVECLWME=; b=rQIQW+GFQGMMXVEO2zq4yPcTVgI4Abw2FxRU/Yqm1EMBcXwVy6djamHNa9G2egvRuG ftyXESuC/mxPQZKfptOcuvNl9fimWhQFyW9X9zQR6/85hniCcODChBjYnFFG6m7PfQia PqKhkmMAlM8YvJNRIz+xgdxNyy/GsGVKu4AyuebUPViaYriVwR3CmOIhghGTIhF97W9L dg/NdE+QueMjbKZm1EawrIQ24G3smaoK3GAoz/I17cuXEgiSHQppA+tAP5PlHTbH75Ju KIWXejTjgXdxyf1ItLRVw8RXAP/wfwnUgC+oC5YOr7DE4+kp/iD+GGnzA1uzx9IVQMS2 qaPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b28-20020aa7951c000000b006221fa0b8d1si10395624pfp.71.2023.04.04.07.52.33; Tue, 04 Apr 2023 07:52:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231664AbjDDOpW (ORCPT + 99 others); Tue, 4 Apr 2023 10:45:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231644AbjDDOpU (ORCPT ); Tue, 4 Apr 2023 10:45:20 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 625D8198; Tue, 4 Apr 2023 07:45:18 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B307FEC; Tue, 4 Apr 2023 07:46:02 -0700 (PDT) Received: from [10.57.53.173] (unknown [10.57.53.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5841F3F73F; Tue, 4 Apr 2023 07:45:13 -0700 (PDT) Message-ID: <6e208366-6c28-6015-b80c-9cf2257d6414@arm.com> Date: Tue, 4 Apr 2023 15:45:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 19/32] perf/arm-cci: Assign parents for event_source device To: Jonathan Cameron , Mark Rutland , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org Cc: linuxarm@huawei.com, Dan Williams , Shaokun Zhang , Yicong Yang , Jiucheng Xu , Khuong Dinh , Robert Richter , Atish Patra , Anup Patel , Andy Gross , Bjorn Andersson , Frank Li , Shuai Xue , Vineet Gupta , Shawn Guo , Fenghua Yu , Dave Jiang , Wu Hao , Tom Rix , linux-fpga@vger.kernel.org, Liang Kan References: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> <20230404134225.13408-20-Jonathan.Cameron@huawei.com> From: Suzuki K Poulose In-Reply-To: <20230404134225.13408-20-Jonathan.Cameron@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2023 14:42, Jonathan Cameron wrote: > Currently the PMU device appears directly under /sys/devices/ > Only root busses should appear there, so instead assign the pmu->dev > parent to be the platform device. > > Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/ > Signed-off-by: Jonathan Cameron Reviewed-by: Suzuki K Poulose > --- > drivers/perf/arm-cci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/perf/arm-cci.c b/drivers/perf/arm-cci.c > index 03b1309875ae..502581ba7d15 100644 > --- a/drivers/perf/arm-cci.c > +++ b/drivers/perf/arm-cci.c > @@ -1412,6 +1412,7 @@ static int cci_pmu_init(struct cci_pmu *cci_pmu, struct platform_device *pdev) > > cci_pmu->pmu = (struct pmu) { > .module = THIS_MODULE, > + .parent = &pdev->dev, > .name = cci_pmu->model->name, > .task_ctx_nr = perf_invalid_context, > .pmu_enable = cci_pmu_enable,