Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6101531rwl; Tue, 4 Apr 2023 07:54:13 -0700 (PDT) X-Google-Smtp-Source: AKy350aF9UrKvw4aHGZ1wNH7sIAl08I552hVCC9HsnbR/6UD1IbgXUCEhdakst0lM/dPqOeiqRGv X-Received: by 2002:aa7:9f96:0:b0:62a:4fb1:3dea with SMTP id z22-20020aa79f96000000b0062a4fb13deamr2542070pfr.24.1680620053162; Tue, 04 Apr 2023 07:54:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680620053; cv=none; d=google.com; s=arc-20160816; b=T0hZZdySYe9dos+Hq3m8UpZiQiIWAf1wZoW7F3y1OPi1VF6qYH5g5hG1rp1w/W/g4R wjh2V7RtFhpu27c6MoTKFqI8oFp6PAfi4smZu5S4uzYMsBWKZkD+mmtuZ3ZALi08utp6 yCrkxrXTKpq+eRcH9wX7BMtiPrbmYOadAfl2SdgPs2S9vFNvbIX4XPbRgZkhnbAyuE+W GbYiHy9cTkRmQeejLGR0eQOwMxTbHtkUiwlexupfRUyuLD4bqsxUg9KC9GT6wD3h19Ah hDlOOtzqbJjN/Wfub1XHoWXrev8sR5fXCju3rojxQJzPolSH9mtI0kUbMpIf/SOTXex5 HlWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=aohVMxRzSPQT7H9BfU7TRI6Xt5xug2nHFZ8iJCrRzmI=; b=0tZjXotUiInV16bHfTQv4QXYCdl7m7hadYUca4L3ccpsc/hcFlDDFax42y2JIeHsZx R2ywurCifsbapCXYm43PCGo7FgemxzyF+iGhJYR3QRX9ITBWpuOcvHHWSzjF+iqUW0+T V4QJCAvdCzvkcA59k7DbQJj0fQ8JVcAp8GdlsTQICurEwj7n9DI+oT7bcQY4R/JLV5p+ X9oW1R/a+I1osvOJxYZt2gWnufBK9tOxeAgTXcLiu8oQdiSZ7YTV5W/9SG+WEYPmbqxN Jgpx8h/V7hkBaErDP/eA+oGYkuse+oolA/qceZk1PPEAEDJIFBXU66O2q0gUGp8xR64q xFJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h130-20020a636c88000000b0051372e8f9b3si1967283pgc.826.2023.04.04.07.53.59; Tue, 04 Apr 2023 07:54:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231637AbjDDOu7 (ORCPT + 99 others); Tue, 4 Apr 2023 10:50:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231348AbjDDOu6 (ORCPT ); Tue, 4 Apr 2023 10:50:58 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8A01330C5; Tue, 4 Apr 2023 07:50:57 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8759D75; Tue, 4 Apr 2023 07:51:41 -0700 (PDT) Received: from [10.57.53.173] (unknown [10.57.53.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C53553F73F; Tue, 4 Apr 2023 07:50:52 -0700 (PDT) Message-ID: <1fe0de39-c98b-e4e8-44df-8c899efb3019@arm.com> Date: Tue, 4 Apr 2023 15:50:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 08/32] perf/arm_cspmu: Assign parents for event_source devices To: Jonathan Cameron , Mark Rutland , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org Cc: linuxarm@huawei.com, Dan Williams , Shaokun Zhang , Yicong Yang , Jiucheng Xu , Khuong Dinh , Robert Richter , Atish Patra , Anup Patel , Andy Gross , Bjorn Andersson , Frank Li , Shuai Xue , Vineet Gupta , Shawn Guo , Fenghua Yu , Dave Jiang , Wu Hao , Tom Rix , linux-fpga@vger.kernel.org, Liang Kan References: <20230404134225.13408-1-Jonathan.Cameron@huawei.com> <20230404134225.13408-9-Jonathan.Cameron@huawei.com> From: Suzuki K Poulose In-Reply-To: <20230404134225.13408-9-Jonathan.Cameron@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/04/2023 14:42, Jonathan Cameron wrote: > Currently all these devices appear directly under /sys/devices/ > Only root busses should appear there, so instead assign the pmu->dev > parents to be the platform device. > > Link: https://lore.kernel.org/linux-cxl/ZCLI9A40PJsyqAmq@kroah.com/ > Signed-off-by: Jonathan Cameron > --- > drivers/perf/arm_cspmu/arm_cspmu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c > index e31302ab7e37..4390e4fb1e95 100644 > --- a/drivers/perf/arm_cspmu/arm_cspmu.c > +++ b/drivers/perf/arm_cspmu/arm_cspmu.c > @@ -1155,6 +1155,7 @@ static int arm_cspmu_register_pmu(struct arm_cspmu *cspmu) > cspmu->pmu = (struct pmu){ > .task_ctx_nr = perf_invalid_context, > .module = THIS_MODULE, > + .parent = cspmu->dev, > .pmu_enable = arm_cspmu_enable, > .pmu_disable = arm_cspmu_disable, > .event_init = arm_cspmu_event_init, Reviewed-by: Suzuki K Poulose