Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Apr 2023 22:50:57 +0800
From:   Philip Li <philip.li@intel.com>
To:     Dan Carpenter <error27@gmail.com>
CC:     Joseph Qi <joseph.qi@linux.alibaba.com>, <lkp@intel.com>,
        <oe-kbuild-all@lists.linux.dev>, <oe-kbuild@lists.linux.dev>,
        "Heming Zhao via Ocfs2-devel" <ocfs2-devel@oss.oracle.com>,
        <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: fs/ocfs2/super.c:1809 ocfs2_mount_volume() warn: missing error
 code 'status'
Message-ID: <ZCw5Ucw5CS6nXosr@rli9-mobl>
References: <9e1d6835-34fc-49cd-869e-d99d9b546d17@kili.mountain>
 <4154b815-3be4-53de-1bc0-ca87ecb925a4@linux.alibaba.com>
 <1e7d7076-ddd6-41b3-b824-673986c35477@kili.mountain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1e7d7076-ddd6-41b3-b824-673986c35477@kili.mountain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6KiE1nb9vDyJfbwRmtRWcpFa1Uv5uqkmFDPTWyVJKvVK32qTbPn2RQ5Py1Yl?=
 =?us-ascii?Q?lB/pKwPJaHLhZzO/0ULXxcnHtDY7EXJYB68glNizvI4ydAH7zG/+TzoKF8C6?=
 =?us-ascii?Q?ewDdtp5ZB6OI+vIHHB46S2Te6465OwOM82eJIugIm84PpfF/Ws1rn22vDdE0?=
 =?us-ascii?Q?t2gWX2umeqGLCWjd2nwdGEYUjC/W47THqVmaMNul/UeNR5sSnjUVDgr/N33h?=
 =?us-ascii?Q?ZzVQYy1wnoJSIvqnBv08j2/Gn1UzBJpl46V6TPBU9f8Jr0JyyswweLSaO0hb?=
 =?us-ascii?Q?/3028Cbhkyqc93s7lqYKhu2LF6nvlZTg3bvCWy1cj1Owu6jcfy7EAAAs5wv6?=
 =?us-ascii?Q?1l8VeN6b4GOGjc2thP66LrUyr5UV/KN7zhx5ndIi8gKMVPJy6YjlkHGuBSaq?=
 =?us-ascii?Q?+9gpJBIgYnE2w855f5s34kIdrZmSXyq7BexlbQDrpKu7l+4AOjqX2JzFBf2h?=
 =?us-ascii?Q?T8ZY50G4Rmbox2bN8YsS8maJnx2++oNFn0b5Ms1b7CtiP0LC0MvLa8oCp6WD?=
 =?us-ascii?Q?8o405/cOHxBvXLbiqF8B7KFjVge5O4VLOLJzwH6CeN3gKwaHPcbDW9nqCo3+?=
 =?us-ascii?Q?4AHcKOQ3vqJG7n0pVapKsV3COZhJdNLJ630miEIDI/DmFenXFc8mDxqlhgFM?=
 =?us-ascii?Q?/DiPJ62MmEQGcu7RreiD4iP8+rrr598nVy1a2uXVjacQxsiLAMkyXt30H+nr?=
 =?us-ascii?Q?29SzPLw6TOHtk4vAsFUjU2A1aNAT+HNWA0fgNc/kW8DzevwfW8LTcpG3RdTl?=
 =?us-ascii?Q?cqSmLRguVe3fXOfof3muuPG/CRsSxnHqpzXVDRYb6EwGK92+jhfBJMmbi3vv?=
 =?us-ascii?Q?G3zTMrFlWSZPrbWHMcHXKUrdFHZ23ToWcmcMfJmeyQdYfKC7jen+WxgLWZim?=
 =?us-ascii?Q?v6roLiBVWNU+xcjEZns+HYnUcl/N7v0xKtIreWS7rPKkDiE69hmglVOCZ5ei?=
 =?us-ascii?Q?GeLYBtykfV8MOE1mI2aEBqjJMNxWtF5QvEBQQuLZ//Mr2+UIWrsQ2KXXrkiE?=
 =?us-ascii?Q?6x7IDsmsTQsd4ictjl49ZKu/yUZ1grQqjLqykY8BXB8BS2wSnJjhMuEbuIGI?=
 =?us-ascii?Q?Q0tGhD4umctq4IaC3lG6x8Z6rdPP8FQ++baMHSHTQkH0MjYUGuxmGfCde69d?=
 =?us-ascii?Q?9LB1TNvvUOD3/XHaihd7d58Bg2MCPIq4uXRcHq3WB81dLupVwRHtX+FYfTr2?=
 =?us-ascii?Q?VzzWCZjD7ChqYM9kqMiwe351xRODfhkiatkrF7edAGi2oiz0KdS1wjIZoLtn?=
 =?us-ascii?Q?YlNkc42IAYtLTZrv3cvihAs5kIgagWhEC9Oj/Zcr+rPUSQD/mVa9KL5+SsyJ?=
 =?us-ascii?Q?VleZNeM87ofWUBPIe/uahS13HLNuNCIlBlTpxymmfuRvI05sZj6Cb9HPi5Ml?=
 =?us-ascii?Q?AUOwJajDPCS5RxMHBgHV5HVlMsORQ+b7btvO7eUext3PTSG/rqsztDpNqtXt?=
 =?us-ascii?Q?P7E1RH48LDRdJ1uUEY1Rb4Af6XJjn53+VSTVYMsPGQYoinuhA4/cHkjlWtsB?=
 =?us-ascii?Q?9uomIvUXyR8xK+pvEgJntOe890Xo6UCD0kqNmY0RrJ/LQOVU8QZ0C0GnOW/G?=
 =?us-ascii?Q?wyToSHgtMVQZ9vCMiBAIh/OTaJRo9lwW5oOoOiUH?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f091dad4-37a5-409e-38ef-08db351c0571
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2995.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 14:51:07.3730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JPQIEprZ/ry/abEQ8fM15syFZ5vVB8Vw2KWihjnVUgz6FOTGc0qxagDbb3Mi07JvWbk99zJ7oDySPVfnAsXBRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6902
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 03, 2023 at 02:20:55PM +0300, Dan Carpenter wrote:
> Sorry, the kbuild bot is not supposed to send duplicate warnings.  I
> don't know why it was sent again...

Sorry about this, we should ignore this commit in the bot. Now it is configured
to avoid the false positive report.

> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   7b50567bdcad8925ca1e075feb7171c12015afd1
> commit: 0737e01de9c411e4db87dcedf4a9789d41b1c5c1 ocfs2: ocfs2_mount_volume does cleanup job before return error
> date:   11 months ago
> :::::: branch date: 15 hours ago
>        ^^^^^^^^^^^^^^^^^^^^^^^^^
> Something happened on Apr 1.
> 
> :::::: commit date: 11 months ago
> config: arm64-randconfig-m041-20230329 (https://download.01.org/0day-ci/archive/20230401/202304012244.gX4H4rBO-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 12.1.0
> 
> regards,
> dan carpenter
> 
> On Mon, Apr 03, 2023 at 07:07:37PM +0800, Joseph Qi wrote:
> > Hi,
> > IIRC, we've discussed this before.
> > Success return is expected in case of 'hard readonly'.
> > So this a false positive report.
> > 
> > Thanks,
> > Joseph
> > 
> > On 4/3/23 2:14 PM, Dan Carpenter wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   7b50567bdcad8925ca1e075feb7171c12015afd1
> > > commit: 0737e01de9c411e4db87dcedf4a9789d41b1c5c1 ocfs2: ocfs2_mount_volume does cleanup job before return error
> > > config: arm64-randconfig-m041-20230329 (https://download.01.org/0day-ci/archive/20230401/202304012244.gX4H4rBO-lkp@intel.com/config)
> > > compiler: aarch64-linux-gcc (GCC) 12.1.0
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Reported-by: Dan Carpenter <error27@gmail.com>
> > > | Link: https://lore.kernel.org/r/202304012244.gX4H4rBO-lkp@intel.com/
> > > 
> > > smatch warnings:
> > > fs/ocfs2/super.c:1809 ocfs2_mount_volume() warn: missing error code 'status'
> > > 
> > > vim +/status +1809 fs/ocfs2/super.c
> > > 
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1803  static int ocfs2_mount_volume(struct super_block *sb)
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1804  {
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1805  	int status = 0;
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1806  	struct ocfs2_super *osb = OCFS2_SB(sb);
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1807  
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1808  	if (ocfs2_is_hard_readonly(osb))
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29 @1809  		goto out;
> > > 
> > > Hard to tell if this should be an error path or not...  Canonical
> > > problem with do nothing gotos.
> > > 
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1810  
> > > 5500ab4ed3b8f0 Gang He                     2019-03-05  1811  	mutex_init(&osb->obs_trim_fs_mutex);
> > > 5500ab4ed3b8f0 Gang He                     2019-03-05  1812  
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1813  	status = ocfs2_dlm_init(osb);
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1814  	if (status < 0) {
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1815  		mlog_errno(status);
> > > a52370b3b182f7 Gang He                     2018-01-31  1816  		if (status == -EBADR && ocfs2_userspace_stack(osb))
> > > a52370b3b182f7 Gang He                     2018-01-31  1817  			mlog(ML_ERROR, "couldn't mount because cluster name on"
> > > a52370b3b182f7 Gang He                     2018-01-31  1818  			" disk does not match the running cluster name.\n");
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1819  		goto out;
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1820  	}
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1821  
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1822  	status = ocfs2_super_lock(osb, 1);
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1823  	if (status < 0) {
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1824  		mlog_errno(status);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1825  		goto out_dlm;
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1826  	}
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1827  
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1828  	/* This will load up the node map and add ourselves to it. */
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1829  	status = ocfs2_find_slot(osb);
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1830  	if (status < 0) {
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1831  		mlog_errno(status);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1832  		goto out_super_lock;
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1833  	}
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1834  
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1835  	/* load all node-local system inodes */
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1836  	status = ocfs2_init_local_system_inodes(osb);
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1837  	if (status < 0) {
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1838  		mlog_errno(status);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1839  		goto out_super_lock;
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1840  	}
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1841  
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1842  	status = ocfs2_check_volume(osb);
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1843  	if (status < 0) {
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1844  		mlog_errno(status);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1845  		goto out_system_inodes;
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1846  	}
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1847  
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1848  	status = ocfs2_truncate_log_init(osb);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1849  	if (status < 0) {
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1850  		mlog_errno(status);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1851  		goto out_system_inodes;
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1852  	}
> > > c271c5c22b0a7c Sunil Mushran               2006-12-05  1853  
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1854  	ocfs2_super_unlock(osb, 1);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1855  	return 0;
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1856  
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1857  out_system_inodes:
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1858  	if (osb->local_alloc_state == OCFS2_LA_ENABLED)
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1859  		ocfs2_shutdown_local_alloc(osb);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1860  	ocfs2_release_system_inodes(osb);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1861  	/* before journal shutdown, we should release slot_info */
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1862  	ocfs2_free_slot_info(osb);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1863  	ocfs2_journal_shutdown(osb);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1864  out_super_lock:
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1865  	ocfs2_super_unlock(osb, 1);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1866  out_dlm:
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1867  	ocfs2_dlm_shutdown(osb, 0);
> > > 0737e01de9c411 Heming Zhao via Ocfs2-devel 2022-04-29  1868  out:
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1869  	return status;
> > > ccd979bdbce9fb Mark Fasheh                 2005-12-15  1870  }
> > > 
>