Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Apr 2023 17:54:51 +0300
From:   Alexey Dobriyan <adobriyan@gmail.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] string: implement streq()
Message-ID: <db6ce106-a5fc-4742-a59e-ccbd39dfd69d@p183>
References: <4b595ab9-238c-43a5-aba0-be5d6afc0f87@p183>
 <20230403141641.6ace0d85fd48fbed5c02d7ef@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230403141641.6ace0d85fd48fbed5c02d7ef@linux-foundation.org>
Precedence: bulk

On Mon, Apr 03, 2023 at 02:16:41PM -0700, Andrew Morton wrote:
> On Sat, 1 Apr 2023 20:48:05 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> 
> > Most of the time strcmp() is being used, strings are checked for equality.
> > Add wrapper to relay such intent (it is shorter to type, too).
> > 
> > Use
> > 	if (streq(s, "s")) {
> > 	}
> > or
> > 	if (!streq(s, "s")) {
> > 	}
> 
> Gee, do we really want this?  I mean, we all know how strcmp() works,
> don't we?
> 
> I'm thinking it would be better to remove the various cute little
> streq() macros and open-code strcmp(...)==0.

No! It's cool, trust me. Try it out, you'll like it.
We "know" how strcmp() works because C didn't have streq() from
the very beginning.

strcmp() is only for insertion into trees. Half of the time you need
to read to the end of the expression to know if it is check for equality
or inequality. With streq(), you don't.

	stralexey