Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6146036rwl; Tue, 4 Apr 2023 08:25:52 -0700 (PDT) X-Google-Smtp-Source: AKy350a4RIYTrccpWjUppT54js95p3x357mO5BVtb6AAS0JbEgNyj+HmSg4i36Gm76xvBFVBLzvR X-Received: by 2002:a17:902:dad0:b0:1a1:da3c:605f with SMTP id q16-20020a170902dad000b001a1da3c605fmr3359408plx.58.1680621952217; Tue, 04 Apr 2023 08:25:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680621952; cv=none; d=google.com; s=arc-20160816; b=EKBW5Xl1VX53tHwNNxmhYgd8zp7H8AKp7MHYpTbJwfqW+556rzQvSH4Q0Fx/smTIjd p6FRwLeuBS6kxVhLOjqr/YYcfHfPZqg1wpcSJkuJJOWHjOvZfexEcYu7+YvuEnmXxyI6 GcKzpOsk/zsNXIUgyEo9vpEsTYctRJCHVlBltFj12giuftqHS9e012ugt6Fcjseh1CQF 3wXIZXTlMW3YpwqDdNTq3sUZ9wluoS25CJEN8WOAdyfeUkaAFrnrWIqtIsy8CSPyXnSU IxtdJfjhN6zD9bc2eyeZKqt+W6aaBx77f0FdowOA95kdTSZTrgdkkXJWdvaFLxSyHsv/ x4Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cHuev+laSziwM6gdDJJLMMaZ0GcoHaV1uuy1JEfyFtc=; b=ggHasz9HFjEhHXJ7BlUJA6cARU0AqM83XU8Lw5p9F3R6OA6XbmTx3v70vZI4kDU+Yg zSZ1hy6F7g8I9zHWzAGBS9kKAm+hk8crREp6XbbWIYsCt4lRP4u5ucXTnuspQKabrA92 BpsLG7mcGmoWXVFyRyvV6wX2vXDg6HHn4q4DRFoEa3ysLRpQV/0mJx5/Dw++aU3WU268 aPTGug5PwHxflxeFp7RlxBNp8+o6SIBtVwvk/0r2YQBohelFLKIpHgFNk24mpYxGi4Kj kugmSToAwbO+aXsr6/Upneg0l49/YqNncUc6OHQtTwNwLTrSYtjxK/E8ch/CSWAvFj6F HRvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=uky0j7p+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n33-20020a635921000000b0050fac33eb8bsi10367271pgb.144.2023.04.04.08.25.38; Tue, 04 Apr 2023 08:25:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=uky0j7p+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235160AbjDDPKj (ORCPT + 99 others); Tue, 4 Apr 2023 11:10:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbjDDPKh (ORCPT ); Tue, 4 Apr 2023 11:10:37 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D100B359F; Tue, 4 Apr 2023 08:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cHuev+laSziwM6gdDJJLMMaZ0GcoHaV1uuy1JEfyFtc=; b=uky0j7p+uWkVvEltGHje+zBvuO kQbp4NB8YRI6wz4uhmKAmwNXlIqIv5Dw0ID0havkpzNnYFJBuw7ukyiMWCfLGzuy3EtsOWiPk5kXq 9ulBSJ/BDfxNvcpzxfc5kSDU2s0rFXwyyxSh+eedLMsLQaK01K8Dij8DG2bnVfQvnvKn+HN04NObd C8ucFJAz+e6MyJDoTgPiuojD+U+zPIpAMTkgxdjH65pzECkdpMitUEB5uosoISC2cuAi6fr0rfBqw 2/Pcgdne+lXRPJrSTj5HY9Zsz06qTVzDuU3W6piYfRBEmAMMNdbRVz9w2JwVmr1J7KvS0Dd+d03Lg +lC69xrg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pjiIp-001wQV-1c; Tue, 04 Apr 2023 15:10:31 +0000 Date: Tue, 4 Apr 2023 08:10:31 -0700 From: Christoph Hellwig To: Pankaj Raghav Cc: axboe@kernel.dk, minchan@kernel.org, martin@omnibond.com, hubcap@omnibond.com, brauner@kernel.org, viro@zeniv.linux.org.uk, senozhatsky@chromium.org, akpm@linux-foundation.org, willy@infradead.org, hch@lst.de, devel@lists.orangefs.org, mcgrof@kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, gost.dev@samsung.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 4/5] mpage: use folios in bio end_io handler Message-ID: References: <20230403132221.94921-1-p.raghav@samsung.com> <20230403132221.94921-5-p.raghav@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403132221.94921-5-p.raghav@samsung.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + bio_for_each_folio_all(fi, bio) { > + if (!err) > + folio_mark_uptodate(fi.folio); > + else > + folio_set_error(fi.folio); > + folio_unlock(fi.folio); Super nitpicky, but I'd avoid inverted conditions unless there is a very clear benefit. I.e. I'd rather write this as: if (err) folio_set_error(fi.folio); else folio_mark_uptodate(fi.folio); Otherwise looks good: Reviewed-by: Christoph Hellwig