Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230404032311.146506-1-gehao@kylinos.cn>
In-Reply-To: <20230404032311.146506-1-gehao@kylinos.cn>
From:   Vipin Sharma <vipinsh@google.com>
Date:   Tue, 4 Apr 2023 09:59:05 -0700
Message-ID: <CAHVum0fR0JZ0gA2oPXRufKok+YydcDnu+k3gF7cTUvvxn16GAQ@mail.gmail.com>
Subject: Re: [RESEND PATCH] selftest/vmx_nested_tsc_scaling_test: fix fp leak
To:     Hao Ge <gehao@kylinos.cn>
Cc:     pbonzini@redhat.com, shuah@kernel.org, seanjc@google.com,
        dmatlack@google.com, coltonlewis@google.com, kvm@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        gehao618@163.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 3, 2023 at 8:24=E2=80=AFPM Hao Ge <gehao@kylinos.cn> wrote:
>
> Fix stable_tsc_check_supported fopen but not fclose
>
> Signed-off-by: Hao Ge <gehao@kylinos.cn>

I will recommend to expand the commit log to something more descriptive lik=
e:

KVM: selftests: Close opened file descriptor in stable_tsc_check_supported(=
)

Close the "current_clocksource" file descriptor before returning or
exiting from stable_tsc_check_supported() in
vmx_nested_tsc_scaling_test

> ---
>  .../selftests/kvm/x86_64/vmx_nested_tsc_scaling_test.c    | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/vmx_nested_tsc_scaling_te=
st.c b/tools/testing/selftests/kvm/x86_64/vmx_nested_tsc_scaling_test.c
> index d427eb146bc5..fa03c8d1ce4e 100644
> --- a/tools/testing/selftests/kvm/x86_64/vmx_nested_tsc_scaling_test.c
> +++ b/tools/testing/selftests/kvm/x86_64/vmx_nested_tsc_scaling_test.c
> @@ -126,12 +126,16 @@ static void stable_tsc_check_supported(void)
>                 goto skip_test;
>
>         if (fgets(buf, sizeof(buf), fp) =3D=3D NULL)
> -               goto skip_test;
> +               goto close_fp;
>
>         if (strncmp(buf, "tsc", sizeof(buf)))
> -               goto skip_test;
> +               goto close_fp;
>
> +       fclose(fp);
>         return;
> +
> +close_fp:
> +       fclose(fp);
>  skip_test:
>         print_skip("Kernel does not use TSC clocksource - assuming that h=
ost TSC is not stable");
>         exit(KSFT_SKIP);
> --

Other than commit log, Reviewed-by: Vipin Sharma <vipinsh@google.com>