Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Apr 2023 11:58:46 -0500
From:   Rob Herring <robh@kernel.org>
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Sudeep Holla <sudeep.holla@arm.com>,
        Cristian Marussi <cristian.marussi@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] firmware: Use of_property_present() for testing DT
 property presence
Message-ID: <20230404165846.GA49361-robh@kernel.org>
References: <20230310144704.1542045-1-robh@kernel.org>
 <20230323120030.7mk62xk7tco32zw2@bogus>
 <ZCwmWoZhMOlHnnzf@orome>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZCwmWoZhMOlHnnzf@orome>
Precedence: bulk

On Tue, Apr 04, 2023 at 03:30:02PM +0200, Thierry Reding wrote:
> On Thu, Mar 23, 2023 at 12:00:30PM +0000, Sudeep Holla wrote:
> > On Fri, Mar 10, 2023 at 08:47:04AM -0600, Rob Herring wrote:
> > > It is preferred to use typed property access functions (i.e.
> > > of_property_read_<type> functions) rather than low-level
> > > of_get_property/of_find_property functions for reading properties. As
> > > part of this, convert of_get_property/of_find_property calls to the
> > > recently added of_property_present() helper when we just want to test
> > > for presence of a property and nothing more.
> > > 
> > > Signed-off-by: Rob Herring <robh@kernel.org>
> > > ---
> > >  drivers/firmware/arm_scmi/optee.c | 2 +-
> > 
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>(for the SCMI part)
> > 
> > I am assuming you will route this as it has other changes as well in the
> > patch.
> 
> I can also pick this up along with the Tegra changes if Rob doesn't
> want to take it. But also feel free to take this through whatever tree
> works best, for the Tegra parts:
> 
> Acked-by: Thierry Reding <treding@nvidia.com>

You can take it. Thanks.

Rob