Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 4 Apr 2023 17:38:44 +0000
From:   Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
To:     Coly Li <colyli@suse.de>
Cc:     Kent Overstreet <kent.overstreet@gmail.com>,
        linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bcache: make kobj_type structures constant
Message-ID: <4cc38847-a967-487b-8efe-81b741ab6782@t-8ch.de>
References: <20230214-kobj_type-bcache-v1-1-cf00ead7bee7@weissschuh.net>
 <125CA8D6-D3B7-42FB-83BE-DCA688F2ACAF@suse.de>
 <20230214152119.epkfhkojqjvokqmv@t-8ch.de>
 <9DE71214-283C-4410-B5A4-22DFDA7021F4@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <9DE71214-283C-4410-B5A4-22DFDA7021F4@suse.de>
Precedence: bulk

Hi Coly,

On 2023-02-15 00:16:03+0800, Coly Li wrote:
> > 2023年2月14日 23:21，Thomas Weißschuh <linux@weissschuh.net> 写道：
> > 
> > On Tue, Feb 14, 2023 at 05:51:09PM +0800, Coly Li wrote:
> >> 
> >> 
> >>> 2023年2月14日 11:13，Thomas Weißschuh <linux@weissschuh.net> 写道：
> >>> 
> >>> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> >>> the driver core allows the usage of const struct kobj_type.
> >>> 
> >>> Take advantage of this to constify the structure definitions to prevent
> >>> modification at runtime.
> >>> 
> >> 
> >> How the const structure definition can prevent modification at run time?
> > 
> > It will be put into .rodata instead of .data by the compiler.
> > The .rodata section is mapped as read-only via the pagetable.
> > 
> > See Documentation/security/self-protection.rst
> > "Function pointers and sensitive variables must not be writable".
> 
> I see. Thanks for the information.
> 
> This patch will be added into my testing queue, and submitted later.

It seems this was not submitted.
Or did I miss it?

Thanks,
Thomas