Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fb1b1f30-cf9b-3044-d573-00a7e108d943@oracle.com>
Date:   Tue, 4 Apr 2023 22:54:53 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.1
Subject: Re: [PATCH next] ASoC: cs35l56: Fix unsigned 'rv' comparison with
 zero in cs35l56_irq()
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     error27@gmail.com, James Schulman <james.schulman@cirrus.com>,
        David Rhodes <david.rhodes@cirrus.com>,
        Lucas Tanure <tanureal@opensource.cirrus.com>,
        Richard Fitzgerald <rf@opensource.cirrus.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Simon Trimmer <simont@opensource.cirrus.com>,
        alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
        linux-kernel@vger.kernel.org
References: <20230323165825.1588629-1-harshit.m.mogalapalli@oracle.com>
 <f6e99383-4054-4f14-8cf6-8a9cdd792265@sirena.org.uk>
From:   Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <f6e99383-4054-4f14-8cf6-8a9cdd792265@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW1lS1dPRlB0N21FaXZTRlU0SjFtN0FkL2lnVWo3L2p0OW9UdnR2UVZKVmFN?=
 =?utf-8?B?Ty9uYkNMVERvb1M3SU0yczJlT3ZBNzNhKzRMRFErNWlpTlA1VUkwVks2OCtR?=
 =?utf-8?B?M3JLZjJhZzMwR2RJSEdIVnJmcWx1anRkWTdOVURlRWRDRWk5UzdBWU1WS2pn?=
 =?utf-8?B?MVZPWks4Ym5kWm5TQnpuTTk2enY4aCs5MGFHQlluMzl4NXhqTjMxbGZzUDBm?=
 =?utf-8?B?WHlFa2dFdUdCZ3hFbjNrN2V2R1paTDk5UXQ3NTg0Q2MvVmxVaHRDOWZJODlE?=
 =?utf-8?B?NXIvbmlBRVpKZDljdVc3TFVmTTFGdW5ZY1llcVNQWmM0T3FQM3o2KzQzcGRh?=
 =?utf-8?B?NG1GaXcwVGhpWk5XRkZmOW9HbzdBdDFUdXFJOVJXbUtoSThVVE9rRCt3YnhD?=
 =?utf-8?B?UWNnV2l3eFBkb2pnT3FOcmZSS1M1Z2daZk81dXBqVjFQZFEvT003am5kV24r?=
 =?utf-8?B?VWtoaSsvb0FwZVUyT0lUNXBPcUNEUkZQd1RwNkl6RUdjOFNnVVZvK0YxcEFV?=
 =?utf-8?B?SlYxdllkckszNzB6ZVBIUEFNc29OZFZQOFVXNDQremRsVjJVVmcza2I5dTdz?=
 =?utf-8?B?SHdiOTRIUXVlOERiaW5ycE94SkNhd2FZU1BjZDlWOXRPRkQvL1FDdmNjQjkx?=
 =?utf-8?B?OGFiVVpudkxBclZhZjIvdW9kR0hXd2tMTXpqQk1iUlZ3N2VqRXBwcWl1VHJz?=
 =?utf-8?B?b2JGNC9PRHBPQUFFejZPOERSSm4zVFFnTUNDNWdkdmlKbHhMT1EyT05idzJT?=
 =?utf-8?B?Rjc5bTRXcjlGaVNLOE5vYUZEUlh6VVllZXVWQXFrWXQ1VTloU1B3ZWtnYngr?=
 =?utf-8?B?K0V2dVJnbW0yV1BLWHVsb3pWaWsyRjNCVGhUdzBJcEZiZ0dJR0w0eTNvb2hR?=
 =?utf-8?B?QWZ6YmRIZUROdmErMXRkS1NvSkR2QXFIYnVRR2lvNEsxcEZUSVdsL0w3WlVF?=
 =?utf-8?B?NHJOejJvS2d6UXU1bjYzWmY1T2tTMGFab2JNQjJ6NWE1empBMFhMNU92cXZS?=
 =?utf-8?B?ckFYVU1wbFFnTFlibFlQLzlYYzhKYkI5WVN4aTE0RWpIOXFVMjNxbGRhVndN?=
 =?utf-8?B?d0tKdzZ6dTRiRWFHUEtSWWs1NUU0bDAyek5zQnpoOHM5QWc0VHdsN2V0Rnoy?=
 =?utf-8?B?RTBjanFnVkpDeE5oc0FrbDdWK250aHVQeHVIc21MdXJpdVhobUtzTDBLK29J?=
 =?utf-8?B?ZXdUamFYczUrZHB5OUx0Z3pFTXJTWVlaUTcxSjhHeFBsWWVpeVMxam44d3NS?=
 =?utf-8?B?ZEFoWTJkOGw3Wk1oMUVNdHdFaXFDbnpCSjlxUEgxVVZGRzhBR0VaVlRlOWRw?=
 =?utf-8?B?d09aS0cvWVh2dE1aemttUjY2OTNVaE9aeXQyQ0VJSzRHZXI0MkZjbGJZMmt2?=
 =?utf-8?B?TkFwN0d5bkFjaTlDanNiZW9jT05zSjlpbUxrZmhKdlZuZ2hjM1RJNlNyK1Q5?=
 =?utf-8?B?UzhUSTlhRTZyRXVwRDg4akVUbDZ3elNMZFJDZVljQ1BNTktDZGROczFEYUw1?=
 =?utf-8?B?T3VlTWU4QUd0ekRmd3hTY1lFdjJCNjdUaTJoem4vTTlYWTBuQTlLM3FBT1ho?=
 =?utf-8?B?ejRFNTU3TTVGQjVjYWhQWVpNL04zbkZvRW0vODJYTXVUNWlkeFROK3U1VW5I?=
 =?utf-8?B?UUxqWEFNTlZLU0xIcTQyUEVpZkYwTCtlL3lEM1VRQllJZkh2QTRyaFV5V1Zo?=
 =?utf-8?B?NVg4MUdpeDdzL3FXeXJYVm42N2VLSm9rdCt0WThEUmlZblhIYTZ4cHp5bTc3?=
 =?utf-8?B?a1Ric3MrOEpEbVFFNFdXTHlSTHNRWUo5MktKWUhUM1ZxRDI3SC9NbG11cXJx?=
 =?utf-8?B?MERENk9aZWQ2L092Y1ZTVTBZaWNyTVpkK3loajIvOVEyejFOaGdDN1dhdC9I?=
 =?utf-8?B?QWxJckQ2VmVKVHlFUkxsUk9EUWUvQWJtaTQyWWRVU3hlQU5jVjNnOG9aQVJq?=
 =?utf-8?B?NEhKekJ2UmVENnRzUG9MV1VZaGhGajJrS1NvTkl3bXZ6aFBOWGFiRDNobmdi?=
 =?utf-8?B?QTF4NWVvd2lwK0tjMVBmd1lQdmd6MnlnVUZNM0tnUExNVkdEOWUxMWpPL2Vo?=
 =?utf-8?B?cSthc0ViZXpOdW5IT0lPT244YlhiUUhKUVQ3M2Vsc2YrMkF1VkNwVWNQdUFF?=
 =?utf-8?B?UzVSUm1kdEwxRDgzc0JGVEplTGpma0FxcGc4bWg4cEQvOGJTQnU5SFBHbUFW?=
 =?utf-8?Q?8HwpwlY4+X13BleN2Noby+U=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?cVNrdkczcmgyRzJBOER4aWI1My9Nc2JGbE9WeGxKTjNtRzgyd0dQREV5UWE0?=
 =?utf-8?B?YTJNWUZIM1BFbEhGMGlRRUFwQkQ3R3M0TUxVREQ2bkR3M0Fqc2hVNndFQjFn?=
 =?utf-8?B?QWVISGtFNzk0T0M2ZFVhRVY3Qzd4cXYwZzlUUENobUMrdDYxd25EakgxaWx2?=
 =?utf-8?B?bTlIeStVT0RDeG5UNlNIazhXQ2c3N08zTmliQlhxUzBKUjVjZlVBU0Q5Q2NT?=
 =?utf-8?B?eE0rcDhVZm5zMjFlcmcvZUNTS0NpbE5ybWdEVmZPb3orNnllbHNTYTltR1VS?=
 =?utf-8?B?SHFXK1p5VXlaeXBZcjlVbng5dm9KSGFaY2N4WnJxZkloYjkyTEZZZVZxa0Zy?=
 =?utf-8?B?ZWl1WUNiWUdOSWNYYlc2V2YxaERvNW1QNjJZNHF1SW5GQlNmNkNDU2dUNWZP?=
 =?utf-8?B?dm5NWDIrZ0kyTU9pd3dxVGJxbWNYZlpEZkU5cmdKVjU1S0QzZ1JHVUg0cW1v?=
 =?utf-8?B?c3BKaWFPOC9xSkRnSVZhWmJVU3drdk9xdjhrK2tvL1prSTNqTEt2aGc4emF2?=
 =?utf-8?B?Nk5pTitOZEtrVFRnUHFUOWdQSmEyNEdjeDBuY1BnQ1JWa3UyZUlrM2NFdXlo?=
 =?utf-8?B?QWdLbDRSY2lqcVo3bmhIcmZUd0ozTGdlOWhNeE5uOHAvYVdZRHU3ejB6WmFZ?=
 =?utf-8?B?VlgyWnRLaDliTUp4RnlOM1pmaXdwOVFqQkU1bDYrTWVYR0s2WTBDMmRQK3d0?=
 =?utf-8?B?dkRUTUFzOHpvemphaUZpd3Q3UjNOUzVlYVd3N3pERkpyYzczR3pwVGJKRE5Q?=
 =?utf-8?B?Zkd4d2p0YUxUb045Nitka2NEalFoQ2ZEUCtORVlCWTdBRDN2UE9ydlFUOEpt?=
 =?utf-8?B?dDQxdnRxNDlMTVp5aDRMUlpuUnBhL016YjlrK0JRVXNuM0RPWUsyTkJMei9k?=
 =?utf-8?B?M0NJRVBtQUM0ZEtHUUU1MDBMbG4zY1hxWHBYZWlNV3JVZUFPZnc3QlkrNFZ6?=
 =?utf-8?B?elRGOExPb2thdUV2WlU2VjVGamtBc3ovVXpXbDlSOVovRmxncThFYzFnaitK?=
 =?utf-8?B?QXZzM1g1RjVjUnJZZnJ4a1FkZllqVE15RGY3UkFHbHNtQTBxY04rMGVvRElI?=
 =?utf-8?B?VzZWQWE1Y1FiRnVKSGxnamY2RXVUc1lUeU9tK0JtcXc3M3p4b0luYUh0RmpQ?=
 =?utf-8?B?Y1F4ZTZBdVZBTUxqWUFvMG1HQ3R4ZXhnL05YQ2VQcnROVDVNUy96aVp0UlFO?=
 =?utf-8?B?YUxyY3NqTEhsTmR5TTMxU3lsNGtZdlM0Q2dVZEkzUXgzRE9HdWZVeGp0cS9P?=
 =?utf-8?B?VjJXWkhXM2NCMXNRQXVFbkNabXdaV1dMdWhDRjBkL1dBZDRIeFBqNUw2VmFO?=
 =?utf-8?Q?iIREO5/6fAav7FaSh+dY7ZbBLonp/Et7+C?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e6c7d3e-650f-448d-c440-08db35318689
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 17:25:03.3001
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WAG6IKDl4vIjCzdMR7RDiTenvDChF1hX5XbOj1LtqjeRrWkqhsuhC5WzHA94mhdJr1iNSaXqqfqNmaP+7YOW97gohOf6VWpzQpfqNxZQAmJ+HIZnr6hELR6dUr18ZUTK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5347
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-04_08,2023-04-04_05,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=906 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304040161
X-Proofpoint-ORIG-GUID: COETNzdGpCqVg2jCV114p8Z7_Yzy2rHD
X-Proofpoint-GUID: COETNzdGpCqVg2jCV114p8Z7_Yzy2rHD
X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mark,

On 04/04/23 5:15 pm, Mark Brown wrote:
> On Thu, Mar 23, 2023 at 09:58:25AM -0700, Harshit Mogalapalli wrote:
>> 'rv' is of type unsigned int, which can never be less than zero.
> 
> This doesn't apply against current code, please check and resend.

The reason for the above is that someone else sent a patch next day 
fixing the same bug which got merged in linux-next.

Ref: 
https://lore.kernel.org/all/20230324022303.121485-1-jiapeng.chong@linux.alibaba.com/

So my patch will not apply and is not needed anymore.

Thanks,
Harshit