Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7843ed86-4cce-0621-55ce-1a996f8d3222@oracle.com>
Date:   Tue, 4 Apr 2023 14:33:36 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v2] sched/numa: Fix divide by zero for
 sysctl_numa_balancing_scan_size.
Content-Language: en-US
To:     Chen Yu <yu.c.chen@intel.com>
Cc:     linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
        peterz@infradead.org, vincent.guittot@linaro.org
References: <20230330150757.547423-1-chris.hyser@oracle.com>
 <ZCxDICwfUojWTGr5@chenyu5-mobl1>
From:   chris hyser <chris.hyser@oracle.com>
In-Reply-To: <ZCxDICwfUojWTGr5@chenyu5-mobl1>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rlorc3pwN0JZQStHM0FOTE9zb1NyajBYM0NwNVhsdVF1TEttdXFKQlNIZWpC?=
 =?utf-8?B?bVg3OHNwUzVadko5MStXTUkrS1h0ZTJxZG5SMHhyM1RNNDRtLzBGZUx6MmM2?=
 =?utf-8?B?T3E5ajRZbklpelZpbTdNWkpPbE9SM0Y2QmZyck0wQThaMTRmNlhvTlNkWVM4?=
 =?utf-8?B?VTh5SHBXVXpTUnIxaVAvWGdQTDh3TFJONWp5Rk81djREbVpET05JVStYZmVl?=
 =?utf-8?B?cVo3ZmJoZHEwbUoxMzBYS3g4VzFxSlVrSkREYjg5eXpMVmx6dnEwSkFJVVJw?=
 =?utf-8?B?RGdJbW1HYWM2Q2RZY0FVc3RONVovUmVRRkN3S3MyWHFWN3V3MlFVakxmQ1Jq?=
 =?utf-8?B?QkE4R1hwNS9sNlZ1S29EclZKUGRYaWFpMzdiWmNBcUZ1YTN5c0JCckVoL1Ra?=
 =?utf-8?B?anZoa2laVHhoeUVSc3NXUVN6MCtDTitHeFh2T3dDdDFoMjZZK2VCNmRGdEpv?=
 =?utf-8?B?cmdLNUlnRzZ1eHRRR1ZlWXhOOW1sNHB1VVNOMytMa0d1cVNDeUFyeFdvOXNM?=
 =?utf-8?B?cFZVNmxOR2dJZndNNVNFUnhmbVNlVmtzNHVRdlpjdUdES09aTGYyaEovcHBq?=
 =?utf-8?B?cDBLWXR3L1oyenNjb3JWdWN4RUg0eVNReWFkVmJmOWovL1RMRUhmM1FFQkV3?=
 =?utf-8?B?Y3RMNmdiVXNlV0xobFcxWHFkNzRENGl4cUlGOGJ4dlpIQjNOOWpvY3hXSDhY?=
 =?utf-8?B?b29oa3FrSkxlMG5UaE9aV3JwYzhQL3BmbWR1MjdCQWFGUDVvL0Rudm5EYWRo?=
 =?utf-8?B?R2l6ckZiQnpybjk4RVdNTlUzemlSRmc2V2VwdVJLK0pMVHkxeG92b2Z1SmMy?=
 =?utf-8?B?UVBwM0hjdjBRTFNpY2R6UUpiZlZ0cVNjV1REK3FKWHhTQnFzUHRET3RvOGV5?=
 =?utf-8?B?Y3lFK2c1RXY1SE0yYlhHUDIxYlFLUzNLNWhlSU9CRnV4SHcyd0xQN2dGci9I?=
 =?utf-8?B?ZW04elh3TFNrS09RM2Q2OFlyeUROSjlhMGVZY0dXbTFJVTBycldNb0RXMDhY?=
 =?utf-8?B?aCt0M1ZFcFhVbU9PdldVZ20yS1QyUTN2dzQ1dUpCRnBxVVU3ZzB0VEJqeDhM?=
 =?utf-8?B?SVB0SkNFbTA5OERONDJyYWhsVGp2M1RLd0lqUWppaFNDRmw5WTBXbDlWUVNI?=
 =?utf-8?B?d0trYTRzNFZyQVhjTG93L2Y3VjZUcjF4OTJtOFNrdCtRUGNoMWxBSUxIUVpB?=
 =?utf-8?B?REZqN1FjNklMMTlkZFVvbXpnZjd1REtOL1VBRGZSSVdYSjJxNEZaVWtVTEs4?=
 =?utf-8?B?YVV5NlVjZE9aRTV5N29jbGVhdGlMblRNTUg5NEpmbFVxc0dmMzdKSDU2SDdN?=
 =?utf-8?B?MkR6Ri9La3VlUUx5MUJNeVYwTUMzME9SYndkeWNPNU5nUmJHa2E3YytQQldP?=
 =?utf-8?B?WVdXOFpFb0Y4aTNqZWUyTFR1QXNGNVZ4SHZGbW4zL2doNUVwRWJTYzR2a0Z3?=
 =?utf-8?B?ZjhObjJtcndCbHo5bEp6a0hsTVZ3dEJYSC9vWUs4YVNrZGFZN2J6NkdrLzhC?=
 =?utf-8?B?dmNzYjVmc0NtblZJYWNINFN1czJlVjhLVmx1c1kyOVMyMXQzWFdtVHNSZkNR?=
 =?utf-8?B?Smw0TnFhcXdYS1AwQTMvaExRcGRUTmp0eGpGZFF5VXROVStXODdmWDYreFR6?=
 =?utf-8?B?czd0Y2hMb2FwS0hmUmpScWtHaGRpQ08yZ3ZoWkpNbmRmS3pTV1Q4MUtTQ2Z1?=
 =?utf-8?B?WFVJZ0xtMC9SekpnZXJ1WmVrWitWejhpTkNDUFlJQ0hyakFPWTdqTFRLbUJu?=
 =?utf-8?B?TldrRUszYk5qcnRSTVVpcVFTRW42endoRnA2bGxKZWY1dHB0ZVJTa0RsYUNK?=
 =?utf-8?B?NmFUOHhnWlNNRTNVWFpyRjBSaEN0YVhnbGhWMDNFb2pMYmkyanZjQ0xPdXVT?=
 =?utf-8?B?eUNhVEJ4VHlVOUkzSDNZNjhVcmI0WFB5Y1N2eUpvV0RTTzBNdUEwb1JHaWpM?=
 =?utf-8?B?VWFkNEc1NnA5RGg4b0lBYXIvcWJWeFYyZy85OVZsY3RVMlVQR09Vd2VaT0E1?=
 =?utf-8?B?cCtmRGlRNTl4RWc0WGZwdnArc015ZVA5K1hJaEphUHphV0Y0QjFjR21aVUZw?=
 =?utf-8?B?K3UwazRVbFU2QlBpZElma093N3VlTmRnV1J4bkxFcHU0bjgrZGEwMzc1bHla?=
 =?utf-8?B?d0o5TUVzWk9tRzJBNDNUWDFXcklHcHltNk1IVWtYQkRIMk1VejJhZUZwRjZ3?=
 =?utf-8?B?bGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 1dzlvtLynfcy16VJRcquvk73vPEDtCBwwLGSrOBboeKL1IBUlehFKzOOnL628u0QCXDNaOyiY3ZglSZq8dms04GYCZ1/J6ZDp4oE1w4oLcu+Sy4jHFL8y4uwRynUhFj5KJVR++kXCntG0+UNveiBQD35j0W+IX9e5GoXnAIAe9LipXgWEdO96ChISJKBTaVKEojm9KiHyBgSAAw8FmPKwz6zOB+XfHySy/MyUJZKYjw4v3Rekiy0t54+86yNRAbgXCtXEqJZ5qDO8HdX5Gf33e+FX7kFCkxnKQFcmz/SpaKRFe9qSbMX2K9kO26cbv2mhgwXz/rvIXZuh7fGUm/1zTVo9flF5PenqO1ZJBdn5pMXDN1EC2roOdwgYdW5OMqo908PjmhPCH/mX7KG6B2qa4DLQVcg+rFwVvlyl2K1d9QhfJwcPq9Ehz6ma+geZwvWPTEPcGnfd/SzyouPuMnB6cPfJ6viPNsKhMmc8gIblPV89HB7C8eCnVkD7UVlBkhzldp4rmL2SqitQjlifa0QdesYoddgpIRZ6C/H1QdEQOIHHyKPbVkieHSTf5V+f/XElot65bRJWRv02TMvuxZYVo2sSe3LeDXCiyRFDVKT7sh6gdRrj9iJcouayzdiAtBA692yEV6ymwP0V7gL7FkKrI+l442n+3sZR7R7zOs1CZwFsv1zZRP0q9cx1hzA2nnu4xMYnp5wdgqjDtXPoQhNi3EL4xX1N/5zSGVwZ/4JLIcgU68vc3rqh81pYCVWEzpHQhjQqp9VzUkObeHueJzW7YS6EynkiVPTx0zZ0c44BOh+jz8XKjx9C2qfJKxATj/euiHxXq0Vsw2Dm9HUnvPQ/sEmx+fOksEwi5TsD/F+i3TzjHHRn/iWYNRcBZP/VcuL
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f9d668a-c561-46cc-c739-08db353b20c7
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4705.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2023 18:33:47.6091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /5uEmFhRYkjs1RCkMUEFPJ8jchsLNqEnLlsKd27XfPf4YS3h9O1DDH3SF2EvWXFxXBXDNuxDcZ5RvFGDIuuU9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5157
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
 definitions=2023-04-04_10,2023-04-04_05,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 spamscore=0
 malwarescore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2303200000 definitions=main-2304040168
X-Proofpoint-ORIG-GUID: 5YGJzQE84cji9gL2fkwdqfgvbkWzPnrF
X-Proofpoint-GUID: 5YGJzQE84cji9gL2fkwdqfgvbkWzPnrF
X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/4/23 11:32, Chen Yu wrote:
> On 2023-03-30 at 11:07:57 -0400, chris hyser wrote:
>> Commit 6419265899d9 ("sched/fair: Fix division by zero
>> sysctl_numa_balancing_scan_size") prevented a divide by zero by using
>> sysctl mechanisms to return EINVAL for a sysctl_numa_balancing_scan_size
>> value of zero. When moved from a sysctl to a debugfs file, this checking
>> was lost.
>>
>> This patch puts zero checking back in place.
>>
>> Signed-off-by: Chris Hyser <chris.hyser@oracle.com>
>> ---
>>   kernel/sched/debug.c | 52 +++++++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 51 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
>> index 1637b65ba07a..b5fc7e250128 100644
>> --- a/kernel/sched/debug.c
>> +++ b/kernel/sched/debug.c
>> @@ -278,6 +278,56 @@ static const struct file_operations sched_dynamic_fops = {
>>   
>>   #endif /* CONFIG_PREEMPT_DYNAMIC */
>>   
>> +#ifdef CONFIG_NUMA_BALANCING
>> +
>> +static ssize_t sched_numa_scan_write(struct file *filp, const char __user *ubuf,
>> +				     size_t cnt, loff_t *ppos)
>> +{
>> +	int err;
>> +	char buf[16];
>> +	unsigned int scan_size;
>> +
>> +	if (cnt > 15)
>> +		cnt = 15;
>> +
>> +	if (copy_from_user(&buf, ubuf, cnt))
>> +		return -EFAULT;
>> +	buf[cnt] = '\0';
>> +
>> +	err = kstrtouint(buf, 10, &scan_size);
> While testing the code, it is found that there is a
> kstrtouint_from_user() could do the above. Not sure
> if it is worthy to use that?

Yes, putting this in results in cleaner code. Thanks.

I just sent a v3 with this change.

-chrish

> 
> thanks,
> Chenyu