Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6406369rwl; Tue, 4 Apr 2023 12:11:02 -0700 (PDT) X-Google-Smtp-Source: AKy350ag5gCz5+8BvT4k2ETA6m8V5P78VvW5txBnQTKOigulyTXJCMKnylzSHxDaxOGujtMGfT/b X-Received: by 2002:a62:1b0b:0:b0:62a:1267:2045 with SMTP id b11-20020a621b0b000000b0062a12672045mr2916249pfb.34.1680635461680; Tue, 04 Apr 2023 12:11:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680635461; cv=none; d=google.com; s=arc-20160816; b=U3RqkYnyTCNixQ+v0F86LF8KPZ12wYzn4Sng7490uCnfqkWXlQvceiQVJYpj5vZAcy mUSpBOwD6lZsbzSWhVU1XLiDT6V8dys/CkGBlcYCt/3kP1R+7I3Vz8KaA1O403ZJcv7B TsLl8GWmwSFjZElP3Ou/FFJJykUt6UL6qtkRctaXY7IncrjEe/k7RFAg12HiPEIcRmYx tVSjme2XVzj1pxWDx3DjefdjLUwi63bnxROfXbHYmxhIgqdjAewE2tl+NhFok9Cpu173 zf2JwRef//v37q1aVogNcoJOL8+Y/soLkeX3NGCJyWzXZEDDG4NGeycBrnb3vYJvTvIm MynA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version :dkim-signature; bh=lAB1BIOMY8BqcqgSGd6f7EUawi5jlbHQsRXoh9cOqk4=; b=BJKX+ogPNgU3cpM9rAnsYVR9GhaQnlLn8tBKk8cnjleK1pdo4iSpDEKUqh2Ogn5DRZ 2ZKCdJZy79K/M3yANcCHJJCBtHMbX2hdxZWWo8PjlI4dds4mIuY72tvI/gETl0jIO4ba aYso2MNly9sOhOlZhn+hH/UdaITSMrjhNZr9v4I3VBj6hEzjqufaN5AfOSBgYtezYjQN 2R3FYBRR5z/WA3KXlcTeC4vGc6k/222sNtRFhXXLRauYqgZ8yzUu00Rf9qaZESNUTb7G ST4f5y/d/QyYzii+EX6yZMKhbXllHIWfofG1CL/+PNwZbmqMymmmgoLw4PUqYO1X28K2 bFKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=mlpikNcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z15-20020a63d00f000000b0051393805ccesi11044764pgf.418.2023.04.04.12.10.50; Tue, 04 Apr 2023 12:11:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2022082101 header.b=mlpikNcY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=walle.cc Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235594AbjDDTJk (ORCPT + 99 others); Tue, 4 Apr 2023 15:09:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235427AbjDDTJi (ORCPT ); Tue, 4 Apr 2023 15:09:38 -0400 Received: from mail.3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9013268B for ; Tue, 4 Apr 2023 12:09:35 -0700 (PDT) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id BABCA124; Tue, 4 Apr 2023 21:09:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1680635372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lAB1BIOMY8BqcqgSGd6f7EUawi5jlbHQsRXoh9cOqk4=; b=mlpikNcY/mXReznB/BB0wm3JmwuaoXRGtacbJf89BNnuCCuE4R8qA0y2OXhZ+ocynwSMFs +Ra37Ednu8v8UEajd+zHCHX/rn7aCKEARtfs5/sFjJ0wCfpkH0PzDN0CASgwLGr381/uqy wTerxog+0ZBF4HUwjKDYVBJjpYb7jmJo8O67UT8HY/oB/uDgiVHaoD/s/OnqopLKZOHWIv kjfF4btOGkNc54PM/vSFiD00Tac+atgEVDdmMUWIF/9IwGi3jFi/EXybAXzm4PydD6cF7T cBaigX0tm+ILj2wMDrg72dx598U9aVpncjetwGJ4hsceFHtz0XrCT7RUbEPelg== MIME-Version: 1.0 Date: Tue, 04 Apr 2023 21:09:32 +0200 From: Michael Walle To: Tom Rix Cc: srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to static In-Reply-To: <20230404163629.1923871-1-trix@redhat.com> References: <20230404163629.1923871-1-trix@redhat.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 2023-04-04 18:36, schrieb Tom Rix: > smatch reports > drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol > 'sl28vpd_layout' was not declared. Should it be static? > > This variable is only used in one file so it should be static. > > Signed-off-by: Tom Rix Fixes tag? Reviewed-by: Michael Walle -michael