Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230301142835.19614-1-m.zatovic1@gmail.com> <20230301142835.19614-3-m.zatovic1@gmail.com>
 <Y/98GqIPgMyPLRi3@smile.fi.intel.com> <ZCwifu6yxUikt42i@fedora>
In-Reply-To: <ZCwifu6yxUikt42i@fedora>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Tue, 4 Apr 2023 22:30:59 +0200
Message-ID: <CACRpkdYyGjTMCJvAHWa=GE7i1qb98+7zDeK-28-Ko+1B2U8-mw@mail.gmail.com>
Subject: Re: [PATCHv3 2/4] wiegand: add Wiegand bus driver
To:     =?UTF-8?B?TWFydGluIFphxaVvdmnEjQ==?= <m.zatovic1@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org,
        airlied@redhat.com, dipenp@nvidia.com, treding@nvidia.com,
        mwen@igalia.com, fmdefrancesco@gmail.com, arnd@arndb.de,
        bvanassche@acm.org, ogabbay@kernel.org, axboe@kernel.dk,
        mathieu.poirier@linaro.org, linux@zary.sk, masahiroy@kernel.org,
        yangyicong@hisilicon.com, dan.j.williams@intel.com,
        jacek.lawrynowicz@linux.intel.com, benjamin.tissoires@redhat.com,
        devicetree@vger.kernel.org, furong.zhou@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Apr 4, 2023 at 3:13=E2=80=AFPM Martin Za=C5=A5ovi=C4=8D <m.zatovic1=
@gmail.com> wrote:
> On Wed, Mar 01, 2023 at 06:23:54PM +0200, Andy Shevchenko wrote:

> > > +/**
> > > + * of_register_wiegand_device - allocates and registers a new Wiegan=
d device based on devicetree
> >
> > NAK for OF only code. New, esp. bus, code must be agnostic. We have all=
 means
> > for that.
>
> In one of the previous versions of this patch series, there was also the =
possibility to instantiate
> the device from another driver. I have been told, that this is not the wa=
y to go anymore, unless
> there is a very specific reason for that. I did not find such reason, so =
I have removed this suport.

I don't know for sure but I think Andy simply means that you should take a =
look
in include/linux/property.h and replace every function named of_* with
the corresponding fwnode_* or device_* function from that file, and it
should all just magically work the same, but abstracted away from device
tree. It's not much more than a search/replace and rename operation
(unless there is a "hole" in the fwnode implementations... I hope not.)

In the end you can keep just <linux/property.h> and drop <linux/of.h>
and <linux/of_device.h> if this works.

Yours,
Linus Walleij