Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230403120451.31041-1-kal.conley@dectris.com>
In-Reply-To: <20230403120451.31041-1-kal.conley@dectris.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Tue, 4 Apr 2023 16:11:15 -0700
Message-ID: <CAEf4BzYO0fsyUsLHe0t9yuw+BWaBJrvGBgBw213BpLNif=SOTw@mail.gmail.com>
Subject: Re: [PATCH bpf] selftests: xsk: Disable IPv6 on VETH1
To:     Kal Conley <kal.conley@dectris.com>
Cc:     =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Maciej Fijalkowski <maciej.fijalkowski@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
        Weqaar Janjua <weqaar.janjua@gmail.com>,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Apr 3, 2023 at 5:05=E2=80=AFAM Kal Conley <kal.conley@dectris.com> =
wrote:
>
> This change fixes flakiness in the BIDIRECTIONAL test:
>
>     # [is_pkt_valid] expected length [60], got length [90]
>     not ok 1 FAIL: SKB BUSY-POLL BIDIRECTIONAL
>
> When IPv6 is enabled, the interface will periodically send MLDv1 and
> MLDv2 packets. These packets can cause the BIDIRECTIONAL test to fail
> since it uses VETH0 for RX.
>
> For other tests, this was not a problem since they only receive on VETH1
> and IPv6 was already disabled on VETH0.
>
> Fixes: a89052572ebb ("selftests/bpf: Xsk selftests framework")
> Signed-off-by: Kal Conley <kal.conley@dectris.com>
> ---

Can you please resubmit with [PATCH bpf-next] tag, so BPF CI can test
it against the bpf-next tree. Thanks.

>  tools/testing/selftests/bpf/test_xsk.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/test_xsk.sh b/tools/testing/self=
tests/bpf/test_xsk.sh
> index b077cf58f825..377fb157a57c 100755
> --- a/tools/testing/selftests/bpf/test_xsk.sh
> +++ b/tools/testing/selftests/bpf/test_xsk.sh
> @@ -116,6 +116,7 @@ setup_vethPairs() {
>         ip link add ${VETH0} numtxqueues 4 numrxqueues 4 type veth peer n=
ame ${VETH1} numtxqueues 4 numrxqueues 4
>         if [ -f /proc/net/if_inet6 ]; then
>                 echo 1 > /proc/sys/net/ipv6/conf/${VETH0}/disable_ipv6
> +               echo 1 > /proc/sys/net/ipv6/conf/${VETH1}/disable_ipv6
>         fi
>         if [[ $verbose -eq 1 ]]; then
>                 echo "setting up ${VETH1}"
> --
> 2.39.2
>