Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 11:48:07 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     Bastien Nocera <hadess@hadess.net>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the hid tree
Message-ID: <20230405114807.5a57bf46@canb.auug.org.au>
In-Reply-To: <366ab6c4d488645aee5cbf49fb2e9b39d9bb1e22.camel@hadess.net>
References: <20230404154005.449800c3@canb.auug.org.au>
        <20230404154254.6c3be26b@canb.auug.org.au>
        <e1eb90db85ed7adad08bb99054f5cda3cb626794.camel@hadess.net>
        <20230404185500.7953d9d2@canb.auug.org.au>
        <366ab6c4d488645aee5cbf49fb2e9b39d9bb1e22.camel@hadess.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/NTmVx3rhRGf2PCqGL/9kBmg";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/NTmVx3rhRGf2PCqGL/9kBmg
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Bastien,

On Tue, 04 Apr 2023 11:18:35 +0200 Bastien Nocera <hadess@hadess.net> wrote:
>
> Before I send patches, does this look correct to you?
>=20
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index 7930dca84616..7c7f88ca4f62 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1926,7 +1926,7 @@ static void __usb_wireless_status_intf(struct work_=
struct *ws)
> 1926=E2=8B=AE1926=E2=94=82=20
> 1927=E2=8B=AE1927=E2=94=82 /**
> 1928=E2=8B=AE1928=E2=94=82  * usb_set_wireless_status - sets the wireless=
_status struct member
> 1929=E2=8B=AE    =E2=94=82- * @dev: the device to modify
>     =E2=8B=AE1929=E2=94=82+ * @iface: the interface to modify
> 1930=E2=8B=AE1930=E2=94=82  * @status: the new wireless status
> 1931=E2=8B=AE1931=E2=94=82  *
> 1932=E2=8B=AE1932=E2=94=82  * Set the wireless_status struct member to th=
e new value, and emit

That looks good.

> diff --git a/include/linux/usb.h b/include/linux/usb.h
> index a48eeec62a66..3d523ebf0c09 100644
> --- a/include/linux/usb.h
> +++ b/include/linux/usb.h
> @@ -261,7 +261,8 @@ struct usb_interface {
>  261=E2=8B=AE 261=E2=94=82      unsigned needs_binding:1;       /* needs =
delayed unbind/rebind */
>  262=E2=8B=AE 262=E2=94=82      unsigned resetting_device:1;    /* true: =
bandwidth alloc after reset */
>  263=E2=8B=AE 263=E2=94=82      unsigned authorized:1;          /* used f=
or interface authorization */
>  264=E2=8B=AE    =E2=94=82-     enum usb_wireless_status wireless_status;
>     =E2=8B=AE 264=E2=94=82+     enum usb_wireless_status wireless_status;=
 /* whether the emitter is
>     =E2=8B=AE 265=E2=94=82+                                              =
  * connected to this receiver */
>  265=E2=8B=AE 266=E2=94=82      struct work_struct wireless_status_work;
>  266=E2=8B=AE 267=E2=94=82=20
>  267=E2=8B=AE 268=E2=94=82      struct device dev;              /* interf=
ace specific device info */
>=20

This is not right, though.  The warning was about
"wireless_status_work" not "wireless_status", so I think you need a
description of wireless_status_work in the block comment above the
struct definition.

--=20
Cheers,
Stephen Rothwell

--Sig_/NTmVx3rhRGf2PCqGL/9kBmg
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmQs01cACgkQAVBC80lX
0Gy4gAgAm8jakAMnjG8YvTuuQ5jMmRVMy29Vlqg5yNQK4+OAFV6NXaNuPb2pdKK9
7a04gaR/prutPTyjjZVvn57dLDEYrN1bk4e0dkZorUkQwb6dM6BtqSStsudRBndk
/ZfuGXxEG6N3k+8NKH8mvsN2+7JoLYSyHB3kADOgr6XwslGbhW7B1vZ7u1Fj1Wr8
An6ExY31g4lwdv8PzuWyUpu8nqD7eBQuNFIwHkCgFiFt5n9JoO70oFbNkn3cyipI
3zuHvaHQ9F+pZUCbqIKV5/aWIBJmbvKR/4dBokNEuTu/W/Z6uR+S7rOsb7infiuI
oPXy/vQyrmEcu788yNVrvLiadHg17g==
=TfKY
-----END PGP SIGNATURE-----

--Sig_/NTmVx3rhRGf2PCqGL/9kBmg--