Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b189f02-27b3-d885-aaf2-98eb2077d479@ti.com>
Date:   Wed, 5 Apr 2023 09:46:07 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] cpufreq: amd-pstate: set varaiable mode_state_machine
 storage-class-specifier to static
Content-Language: en-US
To:     Tom Rix <trix@redhat.com>, <ray.huang@amd.com>,
        <rafael@kernel.org>, <viresh.kumar@linaro.org>
CC:     <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230404003337.1912901-1-trix@redhat.com>
From:   Dhruva Gole <d-gole@ti.com>
In-Reply-To: <20230404003337.1912901-1-trix@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 04/04/23 06:03, Tom Rix wrote:
> smatch reports
> drivers/cpufreq/amd-pstate.c:907:25: warning: symbol
>    'mode_state_machine' was not declared. Should it be static?
> 
> This variable is only used in one file so it should be static.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---

You might want to use the Fixes: commit ("")
tag? It will help people to pick the patch while
back-porting fixes to older kernels.'

For example:
https://lore.kernel.org/all/20230403072443.83810-2-d-gole@ti.com/

Fixes: 0651a730924b ("gpio: davinci: Add support for system 
suspend/resume PM")

Otherwise,

Reviewed-by: Dhruva Gole <d-gole@ti.com>

>   drivers/cpufreq/amd-pstate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 6f4b8040d46c..5a3d4aa0f45a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -904,7 +904,7 @@ static int amd_pstate_change_driver_mode(int mode)
>   	return 0;
>   }
>   
> -cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
> +static cppc_mode_transition_fn mode_state_machine[AMD_PSTATE_MAX][AMD_PSTATE_MAX] = {
>   	[AMD_PSTATE_DISABLE]         = {
>   		[AMD_PSTATE_DISABLE]     = NULL,
>   		[AMD_PSTATE_PASSIVE]     = amd_pstate_register_driver,

-- 
Thanks and Regards,
Dhruva Gole