Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 09:22:20 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc:     mathias.nyman@intel.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: xhci-plat: Use dev_is_pci() helper
Message-ID: <2023040503-catatonic-gazing-9830@gregkh>
References: <20230405070141.2028455-1-nobuhiro1.iwamatsu@toshiba.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230405070141.2028455-1-nobuhiro1.iwamatsu@toshiba.co.jp>
Precedence: bulk

On Wed, Apr 05, 2023 at 04:01:41PM +0900, Nobuhiro Iwamatsu wrote:
> Use common dev_is_pci() helper for checking PCI devices.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
> ---
>  drivers/usb/host/xhci-plat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index b9f9625467d61e..2c95189424fa6e 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -363,7 +363,7 @@ static int xhci_generic_plat_probe(struct platform_device *pdev)
>  			is_acpi_device_node(sysdev->fwnode))
>  			break;
>  #ifdef CONFIG_PCI
> -		else if (sysdev->bus == &pci_bus_type)
> +		else if (dev_is_pci(sysdev))

With that change, you can also get rid of the #ifdef lines too, right?

thanks,

greg k-h