Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 10:22:56 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     David Dai <davidai@google.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Saravana Kannan <saravanak@google.com>,
        kernel-team@android.com, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org
Subject: Re: [RFC PATCH 6/6] cpufreq: add kvm-cpufreq driver
Message-ID: <20230405082256.GY4253@hirez.programming.kicks-ass.net>
References: <20230330224348.1006691-1-davidai@google.com>
 <20230330224348.1006691-7-davidai@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230330224348.1006691-7-davidai@google.com>
Precedence: bulk

On Thu, Mar 30, 2023 at 03:43:41PM -0700, David Dai wrote:

> +struct remote_data {
> +	int ret;
> +	struct cpufreq_frequency_table *table;
> +};
> +
> +static void remote_get_freqtbl_num_entries(void *data)
> +{
> +	struct arm_smccc_res hvc_res;
> +	u32 freq = 1UL;
> +	int *idx = data;
> +
> +	while (freq != CPUFREQ_TABLE_END) {
> +		arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_GET_CPUFREQ_TBL_FUNC_ID,
> +				*idx, &hvc_res);
> +		if (hvc_res.a0) {
> +			*idx = -ENODEV;
> +			return;
> +		}
> +		freq = hvc_res.a1;
> +		(*idx)++;
> +	}
> +}
> +
> +static int kvm_cpufreq_get_freqtbl_num_entries(int cpu)
> +{
> +	int num_entries = 0;
> +
> +	smp_call_function_single(cpu, remote_get_freqtbl_num_entries, &num_entries, true);
> +	return num_entries;
> +}
> +
> +static void remote_populate_freqtbl(void *data)
> +{
> +	struct arm_smccc_res hvc_res;
> +	struct remote_data *freq_data = data;
> +	struct cpufreq_frequency_table *pos;
> +	struct cpufreq_frequency_table *table = freq_data->table;
> +	int idx;
> +
> +	cpufreq_for_each_entry_idx(pos, table, idx) {
> +		arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_GET_CPUFREQ_TBL_FUNC_ID,
> +				idx, &hvc_res);
> +		if (hvc_res.a0) {
> +			freq_data->ret = -ENODEV;
> +			return;
> +		}
> +		pos->frequency = hvc_res.a1;
> +	}
> +	freq_data->ret = 0;
> +}
> +
> +static int kvm_cpufreq_populate_freqtbl(struct cpufreq_frequency_table	*table, int cpu)
> +{
> +	struct remote_data freq_data;
> +
> +	freq_data.table = table;
> +	smp_call_function_single(cpu, remote_populate_freqtbl, &freq_data, true);
> +	return freq_data.ret;
> +}

*WHY* are you sending IPIs to do a hypercall ?!?

You can simply have the hypercall tell what vCPU you're doing this for.