Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp426655rwl; Wed, 5 Apr 2023 02:46:16 -0700 (PDT) X-Google-Smtp-Source: AKy350Ya5xWHu9DnnrNFJsokpbEB18R0DiISCS1HIco4LDeLOfO5E4hOX3PE4F7pfflry8DlRsON X-Received: by 2002:a17:906:b199:b0:92f:b8d0:746c with SMTP id w25-20020a170906b19900b0092fb8d0746cmr2417535ejy.20.1680687976077; Wed, 05 Apr 2023 02:46:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680687976; cv=none; d=google.com; s=arc-20160816; b=xf9kOjMYIfqybYi+a1kJTzT1ikkvEwZ0xrj4MRAVLGES3CgFHWBupdPBLNYHTJBs8y 9EcOg04qHmaZlj0Xn3qhBgoOzjNyolZW6EM1nj+3aDxKXYF2Z7oMvkac0VNNH3HEKaFQ /XC4LsS0LuI3Ual+xjy21iUaDEApGi2R7oU6Q9vAk87qSEq5DYjlxzBMX4cYU9VXiSzV Ymr8Y4VBnJIRKvIyGD1FPRxlrVPE+oGJv/Y1Cn5o/XeAzwbHqZ8KD8uAgKoSPPNkZclo Mi1yv18Uji9GztzaSSQ6NCnCvy2TFZC49DXHi5NEricgMAS04jLU3QpwRxf4bbR/7Wi9 YvWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ryjKh+5i3d8qTj1qTZolU5NHivBCWbXwY8RVlECIZlE=; b=tYRrBK++DmJlL2Q7+h9i0Wyd8QdL8DcARFtV2s+V845Sd0uq+K12abDV+y+1x22Og9 as88rQpode3RfqBCb3bZjWH9IZccyrssBvpLmfJJqphLF0zj/xZ0c8TZzzk/oGB2oofT v8NtezbbvTDmkE1ni1iah0t+WmPhMDyga7jYy8gmRXja37jItRlUByPy+Qi5ur+p5sik ceyYzWYYSNCG0UmmfTLvyxUhuOpXs366KI0S+EyL9Oxy+JnPtD8SAnqmi0RkLhp9TNYM 68xvDnq54Dc8S3AqPOD8ce7/kjN/cjRrSAVsLl3Kr1NMSjyxdkot4lwz6N7ZPwqhK/Gt uCNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc43-20020a17090716ab00b0091452fdf543si9814950ejc.810.2023.04.05.02.45.52; Wed, 05 Apr 2023 02:46:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237461AbjDEJn6 (ORCPT + 99 others); Wed, 5 Apr 2023 05:43:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237319AbjDEJn5 (ORCPT ); Wed, 5 Apr 2023 05:43:57 -0400 Received: from sym2.noone.org (sym.noone.org [178.63.92.236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E83F171B; Wed, 5 Apr 2023 02:43:52 -0700 (PDT) Received: by sym2.noone.org (Postfix, from userid 1002) id 4Ps07n5hbBzvjfm; Wed, 5 Apr 2023 11:43:49 +0200 (CEST) Date: Wed, 5 Apr 2023 11:43:49 +0200 From: Tobias Klauser To: Christian Brauner Cc: Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests/clone3: fix number of tests in ksft_set_plan Message-ID: <20230405094349.7fkipggxdmrnn2mo@distanz.ch> References: <20230314115352.20623-1-tklauser@distanz.ch> <20230314123414.26907-1-tklauser@distanz.ch> <20230314130959.7gfuagxta6k423kf@wittgenstein> <20230403205735.ltb3pmh5yl2pjzhu@distanz.ch> <20230404-wasting-finicky-6f8876022a24@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230404-wasting-finicky-6f8876022a24@brauner> User-Agent: NeoMutt/20170113 (1.7.2) X-Spam-Status: No, score=0.3 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023-04-05 at 09:46:11 +0200, Christian Brauner wrote: > On Mon, Apr 03, 2023 at 10:57:37PM +0200, Tobias Klauser wrote: > > On 2023-03-14 at 14:09:59 +0100, Christian Brauner wrote: > > > On Tue, Mar 14, 2023 at 01:34:14PM +0100, Tobias Klauser wrote: > > > > Commit 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME") > > > > added an additional test, so the number passed to ksft_set_plan needs to > > > > be bumped accordingly. > > > > > > > > Also use ksft_finished() to print results and exit. This will catch future > > > > mismatches between ksft_set_plan() and the number of tests being run. > > > > > > > > Fixes: 515bddf0ec41 ("selftests/clone3: test clone3 with CLONE_NEWTIME") > > > > Cc: Christian Brauner > > > > Signed-off-by: Tobias Klauser > > > > --- > > > > > > Looks good. Thanks for fixing this, > > > Reviewed-by: Christian Brauner > > > > > > Feel free to take this through the selftests tree, Shuah. > > > > It looks like this hasn't made it into Linus' tree yet and I also don't > > see it in Shuah's tree. Would it be possible to still submit this for > > 6.3-rc6 given the commit it fixes has made it to Linus' tree already? > > Is it in linux-next? No, doesn't look like it (I checked on tags/next-20230405).