Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230301085545.2373646-1-chenhuacai@loongson.cn>
 <aba37b65-6fc4-721e-ebc5-df52533e4791@loongson.cn> <CAAhV-H6xAKQ94T5=+iVASwi8F=7+G_ptSGVVBOw4L1fCR+EQOw@mail.gmail.com>
 <dfd6a1cb-25be-cc11-4134-b2e92e353c00@loongson.cn> <CAAhV-H4q2+s2fV6DqSK8H0cByvJsd78GBB_Vw9gxHMfBu2Scug@mail.gmail.com>
 <CAAhV-H54MWEXgqPqv+23vQxQU455iMnwON37uiByyci9cgh5Hg@mail.gmail.com> <CAMj1kXEe37g=1DEQcWFEDCLRihZLX14Kso0dwon71W+5jqyDrA@mail.gmail.com>
In-Reply-To: <CAMj1kXEe37g=1DEQcWFEDCLRihZLX14Kso0dwon71W+5jqyDrA@mail.gmail.com>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Wed, 5 Apr 2023 17:57:34 +0800
Message-ID: <CAAhV-H7XMWKOQhfh5z5s79oJ_RDCfa5VSEs2m=9thq1GFL=WzA@mail.gmail.com>
Subject: Re: [PATCH] efi/loongarch: Reintroduce efi_relocate_kernel() to
 relocate kernel
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Youling Tang <tangyouling@loongson.cn>,
        Huacai Chen <chenhuacai@loongson.cn>,
        linux-efi@vger.kernel.org, loongarch@lists.linux.dev,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Xuerui Wang <kernel@xen0n.name>, linux-kernel@vger.kernel.org,
        loongson-kernel@lists.loongnix.cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Ard,

On Wed, Apr 5, 2023 at 4:20=E2=80=AFPM Ard Biesheuvel <ardb@kernel.org> wro=
te:
>
> On Wed, 5 Apr 2023 at 10:14, Huacai Chen <chenhuacai@kernel.org> wrote:
> >
> > Hi, Ard,
> >
> > What is the status of this patch now?
> >
>
> I'd still like to understand how zboot is affected. It has
>
> static unsigned long alloc_preferred_address(unsigned long alloc_size)
> {
> #ifdef EFI_KIMG_PREFERRED_ADDRESS
>         efi_physical_addr_t efi_addr =3D EFI_KIMG_PREFERRED_ADDRESS;
>
>         if (efi_bs_call(allocate_pages, EFI_ALLOCATE_ADDRESS, EFI_LOADER_=
DATA,
>                         alloc_size / EFI_PAGE_SIZE, &efi_addr) =3D=3D EFI=
_SUCCESS)
>                 return efi_addr;
> #endif
>         return ULONG_MAX;
> }
>
> and if I understand you correctly, we never needed this in the first plac=
e?
Technically we don't need this, but I think setting a preferred
address as before may be better (keeping the default behavior the same
as before can avoid some unexpected problem).

Huacai
>
> (I understand this is a separate issue, but it would be nice to get
> rid of EFI_KIMG_PREFERRED_ADDRESS entirely if we can.)
>
>
>
> > On Wed, Mar 1, 2023 at 8:06=E2=80=AFPM Huacai Chen <chenhuacai@kernel.o=
rg> wrote:
> > >
> > > Hi, Youling,
> > >
> > > On Wed, Mar 1, 2023 at 6:08=E2=80=AFPM Youling Tang <tangyouling@loon=
gson.cn> wrote:
> > > >
> > > > Hi, Huacai
> > > >
> > > > On 03/01/2023 05:30 PM, Huacai Chen wrote:
> > > > > Hi, Youling,
> > > > >
> > > > > On Wed, Mar 1, 2023 at 5:21=E2=80=AFPM Youling Tang <tangyouling@=
loongson.cn> wrote:
> > > > >>
> > > > >> Hi, Huacai
> > > > >>
> > > > >> On 03/01/2023 04:55 PM, Huacai Chen wrote:
> > > > >>> Since Linux-6.3, LoongArch supports PIE kernel now, so let's re=
introduce
> > > > >>> efi_relocate_kernel() to relocate the core kernel.
> > > > >>
> > > > >> If we strongly rely on the PIE feature after the modification, w=
e need
> > > > >> to modify it as follows,
> > > > > There is no strong rely, efi_relocate_kernel() can also handle th=
e
> > > > > non-PIE kernel.
> > > >
> > > > IMHO, if EFI_KIMG_PREFERRED_ADDRESS is no longer defined as
> > > > `PHYSADDR(VMLINUX_LOAD_ADDRESS)` (physical link address), we need t=
o
> > > > relocate through the RELOCATABLE function, so it is recommended to
> > > > select RELOCATABLE if EFI_STUB is enabled
> > > We can select RELOCATABLE when we modify EFI_KIMG_PREFERRED_ADDRESS.
> > > Before that I prefer to give a chance to build a non-PIE kernel.
> > >
> > > Huacai
> > > >
> > > > Youling.
> > > > >
> > > > > Huacai
> > > > >>
> > > > >> --- a/arch/loongarch/Kconfig
> > > > >> +++ b/arch/loongarch/Kconfig
> > > > >> @@ -137,6 +137,7 @@ config LOONGARCH
> > > > >>          select PCI_MSI_ARCH_FALLBACKS
> > > > >>          select PCI_QUIRKS
> > > > >>          select PERF_USE_VMALLOC
> > > > >> +       select RELOCATABLE
> > > > >>          select RTC_LIB
> > > > >>          select SMP
> > > > >>          select SPARSE_IRQ
> > > > >>
> > > > >> or:
> > > > >>
> > > > >> --- a/arch/loongarch/Kconfig
> > > > >> +++ b/arch/loongarch/Kconfig
> > > > >> @@ -360,6 +360,7 @@ config EFI_STUB
> > > > >>          default y
> > > > >>          depends on EFI
> > > > >>          select EFI_GENERIC_STUB
> > > > >> +       select RELOCATABLE
> > > > >>          help
> > > > >>
> > > > >> Youling.
> > > > >>
> > > > >>>
> > > > >>> Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
> > > > >>> ---
> > > > >>>  drivers/firmware/efi/libstub/loongarch-stub.c | 24 ++++++-----=
--------
> > > > >>>  1 file changed, 7 insertions(+), 17 deletions(-)
> > > > >>>
> > > > >>> diff --git a/drivers/firmware/efi/libstub/loongarch-stub.c b/dr=
ivers/firmware/efi/libstub/loongarch-stub.c
> > > > >>> index eee7ed43cdfb..72c71ae201f0 100644
> > > > >>> --- a/drivers/firmware/efi/libstub/loongarch-stub.c
> > > > >>> +++ b/drivers/firmware/efi/libstub/loongarch-stub.c
> > > > >>> @@ -21,26 +21,16 @@ efi_status_t handle_kernel_image(unsigned l=
ong *image_addr,
> > > > >>>                                efi_loaded_image_t *image,
> > > > >>>                                efi_handle_t image_handle)
> > > > >>>  {
> > > > >>> -     int nr_pages =3D round_up(kernel_asize, EFI_ALLOC_ALIGN) =
/ EFI_PAGE_SIZE;
> > > > >>> -     efi_physical_addr_t kernel_addr =3D EFI_KIMG_PREFERRED_AD=
DRESS;
> > > > >>>       efi_status_t status;
> > > > >>> +     unsigned long kernel_addr =3D 0;
> > > > >>>
> > > > >>> -     /*
> > > > >>> -      * Allocate space for the kernel image at the preferred o=
ffset. This is
> > > > >>> -      * the only location in memory from where we can execute =
the image, so
> > > > >>> -      * no point in falling back to another allocation.
> > > > >>> -      */
> > > > >>> -     status =3D efi_bs_call(allocate_pages, EFI_ALLOCATE_ADDRE=
SS,
> > > > >>> -                          EFI_LOADER_DATA, nr_pages, &kernel_a=
ddr);
> > > > >>> -     if (status !=3D EFI_SUCCESS)
> > > > >>> -             return status;
> > > > >>> -
> > > > >>> -     *image_addr =3D EFI_KIMG_PREFERRED_ADDRESS;
> > > > >>> -     *image_size =3D kernel_asize;
> > > > >>> +     kernel_addr =3D (unsigned long)&kernel_offset - kernel_of=
fset;
> > > > >>> +
> > > > >>> +     status =3D efi_relocate_kernel(&kernel_addr, kernel_fsize=
, kernel_asize,
> > > > >>> +                  EFI_KIMG_PREFERRED_ADDRESS, efi_get_kimg_min=
_align(), 0x0);
> > > > >>>
> > > > >>> -     memcpy((void *)EFI_KIMG_PREFERRED_ADDRESS,
> > > > >>> -            (void *)&kernel_offset - kernel_offset,
> > > > >>> -            kernel_fsize);
> > > > >>> +     *image_addr =3D kernel_addr;
> > > > >>> +     *image_size =3D kernel_asize;
> > > > >>>
> > > > >>>       return status;
> > > > >>>  }
> > > > >>>
> > > > >>
> > > >
> > > >