Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp523615rwl; Wed, 5 Apr 2023 04:20:45 -0700 (PDT) X-Google-Smtp-Source: AKy350ZT2lM0XoiVVu29oD8rJIZ63Cx3sJCe32f7oe2eTpZSL2C+nUrUJrAySyPRFQtrgcpoye1Q X-Received: by 2002:a17:902:fac7:b0:1a1:abc9:198f with SMTP id ld7-20020a170902fac700b001a1abc9198fmr1712898plb.4.1680693645506; Wed, 05 Apr 2023 04:20:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680693645; cv=none; d=google.com; s=arc-20160816; b=BDUerSZ7M7QsX3pbWs+C+yyfCPlgKjPz3SMELEfF0nQjtOMCftLg/BP8+qcZ6Wp5Kz UtyM2F5M0JSOQ8tu7+OLDVvd5ck3q7MeFVz8QtoGhq4HCRrSsdklMKfQX8xW59DyGKj0 xpSO6ajwF5pacx/InK7e2dAJ/KuLpFWsDuZlITuiCyKVgfLkNsb8tIzhkU8lGD8M99b6 G4zULxhG+HeVbZIFaKepRjwFhysMFRivW4iMt6OZ3HYk9dxab9bzZ8eQxeQc9Byd1JOK h0jO8JVd5QXjOp7CgLjBFcMB2pQtPaCkciGXtow8I0sXJ56zYY8sG9jB/dM9ysKAf/A5 8lLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=OVTqfRf2jpWEeoD6UNL26R0hpOD3j9XRAva3jj9aVBk=; b=H97sNEOtQZmH07OlIl0LvIPTgZeOXf/rvZw8oNl6BareZOzYbUERRgj7QbqNRHmSyQ LCfUjKWxRAIT1KMj2ue4a6cT9pdxRfwbk2mChIVDDFfWi8TR06V4HOL5oW0bcoTYXZDo Av1/EVBMy4ItxocsyaP7gqzcEZMjNV3vPw7oXcAh8u7pcu7PO5LB3wk1wVv8CFicKOPn u+yRRzAKNHn3MVamFdGZYSh87ZIVuLh9FY1eIhTWm1+u87ht9aRbC74fj59SY4BRMroo f+KrLGhpTb834oy7c8kUmNvcdohluSJ4KmuNn2D0nnfiM3SpJf5y/cVUj6CWKZQh1iuy wupQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UMTYBNcP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u7-20020a170902e80700b001a20679d548si2717864plg.183.2023.04.05.04.20.34; Wed, 05 Apr 2023 04:20:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UMTYBNcP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237870AbjDELUV (ORCPT + 99 others); Wed, 5 Apr 2023 07:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237835AbjDELUT (ORCPT ); Wed, 5 Apr 2023 07:20:19 -0400 Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD57C527F; Wed, 5 Apr 2023 04:19:59 -0700 (PDT) Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-54601d90118so514767947b3.12; Wed, 05 Apr 2023 04:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680693599; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OVTqfRf2jpWEeoD6UNL26R0hpOD3j9XRAva3jj9aVBk=; b=UMTYBNcPhbAF0ABt8KophwzX/Ny6OPNn+L6EnmU5IkTiR+fwtjtTvvmlWyMYj3Pkd/ c/AorgHXggjcy/x5fLftLDXcSRee6X3AtQ1pW2rCBk6CYlNeeb39l9Sc0PgP3d01I3hi qodJYbUqCHZ235SHXXOkTEXGGEHXyT2WxYP95YphXmCso64A4JEn5pUvLQzjn8+qM2mo ffZ5LUVWgPBrcIjs91pPf+lKHjgH0EcvEuCyvhchd69BLf5uIsTKD4aB1cF0OsfHG7q9 zt9q5kpD8Hxo6x9MnvBm6HE/Ec1pZ6n+yeI3K4SLL9P/DBFTyptpplVjTZnPhcQNN5G2 eRLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680693599; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OVTqfRf2jpWEeoD6UNL26R0hpOD3j9XRAva3jj9aVBk=; b=gnGsyHt0/baNqTyypBgsi4Nih6MEvvXIh2FBDoRoLxGkshOE67aoIv01kk/AAOIdRR Qn8FlkRX/zD9AmJp3+r0GQhweb1y36HFE/HhcW+9UuJKC8cypaAEYBIaZ33eD7ymmiMG TTLB+is/WT63/LPnTrppQaZcYzKYqRR+RtBVJG5+Du2nEAf89ZFeAFPBMvWAB4BfoZvR T8au+r5GJw8PaBYVf53iFB5OWV7dQ9cm2b6oR4E2y+eXAxTdD11iwy9RuaWVjV6fdCNo pYBRItOhRcAwIzfhKFEPzAnYjDbZVH8CuJYi7Z4Vu6ULsHx8idV6rA0pjdtDECwPz0Ws ogjA== X-Gm-Message-State: AAQBX9daecNUAAaCSOw0oTUHKKQ/Erg+Ya9I3nThUxJ4SCvD9Je5gm37 N9/pNS67O/jdZ6Z+/KdEKExq0dKOoi+W+xRJmJg= X-Received: by 2002:a81:c509:0:b0:52e:e095:d840 with SMTP id k9-20020a81c509000000b0052ee095d840mr3519608ywi.0.1680693598783; Wed, 05 Apr 2023 04:19:58 -0700 (PDT) MIME-Version: 1.0 References: <20230307-rust-drm-v1-0-917ff5bc80a8@asahilina.net> <20230307-rust-drm-v1-4-917ff5bc80a8@asahilina.net> In-Reply-To: From: Miguel Ojeda Date: Wed, 5 Apr 2023 13:19:47 +0200 Message-ID: Subject: Re: [PATCH RFC 04/18] rust: drm: gem: Add GEM object abstraction To: Asahi Lina , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Luben Tuikov , Jarkko Sakkinen , Dave Hansen , Alyssa Rosenzweig , Karol Herbst , Ella Stanforth , Faith Ekstrand , Mary , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-sgx@vger.kernel.org, asahi@lists.linux.dev Cc: Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 5, 2023 at 1:08=E2=80=AFPM Daniel Vetter wrot= e: > > Uh all the rust helper wrappers for all the kernel in a single file does > not sound good. Can we not split these up into each subsystem, and then > maybe instead of sprinkling #ifdef all over a .c file Make the compilatio= n > of that file conditional on rust support (plus whatever other Kconfig gat= e > the other c files has already)? Indeed, the plan is splitting the `kernel` crate and giving each subsystem its own crate, bindings, helpers, etc. Cheers, Miguel