Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 09:04:23 -0300
From:   Jason Gunthorpe <jgg@ziepe.ca>
To:     Steven Price <steven.price@arm.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Thomas Hellstrom <thellstrom@vmware.com>,
        Christoph Hellwig <hch@lst.de>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] smaps: Fix defined but not used smaps_shmem_walk_ops
Message-ID: <ZC1jx1LIwENgzTaO@ziepe.ca>
References: <20230405103819.151246-1-steven.price@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230405103819.151246-1-steven.price@arm.com>
Precedence: bulk

On Wed, Apr 05, 2023 at 11:38:19AM +0100, Steven Price wrote:
> When !CONFIG_SHMEM smaps_shmem_walk_ops is defined but not used,
> triggering a compiler warning. To avoid the warning remove the #ifdef
> around the usage. This has no effect because shmem_mapping() is a stub
> returning false when !CONFIG_SHMEM so the code will be compiled out,
> however we now need to also provide a stub for shmem_swap_usage().
> 
> Fixes: 7b86ac3371b7 ("pagewalk: separate function pointers from iterator data")
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304031749.UiyJpxzF-lkp@intel.com/
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> I've implemented Jason's suggestion of removing the #ifdef around the
> usage and prodiving a stub for shmem_swap_usage() instead.

This seems OK

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

  
>  extern bool shmem_is_huge(struct inode *inode, pgoff_t index, bool shmem_huge_force,
>  			  struct mm_struct *mm, unsigned long vm_flags);
> +#ifdef CONFIG_SHMEM
>  extern unsigned long shmem_swap_usage(struct vm_area_struct *vma);
> +#else
> +static inline unsigned long shmem_swap_usage(struct vm_area_struct *vma)
> +{
> +	return 0;
> +}
> +#endif

Though it would be nice if this file didn't have so many ifdef blocks

Jason