Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 13:02:05 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= 
        <amadeuszx.slawinski@linux.intel.com>
Cc:     "Ding, Shenghao" <shenghao-ding@ti.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "Lu, Kevin" <kevin-lu@ti.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Xu, Baojun" <x1077012@ti.com>, "Gupta, Peeyush" <peeyush@ti.com>,
        "Navada Kanyana, Mukund" <navada@ti.com>,
        Shenghao Ding <13916275206@139.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "perex@perex.cz" <perex@perex.cz>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>
Subject: Re: [EXTERNAL] Re: [PATCH v10] ASoC: tas2781: Add tas2781 driver
Message-ID: <84738924-8467-45e4-9e68-0f9633f938f7@sirena.org.uk>
References: <20230329100107.8181-1-13916275206@139.com>
 <8d0d0478-1e45-ea52-f1b7-910b747d6282@linux.intel.com>
 <7a0cfa60e2a244168edd49c3d2f6a2bd@ti.com>
 <458d7c2f-bcee-9ec3-e955-9661a06a3349@wanadoo.fr>
 <bbae9e35f2bf4cbcbc78f852041e4b2e@ti.com>
 <030c2cbf-dec3-91fb-ac82-949cf5764b78@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="e8MDLbCuMChiZ671"
Content-Disposition: inline
In-Reply-To: <030c2cbf-dec3-91fb-ac82-949cf5764b78@linux.intel.com>
Precedence: bulk


--e8MDLbCuMChiZ671
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 05, 2023 at 01:35:34PM +0200, Amadeusz S=C5=82awi=C5=84ski wrot=
e:

> It makes sense, as array access reads 8 bit value, you would need to acce=
ss
> value using pointer instead. So instead of doing be32_to_cpu(test_buf[i])
> you would need to do be32_to_cpu(*(test_buf + i)) if I didn't mess the
> pointer magic ;)

> And then I'm not sure which is better, be32_to_cpup or be32_to_cpu.

The p variant works with unaligned pointers but might be slower if the
architecture doesn't support unaligned access.  For this application it
probably doesn't matter either way.

--e8MDLbCuMChiZ671
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmQtYzwACgkQJNaLcl1U
h9Bc1Af/eDQye78rgNWb+jc+/dj+X+raUYc4Xq2BQbJ9RuBegejxWD1//K8Hh8UJ
spCMiiTZBMktU6pgggCwEEpkBGgMw2FA4lfLYaMw/lLBdqk3ISgcATGFn5c/APpX
qsQ1eI5FO7kfA40+xv5jg2n88okQHbLgjMzaZa8PJpU4gTY6X17QmGLfsl+3qbBz
uv4DXBbUSTvbXqHOLjSiUoWH+UBo3Ki2TIOwGi6USRkA+QnYulVu1PFqnYFsG5i8
ECmR1ms5JC05IEWOlPN4/jLOvaxycaQdOuCwsW2nf4FWGePt8JEwBGDX4tFU5mcT
7qi2zG7/UBJ34L1w7eAwy7XRzhMX1A==
=NOZi
-----END PGP SIGNATURE-----

--e8MDLbCuMChiZ671--