Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 14:13:57 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/9] thermal/drivers/tegra: remove redundant msg in
 tegra_tsensor_register_channel()
Message-ID: <ZC1mBUMF3MWmNqY5@orome>
References: <20230318144412.75046-1-frank.li@vivo.com>
 <20230318144412.75046-6-frank.li@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="gjylHNenLSUt247p"
Content-Disposition: inline
In-Reply-To: <20230318144412.75046-6-frank.li@vivo.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--gjylHNenLSUt247p
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 18, 2023 at 10:44:09PM +0800, Yangtao Li wrote:
> The upper-layer devm_thermal_add_hwmon_sysfs() function can directly
> print error information.
>=20
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  drivers/thermal/tegra/tegra30-tsensor.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/drivers/thermal/tegra/tegra30-tsensor.c b/drivers/thermal/te=
gra/tegra30-tsensor.c
> index cb584a5735ed..c243e9d76d3c 100644
> --- a/drivers/thermal/tegra/tegra30-tsensor.c
> +++ b/drivers/thermal/tegra/tegra30-tsensor.c
> @@ -523,8 +523,7 @@ static int tegra_tsensor_register_channel(struct tegr=
a_tsensor *ts,
>  		return 0;
>  	}
> =20
> -	if (devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd))
> -		dev_warn(ts->dev, "failed to add hwmon sysfs attributes\n");
> +	devm_thermal_add_hwmon_sysfs(ts->dev, tsc->tzd);

I don't see any error messages output by devm_thermal_add_hwmon_sysfs()
nor any of the functions that it calls. Did I miss something?

Thierry

--gjylHNenLSUt247p
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQtZgUACgkQ3SOs138+
s6GpURAAk+YDurZ447gp7uDTxfOaYD/WaSUnwC9TvOJ2fpt9y+YhH2otMIF8WAPM
lqfAnEYnCHORqpww0ARzYmoVtQ9m4QlaFSRzV7Wefu0q0EZvd2ao2Diw3h9Z2zaH
kqbwDxQVceIidxpdbodxpe3OuiZyPDc4D9mE7xCdg7ze+7mE+Ysht2eTks6LTJIr
GEB0Cso93K6QBcVYYHO3NAdMXQI9c79z5l4uovKBNLFM2Mqapy/JIVzo6zVEIBPM
fq7g2kaF54WlNBYRF73mM6x7dxJD4KQUK2Y0Va1OSE2zhvxiWnGg4EizY+VPKwys
9JKYv1/fDUj0oNzmBPO2kwBscNTfLKJJF6XBLDXPHaguO9CDWDEomFsXIenuAicB
hkQuOTwo9K6FTggivUZvZQiRn3HMFJf34Yv2E4LSZ/u6AjfrfT66/FEKlDKZFvON
WM0RK3OXHJm3Fo6pv1nE3mZz1+YMC9wVO0ZI9fFv7XW00WUVh5PFBdYDd+dWc8Y7
AAfZ3Q0RG/sIKfTCHXnOoHpRZfR52aHqV1taiK2wvV1+nD79S4SwAgTWbUJ+acbN
ClSTpbO4GlIvliyJnlt60ObPTNB6vOuI5M6nLNsNx6mUEo2K1JA/BkBU38G62isz
FldRzpXNAXQZ/YR5NUA2ybN1h3KmJvcgydL3Yc7Ml/HkXr2IXjw=
=uiiy
-----END PGP SIGNATURE-----

--gjylHNenLSUt247p--