Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <120b6729-c329-ea4d-2f69-f8bc5c2925bf@redhat.com>
Date:   Wed, 5 Apr 2023 05:25:29 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.1
Subject: Re: [PATCH] nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout
 storage-class-specifier to static
Content-Language: en-US
To:     Michael Walle <michael@walle.cc>
Cc:     srinivas.kandagatla@linaro.org, linux-kernel@vger.kernel.org
References: <20230404163629.1923871-1-trix@redhat.com>
 <cce4b409e20b073431b44a44f7f0a614@walle.cc>
From:   Tom Rix <trix@redhat.com>
In-Reply-To: <cce4b409e20b073431b44a44f7f0a614@walle.cc>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 4/4/23 12:09 PM, Michael Walle wrote:
> Am 2023-04-04 18:36, schrieb Tom Rix:
>> smatch reports
>> drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol
>>   'sl28vpd_layout' was not declared. Should it be static?
>>
>> This variable is only used in one file so it should be static.
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>
> Fixes tag?
>
I am cleaning all of the similar reports by smatch, there is a couple 
hundred.

Because the code works as-is, I do not consider them broken and needing 
fixes tags.

However I do not mind adding then if they are required.

Tom

> Reviewed-by: Michael Walle <michael@walle.cc>
>
> -michael
>