Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 14:26:38 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Akhil R <akhilrajeev@nvidia.com>
Cc:     christian.koenig@amd.com, digetx@gmail.com, jonathanh@nvidia.com,
        ldewangan@nvidia.com, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        sumit.semwal@linaro.org, wsa@kernel.org
Subject: Re: [PATCH v4 2/2] i2c: tegra: Share same DMA channel for RX and TX
Message-ID: <ZC1o_sIuQIfHg9pi@orome>
References: <20230324115924.64218-1-akhilrajeev@nvidia.com>
 <20230324115924.64218-3-akhilrajeev@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="hGLpMWdudz37EMFO"
Content-Disposition: inline
In-Reply-To: <20230324115924.64218-3-akhilrajeev@nvidia.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--hGLpMWdudz37EMFO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 24, 2023 at 05:29:24PM +0530, Akhil R wrote:
> Allocate only one DMA channel for I2C and share it for both TX and RX
> instead of using two different DMA hardware channels with the same
> slave ID. Since I2C supports only half duplex, there is no impact on
> perf with this.
>=20
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>  drivers/i2c/busses/i2c-tegra.c | 69 ++++++++++------------------------
>  1 file changed, 20 insertions(+), 49 deletions(-)

Looks good:

Acked-by: Thierry Reding <treding@nvidia.com>

--hGLpMWdudz37EMFO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQtaP4ACgkQ3SOs138+
s6EamhAAv4b1zBgK/e6dZi4UXAcYvW4zrOPbfafutYP0oaj3V967WmuhGo2LN7Ij
p1ZmekWO7XPjj/ryNETIQAYWYAotdQMJkjLvVgz10Jp7iNXcn2mbrk1Frs7tQIZk
FJW1fCZEmpoM2tz2rxpf/+DAG1QcaRJMzuAKMRBCCjN5StRlZpOIOTrehafY1dWF
IF2bPQso0SC6dz1UTLnxwECd4Ir7tElMShUNSPqy0vRq/q+9TqAFFxlQo5BgOoXo
+wl5nPp7D5O7UiW0fs4xcFksIp0kxyLr06O0NtQ5NxkSp3W2Nrb863hkWnm3fELy
mcj0y+y0+JnJvU9KTRi8D+HtitRFdWl/wg1ZVZPH4rqjpcu0LmEWrvSiBLe4mV+K
Ft0jP8K9yZZ+gow6tn1l5MdxXiMBDc2vstSYxMxFjB9p/yfPWyWNGd0+3ET+RaXU
fvgm+Ao5MaXC2a6vxB8GBejaoR71Mr2Hv0P5tAhIQ4iVUZoyuBo0dzBC847oHJg4
rW8wpPPgscPX2To+Ss33TGv/WmO80pRiE8ycEUSCixV2Fj2W4/7SM0a8mgwGFGMy
UrWcbSNFFmf49GECos96cNBp4yNntUA6gazLphd4a0AUTA3SwhKyMlAhBxSSzvP4
NQjOAyov6rsmux+wF9N4j4U3w8+/1fP8+pkbX83rOKLpAIqR/gA=
=k57D
-----END PGP SIGNATURE-----

--hGLpMWdudz37EMFO--