Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 14:55:01 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Mikko Perttunen <cyndis@kapsi.fi>
Cc:     Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Mikko Perttunen <mperttunen@nvidia.com>,
        linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: tegra194: Handle errors in BPMP response
Message-ID: <ZC1vpXRoHb3H2alF@orome>
References: <20230208142735.3218707-1-cyndis@kapsi.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="uk3AIlB7GyEsN23u"
Content-Disposition: inline
In-Reply-To: <20230208142735.3218707-1-cyndis@kapsi.fi>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--uk3AIlB7GyEsN23u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 08, 2023 at 04:27:35PM +0200, Mikko Perttunen wrote:
> From: Mikko Perttunen <mperttunen@nvidia.com>
>=20
> The return value from tegra_bpmp_transfer indicates the success or
> failure of the IPC transaction with BPMP. If the transaction
> succeeded, we also need to check the actual command's result code.
> Add code to do this.
>=20
> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
> ---
>  drivers/pci/controller/dwc/pcie-tegra194.c | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)

Lorenzo asked whether the error check could be incorporated into
tegra_bpmp_transfer() in reply to an earlier version of this. It would
be possible, but I think it has the downside of loosing some context.
The end result would still be the same, but it would make it impossible
for the caller to distinguish between a failure of tegra_bpmp_transfer()
and a failure of the message transaction.

For example the cpufreq driver checks for msg.rx.ret =3D=3D -BPMP_EINVAL and
if that's returned will mark the given cluster as not available. This is
special behavior that only makes sense within the context of cpufreq. It
wouldn't be possible to make these decisions if tegra_bpmp_transfer()
did some automated conversion and effectively rolled the message error
into the function return error.

So I think this will need to stay as-is to make sure we can handle these
errors correctly.

Acked-by: Thierry Reding <treding@nvidia.com>

--uk3AIlB7GyEsN23u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmQtb6MACgkQ3SOs138+
s6EQag//SeOpJ8NPsSwZEk/4IYWE/s7a21ssZ/jZ+ZPty3DnS2IqhT7rD0om8eBe
X3s7zT5xt35Qwi2i4+aaTVkimdt+zdYM5oDapFX/dOiC5irW1PCpaScroTvbObYP
N3dQ8wztuJagGolWvt1SyiuwXMt5wuIAYo/RcnlDg9iozvgo72KoEnEmfrMfEPcb
pLwmFOAP5I6abuzeHDBtirw6AZvWcgcmnngFQN0ZEa6q7QmXw4qiuYBN6yZsIw/U
H5ecgOqEOtZKO4nN/xsIRbnvXIXsTA4Y05jMlGR+1xEWKhUaJQ+z2RpbeUG8+U/h
sAR2TxJVVUeyj7UNOayxFNf/oO98GZfQi/FycYPUJqr0h9IH3vAk4vh9QchiFHCb
tOi1K6geT+doP1lkOFcQ3eizqu6T5ocFY0f2NFbakPXaFMkb3pJNYK7Wm6/F9O03
slL82TZALrVbEwRuwdLclSqB0+rwp5mCiytwE19TVzQp7dIxQLjkTB9bX/vTbgkv
r/7Mt/p5n8NmTWYIMYmHlzgeBF0EHDVeGB6znLbQ4ZSPBDN/mZWFLJ8XpE5Nlli1
1h8t/M/W/IA0ZSW8gW2dcXXd678DAC+p2C3bcCA56zYh6Jqh/WPDM2StL5aBLZo5
pG8lg2/rtzbnIqx5O33oqoUpcwArJtGiaYqox8r5lH10p9i+ZH4=
=Hkx5
-----END PGP SIGNATURE-----

--uk3AIlB7GyEsN23u--