Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ee6a428b-905c-82ac-48fd-0b440d90e014@metafoo.de>
Date:   Wed, 5 Apr 2023 07:21:00 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH 2/4] iio: dac: mcp4922: get and enable vdd regulator
Content-Language: en-US
To:     Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230405140114.99011-1-frattaroli.nicolas@gmail.com>
 <20230405140114.99011-3-frattaroli.nicolas@gmail.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
In-Reply-To: <20230405140114.99011-3-frattaroli.nicolas@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/5/23 07:01, Nicolas Frattaroli wrote:
> [...]
> +	state->vdd_reg = devm_regulator_get(&spi->dev, "vdd");
> +	if (IS_ERR(state->vdd_reg)) {
> +		ret = dev_err_probe(&spi->dev, PTR_ERR(state->vdd_reg),
> +				    "vdd regulator not specified\n");
> +		goto error_disable_vref_reg;
> +	}
> +	ret = regulator_enable(state->vdd_reg);
> +	if (ret) {
> +		dev_err(&spi->dev, "Failed to enable vdd regulator: %d\n",
> +			ret);
> +		goto error_disable_vref_reg;
> +	}
The two above can be combined into `devm_regulator_get_enable()`. This 
will also take care of automatically disabling the regulator on the 
error path and on remove.
> +
>   	spi_set_drvdata(spi, indio_dev);
>   	id = spi_get_device_id(spi);
>   	indio_dev->info = &mcp4922_info;
> [...]