Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp905890rwl; Wed, 5 Apr 2023 09:10:59 -0700 (PDT) X-Google-Smtp-Source: AKy350a+qM32RwnmOstCHTbDcsXK8z4CM3NiTNDktSs8F0p/Kwr9r/azS6VFVc0Xc/SKPSxWkATL X-Received: by 2002:a05:6a20:6d09:b0:dc:a14e:d9bf with SMTP id fv9-20020a056a206d0900b000dca14ed9bfmr5308988pzb.43.1680711059615; Wed, 05 Apr 2023 09:10:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680711059; cv=none; d=google.com; s=arc-20160816; b=j1VEBUBLw2tT5TR5Jgfyp71wpT31YeiJMP7UgisdPLW5ttEqlsq0bFgmWDYH+0L0fj BaFv8nc9iO/REIWiEQBRGvjWDtBd0r9POwKFQfS7AF88372BaFyvKMsRQZ1rNQTkvoa5 n3mQMc/BDVNk43Mwk9xRyOlMF82X5UJRWBs2UKb68LJ8IlpnAJ3c9kN0XOXdeAHvqxfE MDgrAVEFHPj4UKyzCUcSMDf8xoOCK7lHLDcT0m2pZCt2QdPE74af6e9qFQtZwgBrzQ8G 13zncHGUKUEn0aBbdG7+Cl24LuOmVl+11t0ptwunCEtKC56aJUFsek5XYpXLZQYWD6ce 5QHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=h82lgj63761it4Zz6EVQZAD8HXJt6YMzMIKXUxq/7Bs=; b=vSTrbVRdbi5xawxUAhiQgIrXke097lvb4rffdHVige9vO1MueXGXsBERmUEYsbpRUo jDDH8wj2llq53Yamwfnkx+aXmYG9coFSUonl3UxlAmxO3vnfjjWIxsFYxrNz1mPGfxkK Y8AdRlJy7DsB5CsWb9eQZlJ3jAHKbvPS5kvImanFSQyLZYV4mlY2OycBH/NvfrmZ3AaK AAC4oxdBV/L/HhNVgPM9Sy5fUfzpcSNSt0svoyyCcVCxHWPDbzDXt2oMTTyQsWGTLDWK OHPuMSkGFLBzhOYGCaWRp5nBBFVbkLx7FmPPkAwAvHM34PXGWIiV8gWyUuMuPEvWWbNR kzpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=P29N9gyN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs1-20020a632801000000b00513a2e4d889si1829248pgb.475.2023.04.05.09.10.45; Wed, 05 Apr 2023 09:10:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=P29N9gyN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238537AbjDEQDr (ORCPT + 99 others); Wed, 5 Apr 2023 12:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238997AbjDEQDi (ORCPT ); Wed, 5 Apr 2023 12:03:38 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DC915FE1 for ; Wed, 5 Apr 2023 09:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680710567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h82lgj63761it4Zz6EVQZAD8HXJt6YMzMIKXUxq/7Bs=; b=P29N9gyNDRXAQ9pDIT6BDXckEPPLdmFCjYrmHzWAjfWnC1VZj6xk5PpFG5cmqGwcOzquB2 IO+0jIUkSRTkO6+qBgSgg1quITlDXC2a7X9P/h+VVJ2SACyzF1EtD6APv2AwAgZtNjp8gM 04lMg7FAzauXOqVTgoBFn5I9noW0wBw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-362-qOVvPJqdMVKCgg9ZnLA2WQ-1; Wed, 05 Apr 2023 12:02:42 -0400 X-MC-Unique: qOVvPJqdMVKCgg9ZnLA2WQ-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 45F2C88B767; Wed, 5 Apr 2023 16:02:41 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.35]) by smtp.corp.redhat.com (Postfix) with SMTP id 12970400F57; Wed, 5 Apr 2023 16:02:37 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 5 Apr 2023 18:02:32 +0200 (CEST) Date: Wed, 5 Apr 2023 18:02:28 +0200 From: Oleg Nesterov To: Catalin Marinas Cc: Gregory Price , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, avagin@gmail.com, peterz@infradead.org, luto@kernel.org, krisman@collabora.com, tglx@linutronix.de, corbet@lwn.net, shuah@kernel.org, arnd@arndb.de, Gregory Price Subject: Re: [PATCH v15 2/4] syscall user dispatch: untag selector addresses before access_ok Message-ID: <20230405160227.GA13943@redhat.com> References: <20230330212121.1688-1-gregory.price@memverge.com> <20230330212121.1688-3-gregory.price@memverge.com> <20230404104506.GA24740@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/05, Catalin Marinas wrote: > > > Yes, from the security perspective, but there are ABI implications. Thanks a lot for your explanations. To be honest, I am still a bit confused... Will try to grep the relevant code. But as for this patch, now I believe it is correct. So, FWIW, Acked-by: Oleg Nesterov