Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp923176rwl; Wed, 5 Apr 2023 09:22:57 -0700 (PDT) X-Google-Smtp-Source: AKy350YrTEZ71SD7cM7ozWqULvxtoZSuniEbvyc0LyGVQbub3wz31yxfsbAaJZNz1cir7x57wN+K X-Received: by 2002:a17:906:6d97:b0:885:fee4:69ee with SMTP id h23-20020a1709066d9700b00885fee469eemr3531550ejt.59.1680711776792; Wed, 05 Apr 2023 09:22:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680711776; cv=none; d=google.com; s=arc-20160816; b=Wjra63JUe+gVs8MPuR1SB7qhsuUu5hs+PRD8KoRcFV2Lb3ONc5LPLw9Zc1zuUtf7G7 xP6MvUo5EX8k2Ow0IFVYn1/BZ8SsbTwjGg72/BC2pqkiepzr7c/INEBXktfTxwD+kYRh tLa+dOH+miC3/hY4dTeHVHkUp9NjqaiR3Nks1WNE1cg+mNCprRBW9YToiBi3IoO6P2i9 pXZb0ppmBqRY8x02jLa96lr4ddn/ln+57VomyCurnmnXBeFxzDZ2xqkSDnYS1sL4q42T pK/wOja5MjhmanJuMZkGHTCqC0SXsQJQuVglcsAO77Qb3CslmZd9HhrGMg2yVBMSe3C1 6Jng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+k2iQv33P/fTdI9liK2nPnC8BnN5vQr2IFB/6e+xxF0=; b=dqiixGZshQOZi6lxQO48i3RqOcsr2MCD+D0FMpVMZTLJXZ8rwnHoOcy2DkeMD+Z/z4 a0Nra3/eu3xXFr2Fdjqu6HyVFnAeoCdpn5THJpM36M7JN/TKGp9To2rMbr8zuhzDIu9N Gm+4a6yVnbR3wv2iEkBvb1OX5qwHiW9qdP7857ShJTQjKCEj17BKEYXWLGQQhS2Lb/A9 wvaqrO9BkX4/D8+CAHt20I63ZwoAySJCMKcco9lo9Y8/k59Mb/ccXu3vvpS+tPyVW1++ 4wSJsA/EMD/KOcwJ9/UWWaZCKdN6DgXV+tptNcCKm4ERtO2BPjKrhWu+oVX/bpbYe5R3 XOcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uNFm0cqZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e24-20020a170906845800b009334a8e8c07si1030260ejy.103.2023.04.05.09.22.27; Wed, 05 Apr 2023 09:22:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uNFm0cqZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232406AbjDEQWF (ORCPT + 99 others); Wed, 5 Apr 2023 12:22:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232206AbjDEQWD (ORCPT ); Wed, 5 Apr 2023 12:22:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F0F1729F for ; Wed, 5 Apr 2023 09:21:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E7A3363F67 for ; Wed, 5 Apr 2023 16:21:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57E2FC433D2; Wed, 5 Apr 2023 16:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680711709; bh=ef2YepiMAXx8RjWeBXAJGEINglAm0SF9NGq0mwWfm9g=; h=From:To:Cc:Subject:Date:From; b=uNFm0cqZXj4E38P6Z6QbhfvfCrMxn81ukq7npYUC2ISHSLJaPu1SBDaOkNpCGD2fM nS8V17kZby73sy1Z1c2mv4hUW+l9QYX/GPKrDf2zoxhS1/Sx0ZajzFnM0JKV7rFeUc fsT6+BM58vkDaphGnCwbHvhADHpiBp6uwKtAZbT4wY9mHszCRTISnO4omatC+u/Uyz IyNTNgMThi2aEhVXHbO2CI1G/dRiUQJgDrsew3O9WN0o/yd8+EfgB4x4mtMqVEVuqp EGFc0ZnJdcHvJlY88A146ybIBF3n/GpwAvu5a79hLdZM1+AQAFpTrL+i/hosFJHeap RcjWLPnibw2UA== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu , Daeho Jeong Subject: [PATCH] f2fs: fix to check return value of f2fs_do_truncate_blocks() Date: Wed, 5 Apr 2023 22:44:53 +0800 Message-Id: <20230405144453.930311-1-chao@kernel.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Otherwise, if truncation on cow_inode failed, remained data may pollute current transaction of atomic write. Cc: Daeho Jeong Fixes: a46bebd502fe ("f2fs: synchronize atomic write aborts") Signed-off-by: Chao Yu --- fs/f2fs/file.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 10743e864d57..39c41c7e834b 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -2113,7 +2113,11 @@ static int f2fs_ioc_start_atomic_write(struct file *filp, bool truncate) clear_inode_flag(fi->cow_inode, FI_INLINE_DATA); } else { /* Reuse the already created COW inode */ - f2fs_do_truncate_blocks(fi->cow_inode, 0, true); + ret = f2fs_do_truncate_blocks(fi->cow_inode, 0, true); + if (ret) { + f2fs_up_write(&fi->i_gc_rwsem[WRITE]); + goto out; + } } f2fs_write_inode(inode, NULL); -- 2.36.1