Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 5 Apr 2023 18:21:57 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Sumitra Sharma <sumitraartsy@gmail.com>
Cc:     Manish Chopra <manishc@marvell.com>, GR-Linux-NIC-Dev@marvell.com,
        Coiby Xu <coiby.xu@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        netdev@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: qlge: Remove macro FILL_SEG
Message-ID: <ZC2gJdUA6zGOjX4P@corigine.com>
References: <20230405150627.GA227254@sumitra.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230405150627.GA227254@sumitra.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?l1oZZqzDolxnjw5e+ZqmIQLqvEyV7DtnVff8KW3h7d7pelRF33W+80mJYWHJ?=
 =?us-ascii?Q?Bi4BSTyRsNjoj0bcSFyi/OpU6rsij+UE6WKqaoRBtAMUmVHH3Ft6Cxu2lvx1?=
 =?us-ascii?Q?NDuTx9MY2/OVG2B6VdmGNx2d14O5Xjc8rKgT0Ktj6izonicODnPGdAoMoImw?=
 =?us-ascii?Q?agPhAZvAt+gNPiZuKYomQmql+JXsFJ9AF0Es7R/nVyPur1LTR2yh7pKwpb81?=
 =?us-ascii?Q?XhFNDGSdNKd7iurYSYsybjncLm1IfdD1N29VTl3WYPqMvgEnQWDAV5MncYck?=
 =?us-ascii?Q?4kx/YxZYLfrjBWjxxIKomqGth+Gh+6aO9YP5Az7JyHsqHaiN4Uu9RZ/s12V1?=
 =?us-ascii?Q?Z2pWtIjlxY5a5fuIirW+U+fo76QcRDqZA7L3eqIJdktdT8PvpqRI46wYv9iX?=
 =?us-ascii?Q?i061tpra4ShKbgYKw6sozwKUFuzDJdW3qJBF0PQdry28T12CQeCTNtrGoXDQ?=
 =?us-ascii?Q?J4YVEBgjTnh8d1umN3JkWrE7Hp1bTUGepn12P60NxZGmqNCMd1W+n8xH2Mfl?=
 =?us-ascii?Q?yblsmC+lTJnc860vgmhTHEb/cdOu5hVs2Oc9bWe8GfEmR/YpqA4usBQBS0di?=
 =?us-ascii?Q?Njq8zB5GhEhaHAJ9U5cGsD9/rFPBxpNF9KKahcJTfDoip1Kqvrd271N08+Z4?=
 =?us-ascii?Q?27HIQ5RggPnZdBmyi4T3N9gNcAh+TUnMiZYAydl66fNexSwYy8R1cR2rGKAC?=
 =?us-ascii?Q?TTzZ6ujLjKFG5Khnxvs7MMxB98xRc5jTr/zQYQ60WOh9hzJbsn1zmHYmxlGa?=
 =?us-ascii?Q?gAo1qhddbqdPvUZPLl9PC7BibBLfTRJyimCIGWLE3bKEuTBspfCneLtDbCBZ?=
 =?us-ascii?Q?s2SWe1a9bqtaF/duB3RdKKZq9kGySYPV2r0bKXw3DpkUs+QgFpwySPhhTA/5?=
 =?us-ascii?Q?nOl8MmvE1eknV0HAaMEC7h2fWr1iYkYyExN/jVkC3MyYUjmeJ9ZG/ESZxieb?=
 =?us-ascii?Q?REc2Qea89PWJT3TNIWRI2iE3OoLMYrDdUeUvo/8Rnq+RubdjzOIxAItijQEA?=
 =?us-ascii?Q?C+/S/9K8sS3HHssFDTpQfGXpCjAQa1ZtecZcAFad1PDYk4QsMa4IFn+01rZX?=
 =?us-ascii?Q?iqkkks8j4aBasEKqE/B0wKK6Iwt4zHE0eVNRpQ7kGN1wZ0Ch2eaP33wqIAFq?=
 =?us-ascii?Q?024Huphin+BJj7LxKm7V5RFLVWZbxvS3vWSo1INASZrS1b9DTjzL+cWgHzA1?=
 =?us-ascii?Q?5be4Q6DPQ6UWqI1dezJv4eNGbo6uFKoZK6zCG77xCc+TKp/jqinXo+9jSamq?=
 =?us-ascii?Q?wloKs7z1knrx33jXPh1Gw69TSACfNYBN5p9vWhCMexsHLa/5cyvJ2asaTHwt?=
 =?us-ascii?Q?ERUdL6xTofj6Vncu41NfVrmISTBsz3DmYbgCJC+8Pf3ZjKd97bMh9N3VD6vN?=
 =?us-ascii?Q?wqsc69yLmFHy1Byl7pGhqdaKd0zYlRGWlE6u4YNQ53HWtdQpmPRSMPk2hGWN?=
 =?us-ascii?Q?y98nmPQHOWxzyCFmSjpmmrUN3fGl+A7/KVyQu5brCmIv/N/hyvxzxpSbDZTo?=
 =?us-ascii?Q?8o0+mROtkP5tSdzAOcmXAUCex7uwfjHqdkMDPDGoHjzJmd30dsNMU33iwxzd?=
 =?us-ascii?Q?jNlE9hrEyRjbHjf0dPzWyy7Z7mnjTEa78lw07T2bZgjSdQWTkIMiYHJewdlT?=
 =?us-ascii?Q?ZPFVOoyiZyjdevPOpRfLaguSaYKUlT1S+vn7rjdAQwIuK9mWDFDJCtMIrWGv?=
 =?us-ascii?Q?V0w5NA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 62d7cc77-dbf2-4f96-b11e-08db35f1e425
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2023 16:22:03.5848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kXJ3DYvH5/pvT2VP5kVPUE4qyvrq37qiTVW4/PX5zbLzjTbxFnz7ulI1HiPZam/AagtPuNsqXAVuRR8phiXB16AWh4kUHDKJDSEEKtrII0Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR13MB4583
X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 05, 2023 at 08:06:27AM -0700, Sumitra Sharma wrote:
> Remove macro FILL_SEG to fix the checkpatch warning:
> 
> WARNING: Macros with flow control statements should be avoided
> 
> Macros with flow control statements must be avoided as they
> break the flow of the calling function and make it harder to
> test the code.
> 
> Replace all FILL_SEG() macro calls with:
> 
> err = err || qlge_fill_seg_(...);

Perhaps I'm missing the point here.
But won't this lead to err always either being true or false (1 or 0).
Rather than the current arrangement where err can be
either 0 or a negative error value, such as -EINVAL.

...